From: David O. <Da...@di...> - 2002-10-18 23:38:14
Attachments:
patch.gaim.dindinx9.bz2
|
Hi, This is the daily new version of the GtkTextView/GtkTreeBuffer patch. Not many new things this time. The tab completion has been resurected (asked by lsc...@re...) As always, please test and report problems (the gtkspell is still missing, I already know this point). Regards, DindinX -- Da...@di... "This is my gift, it is my curse." |
From: David O. <Da...@di...> - 2002-10-18 23:53:02
Attachments:
patch.gaim.dindinx_8_to_9
|
On Sat, Oct 19, 2002 at 01:34:16AM +0200, David Odin wrote: > > Hi, > > This is the daily new version of the GtkTextView/GtkTreeBuffer patch. > Not many new things this time. > > The tab completion has been resurected > (asked by lsc...@re...) > > As always, please test and report problems (the gtkspell is still > missing, I already know this point). > And, as requested by Ethan, here is the diff between the previous patch and this one. Regards, DindinX -- Da...@di... Washington, D.C: Fifty square miles almost completely surrounded by reality. |
From: Nathan W. <fac...@fa...> - 2002-10-19 02:52:14
|
I wrote something about the patch earlier, but it was too big, so it's waiting on moderation. here's the link: http://faceprint.com/code/gaim/gtk2-input-with-typing.diff --=20 Nathan Walp || fac...@fa... GPG Fingerprint: || http://faceprint.com/ 5509 6EF3 928B 2363 9B2B DA17 3E46 2CDC 492D DB7E |
From: Ethan B. <ebl...@cs...> - 2002-10-19 02:59:27
|
Nathan Walp spake unto us the following wisdom: > I wrote something about the patch earlier, but it was too big, so it's > waiting on moderation. here's the link: >=20 > http://faceprint.com/code/gaim/gtk2-input-with-typing.diff And I also sent a counter-patch that got held up by moderation. :-P http://irg.cs.ohiou.edu/~eblanton/gaim-patches/gaim-cvs-dindinx-with-typing= .diff This patch is: * David Odin's gtk2 input patch * Nathan Walp's typing notification cleanups * My cleanup of David's patch plus a pretty recessed frame around the GtkTextInput widget. My personal opinion is that this is ready for inclusion. It has some =20 outstanding issues (enter-to-send does not work with XIM, for one),=20 but it is approximately 10000x better than what we have right now. I'd like to get it in and get the bugs beaten out as soon as possible.=20 =20 Ethan --=20 And if I claim to be a wise man / it surely means that I don't know. -- Kansas, "Carry on Wayward Son" |
From: David O. <Da...@di...> - 2002-10-19 11:31:01
|
On Fri, Oct 18, 2002 at 09:57:58PM -0500, Ethan Blanton wrote: > Nathan Walp spake unto us the following wisdom: > > I wrote something about the patch earlier, but it was too big, so it's > > waiting on moderation. here's the link: > > > > http://faceprint.com/code/gaim/gtk2-input-with-typing.diff > > And I also sent a counter-patch that got held up by moderation. :-P > > http://irg.cs.ohiou.edu/~eblanton/gaim-patches/gaim-cvs-dindinx-with-typing.diff > > This patch is: > * David Odin's gtk2 input patch > * Nathan Walp's typing notification cleanups > * My cleanup of David's patch plus a pretty recessed frame around > the GtkTextInput widget. > > My personal opinion is that this is ready for inclusion. It has some > outstanding issues (enter-to-send does not work with XIM, for one), > but it is approximately 10000x better than what we have right now. > I'd like to get it in and get the bugs beaten out as soon as possible. > Great. I have just a few remarks: - You've put the input entry above the iconbar. Is this on purpose? I tend to prefer the iconbar above the entry. - You've replace the 'entry_view' field by 'entry'. I guess it was to reduce the patch size. I'm afraid this could cause some hard-to-find bugs because the 'entry' field can be used with its former meaning (i.e a pointer to a GtkText, not a GtkTextView) by other part of gaim's code. Anyway, this two issues could be looked at afterward. Regards, DindinX -- Da...@di... You know it's Monday when you wake up and it's Tuesday. -- Garfield |
From: Nathan W. <fac...@fa...> - 2002-10-19 15:42:18
|
On Sat, Oct 19, 2002 at 01:30:38PM +0200, David Odin wrote: > - You've replace the 'entry_view' field by 'entry'. I guess it was to > reduce the patch size. I'm afraid this could cause some hard-to-find > bugs because the 'entry' field can be used with its former meaning > (i.e a pointer to a GtkText, not a GtkTextView) by other part of > gaim's code. Well, once you changed it to entry_view, we were 100% certain that we had gotten all instances of it, so it was changed back. New uses of the field in the old manner won't magically appear, and this makes the diff much easier to parse, and see the true functionality changes. Nathan --=20 Nathan Walp || fac...@fa... GPG Fingerprint: || http://faceprint.com/ 5509 6EF3 928B 2363 9B2B DA17 3E46 2CDC 492D DB7E |
From: Ethan B. <ebl...@cs...> - 2002-10-19 16:08:49
|
David Odin spake unto us the following wisdom: > On Fri, Oct 18, 2002 at 09:57:58PM -0500, Ethan Blanton wrote: > > And I also sent a counter-patch that got held up by moderation. :-P > > Great. I have just a few remarks: >=20 > - You've put the input entry above the iconbar. Is this on purpose? I > tend to prefer the iconbar above the entry. Oops! That was a last-minute breakage, probably caused when I put in the frame... I certainly did not mean to do it. The patch has been updated on the web. > - You've replace the 'entry_view' field by 'entry'. I guess it was to > reduce the patch size. I'm afraid this could cause some hard-to-find > bugs because the 'entry' field can be used with its former meaning > (i.e a pointer to a GtkText, not a GtkTextView) by other part of > gaim's code. As Nathan said, your changing of the variable name guarantees that all instances were caught. That said, I'm pretty sure the notify plugin is busted with this patch. At one point I had hacked a Makefile not to build it, and I don't recall fixing it... Ethan --=20 And if I claim to be a wise man / it surely means that I don't know. -- Kansas, "Carry on Wayward Son" |
From: David O. <Da...@di...> - 2002-10-19 16:36:23
|
On Sat, Oct 19, 2002 at 11:01:59AM -0500, Ethan Blanton wrote: > David Odin spake unto us the following wisdom: > > On Fri, Oct 18, 2002 at 09:57:58PM -0500, Ethan Blanton wrote: > > > And I also sent a counter-patch that got held up by moderation. :-P > > > > Great. I have just a few remarks: > > > > - You've put the input entry above the iconbar. Is this on purpose? I > > tend to prefer the iconbar above the entry. > > Oops! That was a last-minute breakage, probably caused when I put in > the frame... I certainly did not mean to do it. The patch has been > updated on the web. > Thanks! ;-) > > - You've replace the 'entry_view' field by 'entry'. I guess it was to > > reduce the patch size. I'm afraid this could cause some hard-to-find > > bugs because the 'entry' field can be used with its former meaning > > (i.e a pointer to a GtkText, not a GtkTextView) by other part of > > gaim's code. > > As Nathan said, your changing of the variable name guarantees that all > instances were caught. That said, I'm pretty sure the notify plugin > is busted with this patch. At one point I had hacked a Makefile not > to build it, and I don't recall fixing it... > Gtk should issue warning if we use a GtkTextView where a GtkText is expected anyway. So, these sort of problem should be caught easily. By the way, I've seen on the gtkspell's official site that the current version use a GtkTreeView and is ready for gtk+2. What is the policy there? Grab the source and put them in the gaim tree (after having informed the gtkspell author of course)? Add a new dependency for gaim on gtkspell? I would prefer the former. Regards, DindinX -- Da...@di... The biggest mistake you can make is to believe that you are working for someone else. |
From: Rob F. <ro...@ma...> - 2002-10-19 17:57:13
|
Also, I was unable to send messages to the chatroom... (or receive messages) On Sat, 2002-10-19 at 12:01, Ethan Blanton wrote: > David Odin spake unto us the following wisdom: > > On Fri, Oct 18, 2002 at 09:57:58PM -0500, Ethan Blanton wrote: > > > And I also sent a counter-patch that got held up by moderation. :-P > > > > Great. I have just a few remarks: > > > > - You've put the input entry above the iconbar. Is this on purpose? I > > tend to prefer the iconbar above the entry. > > Oops! That was a last-minute breakage, probably caused when I put in > the frame... I certainly did not mean to do it. The patch has been > updated on the web. > > > - You've replace the 'entry_view' field by 'entry'. I guess it was to > > reduce the patch size. I'm afraid this could cause some hard-to-find > > bugs because the 'entry' field can be used with its former meaning > > (i.e a pointer to a GtkText, not a GtkTextView) by other part of > > gaim's code. > > As Nathan said, your changing of the variable name guarantees that all > instances were caught. That said, I'm pretty sure the notify plugin > is busted with this patch. At one point I had hacked a Makefile not > to build it, and I don't recall fixing it... > > Ethan > > -- > And if I claim to be a wise man / it surely means that I don't know. > -- Kansas, "Carry on Wayward Son" |
From: Ethan B. <ebl...@cs...> - 2002-10-19 18:05:58
|
Rob Flynn spake unto us the following wisdom: > Also, I was unable to send messages to the chatroom... (or receive > messages) Hmmm, it worked for me last night ... Let me try again and make sure I haven't broken anything. Ethan --=20 And if I claim to be a wise man / it surely means that I don't know. -- Kansas, "Carry on Wayward Son" |
From: Ethan B. <ebl...@cs...> - 2002-10-19 19:35:35
|
David Odin spake unto us the following wisdom: > - You've put the input entry above the iconbar. Is this on purpose? I > tend to prefer the iconbar above the entry. I had done the same for the chat dialog, I've updated my patch again. http://irg.cs.ohiou.edu/~eblanton/gaim-patches/gaim-cvs-dindinx-with-typing= .diff This continues to work well for me. :-) Still the XIM problem, but I might have a lead on that. Ethan --=20 And if I claim to be a wise man / it surely means that I don't know. -- Kansas, "Carry on Wayward Son" |
From: Nathan W. <fac...@fa...> - 2002-10-19 02:33:20
Attachments:
gtk2-input-with-typing.diff
|
OK, at long last, here's the gtk2-input patch by David Otin, fixed up by Ethan Blanton, and now with working typing notification stuff by me. Enjoy! Nathan -- Nathan Walp || fac...@fa... GPG Fingerprint: || http://faceprint.com/ 5509 6EF3 928B 2363 9B2B DA17 3E46 2CDC 492D DB7E |