From: <tho...@la...> - 2005-09-25 08:27:11
Attachments:
ImageTile.php
|
temp files are now stored in uploads directory instead of /var/tmp. config.ini is parsed to handle DATA_PATH. -- Thomas Harding |
From: Reini U. <ru...@x-...> - 2005-09-25 15:07:21
Attachments:
.cvsdiff.gz
|
Thomas Harding schrieb: > temp files are now stored in uploads directory instead of /var/tmp. > config.ini is parsed to handle DATA_PATH. Just to keep you informed what I'm working on and what I haven't commmitted yet, I attached my local cvs diff. And please, Thomas, send unifixed diff's. diff -bu old new or cvs diff -bu I cannot stand context diffs. Comments: --------- ImageTile thumbs: I think we should put these files either into some PLUGIN_CACHED subdir or into uploads/thumbs. UpLoadPlugin forbids to re-upload the same filename, so we'll get a nameclash if there are many thumbs. EditToolbars: AddPlugins is currently broken (with my attached diff), but the new layout is fixed and better than before. Undo is also broken and needs to be generalized for all toolbar button. Just save a snapshot for each insertTags(). listsize is not needed in js, since pages.length is the listsize. I fixed the buttons div for MSIE. HTML-Validation: I changed all id's from edit[content] to edit:content, since "[" is invalid in the id tag. names are ok this way and needed for the automatic php request => array features. create_user: I haven't looked at your WikiAdminUtils create_user work yet, but it's not that simple. Better just call the WikiUserNew method (TODO), and leave the hard work to the backend. The location of create_user in WikiAdminUtils is okay. But maybe we should create a UserAdministration plugin, where one can handle more than just create_user. modify_group ownership, email_validation, blocking and more permissions properties. password routines: Where do we have this? In passencrypt.php, 2 funcs in stdlib.php, and some parts in the auth sections. This should be unified in some general location. Good. locale stuff: I handle this very carefully. It's very easy to break locale, I often did, and it needed a lot of time to fix it again. (Similar to auth sessions) -- Reini Urban http://phpwiki.org/ |
From: <tho...@la...> - 2005-09-25 18:30:18
Attachments:
diff_iniconfig
|
On Sun, Sep 25, 2005 at 05:07:10PM +0200, Reini Urban wrote: > locale stuff: > I handle this very carefully. It's very easy to break locale, > I often did, and it needed a lot of time to fix it again. > (Similar to auth sessions) OK, here is the patch in the good format. I fink it has to be tried. -- Thomas Harding |
From: <tho...@la...> - 2005-09-25 20:33:01
|
On Sun, Sep 25, 2005 at 05:07:10PM +0200, Reini Urban wrote: > EditToolbars: > AddPlugins is currently broken (with my attached diff), but the new > layout is fixed and better than before. Works! Sorry for the huge : I edited files before to copy... -- Thomas Harding |
From: Reini U. <ru...@x-...> - 2005-09-26 06:16:36
|
Thomas Harding schrieb: > On Sun, Sep 25, 2005 at 05:07:10PM +0200, Reini Urban wrote: > >>EditToolbars: >>AddPlugins is currently broken (with my attached diff), but the new >>layout is fixed and better than before. > > Works! > Sorry for the huge : I edited files before to copy... Great! Just two points: <br /> => \n is not that good. Templates actually force <br />. It's just an artefact of $desc->asXML() expansion. method_exists($this,'getArgumentsDesc') is not needed, because plugins should declare getArgumentsDescription() and not getArgumentsDesc() to override the default behaviour. Basic OO inheritance. I'll commit that in the evening. -- Reini Urban http://phpwiki.org/ |