From: Jeff D. <da...@da...> - 2001-02-27 21:03:34
|
I'm in a quandry. There are numerous features I'd like to implement for my Wiki. I think most of us are in agreement about what features would be nice to add. (Version history is at the top of my list.) But nobody seems to like my coding style, so at this point I'm afraid (or too polite) to touch the code in the main branch of the CVS --- I particularly don't want to make a large change (eg. new database API). A few weeks ago, Steve posted a request for discussion of how to fit (among other things) version history into the database API. I posted my idea (the jeffs_hacks API). Other than complaints about my coding style there has been frustrating little discussion on how to implement version history. I'd like version history soon. I'm willing to do the work to get it. (I've already done it once in jeffs_hacks.) So what to do? 1. Just hack away by myself. This means basically fork my own private version (which will look a lot like the old jeffs_hacks-branch.) I'd be perfectly happy doing this, however it seems seems a shame, since the whole reason for my fork would be to implement features that it seems many people are interested in. (I think it is unlikely that much of this would make it back the main branch: witness jeffs_hacks-branch.) 2. Officially fork the code. Maintain (a new) jeffs_hacks-branch, either as an official branch of PhpWiki, or as a separate project. 3. Screw-em-all (:->) and just hack away on the main branch. No, I'm not that type of guy. 4. Wait for Arno (or whoever) to implement version history (on the assumption that this is going to happen reasonably soon.) I don't mean to sound pissed off --- I'm not, I'm just a little frustrated. Any above the above options would be fine with me. Truly. Option #1 is my choice at the moment (after all, that is what everyone else does to get features they want into their own PhpWiki); however, I would be interested in hearing your input on the matter before I commit to it. Jeff |
From: Steve W. <sw...@wc...> - 2001-02-28 00:12:47
|
On Tue, 27 Feb 2001, Jeff Dairiki wrote: > I think most of us are in agreement about what features would be nice to add. > (Version history is at the top of my list.) > > But nobody seems to like my coding style, so at this point I'm afraid (or too > polite) to touch the code in the main branch of the CVS --- I particularly > don't > want to make a large change (eg. new database API). > > A few weeks ago, Steve posted a request for discussion of how to fit > (among other things) version history into the database API. I posted > my idea (the jeffs_hacks API). Other than complaints about my coding > style there has been frustrating little discussion on how to implement > version history. This is not unusual for the project though. It's taken a long time to reach agreement on the features since we all hack on PhpWiki part time. > I don't mean to sound pissed off --- I'm not, I'm just a little frustrated. Completely understandable; and I commend you on your great diplomacy. I was afraid our annual OO vs. procedural debate would have put you off completely. > Option #1 is my choice at the moment (after all, that is what everyone else > does to get features they want into their own PhpWiki); however, I would be > interested in hearing your input on the matter before I commit to it. > I need some time to look over your API again. I won't really have time until tomorrow night or Thursday though. Is that OK? ~swain ...............................ooo0000ooo................................. Hear FM quality freeform radio through the Internet: http://wcsb.org/ home page: www.wcsb.org/~swain |
From: Arno H. <aho...@xm...> - 2001-02-28 09:09:41
|
Jeff, I apologize again for my strong words (esp. about the comments). I hope we can find a compromise. > I think most of us are in agreement about what features would be nice t= o > add. (Version history is at the top of my list.) Right. > A few weeks ago, Steve posted a request for discussion of how to fit > (among other things) version history into the database API. I posted > my idea (the jeffs_hacks API). I'm sorry for my lack of time devoted to phpwiki during the last two week= s. Some other tasks required my full attention. I'll look at your API on the wiki today and give my comments. We should=20 have this thing sorted out in a day or two. Then implementing version=20 history should be no problem. (this is option 5: we agree on the api and=20 you code :o) /Arno |
From: Reini U. <ru...@x-...> - 2001-02-28 16:24:00
|
Jeff Dairiki schrieb: > There are numerous features I'd like to implement for my Wiki. > > I think most of us are in agreement about what features would be nice to add. > (Version history is at the top of my list.) The problem is that VersionHistory would require the drastic db change. but haven't looked at this yet. UserPreferences are a similar hot topic. now I have a cookie with username,email,state,realm and now also notifications, but this can get very large. imho better would be to store only a small numeric id at the client cookie and the rest in a database table. completely unfinished: http://xarch.tu-graz.ac.at/home/rurban/acadwiki-1.3.4pre/viewsrc.php?show=lib/userauth.php http://xarch.tu-graz.ac.at/home/rurban/acadwiki-1.3.4pre/viewsrc.php?show=schemas/schema.mysql > But nobody seems to like my coding style, so at this point I'm afraid (or too > polite) to touch the code in the main branch of the CVS --- I particularly > don't want to make a large change (eg. new database API). I like it. Sometimes you just need classes. -- Reini Urban http://xarch.tu-graz.ac.at/home/rurban/ |