From: Adam S. <ad...@pe...> - 2002-03-21 18:38:58
|
Hey Dennis, My contributions to PhpWiki are mostly answering what questions I can on the mailing list and keeping the cruft off the wiki site (it's amazing how much crap people want to create sometimes :-). As such I've forwarded your message back to the list. Adam. -----Forwarded Message----- From: Dennis Kehrig <Th...@we...> To: ad...@pe... Subject: [PhpWiki] Call Time Pass By Reference Date: 21 Mar 2002 16:37:07 +0100 Hi Adam, since I did not find too many email addresses on the PhpWiki page, I chose you as my victim. PhpWiki seems to make usage of the feature mentioned in the subject, but it is disabled in recent PHP versions by default. You (or whoever feels responsible for this) might consider adding this line to the .htaccess file: php_flag allow_call_time_pass_reference on I guess this will be sufficient for the majority of PhpWiki users (those with Apache and the more or less default PHP settings). Regards, Dennis -- Q: How many software engineers does it take to change a lightbulb? A: It can't be done; it's a hardware problem. |
From: Lawrence A. <ao...@ds...> - 2002-03-21 21:31:26
|
Thanks for the report. By a strange coincidence, this has also been reported as a bug on= SF. A couple of function calls were incorrectly coded. I have fixed= it in cvs, and there should be no need to change the .htaccess= files. If you want to change it in your own version, here are the= changes I made: 1) in lib/editpage.php: lines 131 and 156 (or thereabouts): change= this->setPageLockChanged($isadmin, $lock, &$page); to this->setPageLockChanged($isadmin, $lock, $page); [Note the removal of the &] 2) in lib/diff.php: line 339: change $html->pushContent(HTML::Table(PageInfoRow(_("Newer page:"),= $new, &$request), PageInfoRow(_("Older page:"), $old, &$request))); to $html->pushContent(HTML::Table(PageInfoRow(_("Newer page:"),= $new, &$request), PageInfoRow(_("Older page:"), $old, $request))); [again, only change is removal of &] I hope this works. It would be great if someone could test it and let me know if the= warnings have gone. Lawrence On 21 Mar 2002 10:38:45 -0800, Adam Shand wrote: >Hey Dennis, > >My contributions to PhpWiki are mostly answering what questions= I >can on >the mailing list and keeping the cruft off the wiki site (it's >amazing >how much crap people want to create sometimes :-). > >As such I've forwarded your message back to the list. > >Adam. > >-----Forwarded Message----- > >From: Dennis Kehrig <Th...@we...> >To: ad...@pe... >Subject: [PhpWiki] Call Time Pass By Reference >Date: 21 Mar 2002 16:37:07 +0100 > >Hi Adam, > >since I did not find too many email addresses on the PhpWiki= page, I >chose you as my victim. > >PhpWiki seems to make usage of the feature mentioned in the= subject, >but >it is disabled in recent PHP versions by default. > >You (or whoever feels responsible for this) might consider= adding >this >line to the .htaccess file: > > php_flag allow_call_time_pass_reference on > >I guess this will be sufficient for the majority of PhpWiki= users >(those >with Apache and the more or less default PHP settings). > >Regards, > >Dennis > -- |
From: Laurent M. <l.m...@ch...> - 2002-03-21 22:09:37
|
Hello, I'm running under W2K SP2 , IIS5 and PHP 4.1.2 I have tried version 1.2.2, works like a charm. Then I wanted to try version 1.3.3. The offical version (not the daily snapshot) doesn't work. I can install it, configure it but I keep getting the same problem. On the first page, if I click on any link, it try to find a new url that doesn't exist. Ie: Original page : http://www.myhost/phpwiki/index.php Selecting to edit the first page should return me : http://myhost/phpwiki/index.php?action=edit But I'm getting: http://myhost/phpwiki/index.php/phpwiki/index.php?action=edit I didn't change any web seting or PHP setting... Any idea ? Tried also with the latest snapshot but I get a parse error (missing ')' ) in index.php around line 223 even in the original file before any change. Thanks Laurent. |
From: Carsten K. <car...@ma...> - 2002-03-25 14:48:13
|
Hi Laurent, Try commenting out these two lines near the bottom of index.php by putting two slashes in front: //define('SCRIPT_NAME', '/some/where/index.php'); //define('USE_PATH_INFO', false); Does this fix the url problem? Regarding the missing bracket problem, I double-checked the latest version of index.php and the default file tests ok on my system. Are you sure you are looking at the correct file on your computer? It sounds like you may have accidentally deleted the ); on line 232, or inserted a semicolon instead of a comma, or deleted a comma at the end of one of the lines somewhere from line 193 to 232. Carsten On Thursday, March 21, 2002, at 05:11 pm, Laurent Marechal wrote: > Hello, > > I'm running under W2K SP2 , IIS5 and PHP 4.1.2 > > I have tried version 1.2.2, works like a charm. > > Then I wanted to try version 1.3.3. > The offical version (not the daily snapshot) doesn't work. I can install > it, > configure it but I keep getting the same problem. On the first page, if I > click on any link, it try to find a new url that doesn't exist. > > Ie: > Original page : http://www.myhost/phpwiki/index.php > Selecting to edit the first page should return me : > http://myhost/phpwiki/index.php?action=edit > But I'm getting: > http://myhost/phpwiki/index.php/phpwiki/index.php?action=edit > > I didn't change any web seting or PHP setting... > > Any idea ? > > Tried also with the latest snapshot but I get a parse error (missing ')' > ) > in index.php around line 223 even in the original file before any change. > > Thanks > > Laurent. |
From: Laurent M. <l.m...@ch...> - 2002-03-25 21:20:25
|
Hello, No luck with commenting the two lines. I started over from scratch: - decompressing phpwiki-1.3.3.tar - moving the whole tree under the web folder (wwwroot) under phpwiki. - Editing the index.php. No change apart from the database section = changed to: $DBParams =3D array( // Select the database type: //'dbtype' =3D> 'SQL', 'dbtype' =3D> 'dba', =20 // For SQL based backends, specify the database as a DSN // The most general form of a DSN looks like: // // phptype(dbsyntax)://username:password@protocol+hostspec/database // // For a MySQL database, the following should work: // // mysql://user:password@host/databasename // // FIXME: My version Pear::DB seems to be broken enough that there // is no way to connect to a mysql server over a socket right = now. //'dsn' =3D> 'mysql://guest@:/var/lib/mysql/mysql.sock/test', //'dsn' =3D> 'mysql://guest@localhost/test', //'dsn' =3D> 'pgsql://localhost/test', =20 // Used by all DB types: // prefix for filenames or table names /*=20 * currently you MUST EDIT THE SQL file too (in the schemas/ * directory because we aren't doing on the fly sql generation * during the installation. */ //'prefix' =3D> 'phpwiki_', =20 // Used by 'dba' 'directory' =3D> "/tmp/wiki133", //'dba_handler' =3D> 'gdbm', // Either of 'gdbm' or 'db2' work = great for me. //'dba_handler' =3D> 'db2', 'dba_handler' =3D> 'db3', // doesn't work at all for me.... 'timeout' =3D> 20, //'timeout' =3D> 5 ); - Starting the web server. - Going to http://xxx.xxx.xxx.xxx/phpwiki/index.php - The screen=20 - I click on edit and 'page not found..."=20 The link it try to find is : = http://xxx.xxx.xxx.xxx/phpwiki/index.php/phpwiki/index.php?action=3Dedit Note the addition of /phpwiki/index.php that should not be here. Laurent.\ ----- Original Message -----=20 Subject: Re: [Phpwiki-talk] Strange url behaviour >=20 > Hi Laurent, >=20 > Try commenting out these two lines near the bottom of index.php by = putting=20 > two slashes in front: >=20 > //define('SCRIPT_NAME', '/some/where/index.php'); >=20 > //define('USE_PATH_INFO', false); >=20 > Does this fix the url problem? >=20 >=20 > Regarding the missing bracket problem, I double-checked the latest = version=20 > of index.php and the default file tests ok on my system. Are you sure = you=20 > are looking at the correct file on your computer? It sounds like you = may=20 > have accidentally deleted the ); on line 232, or inserted a semicolon=20 > instead of a comma, or deleted a comma at the end of one of the lines=20 > somewhere from line 193 to 232. >=20 > Carsten |
From: Laurent M. <l.m...@ch...> - 2002-03-25 21:47:38
|
I have checked the html generated and it looks fine.=20 I.e for the edit (as in my previous mail), it return the following html = code: <td> <div id=3D"actionbuttons"> <a href=3D"phpwiki/index.php?action=3Dedit" = class=3D"wikiaction">Edit</a>=20 | <a href=3D"phpwiki/index.php?action=3DPageHistory" = class=3D"wikiaction">PageHistory</a> | <a = href=3D"phpwiki/index.php?action=3Ddiff" class=3D"wikiaction">Diff</a>=20 | <a href=3D"phpwiki/index.php?action=3DInfo" = class=3D"wikiaction">Info</a> </div> </td> The patch is correct. ----- Original Message -----=20 From: Laurent Marechal=20 To: Carsten Klapp=20 Cc: PhpWiki List=20 Sent: Monday, March 25, 2002 10:22 PM Subject: Re: [Phpwiki-talk] Strange url behaviour Hello, No luck with commenting the two lines. I started over from scratch: - decompressing phpwiki-1.3.3.tar - moving the whole tree under the web folder (wwwroot) under phpwiki. - Editing the index.php. No change apart from the database section = changed to: $DBParams =3D array( // Select the database type: //'dbtype' =3D> 'SQL', 'dbtype' =3D> 'dba', =20 // For SQL based backends, specify the database as a DSN // The most general form of a DSN looks like: // // = phptype(dbsyntax)://username:password@protocol+hostspec/database // // For a MySQL database, the following should work: // // mysql://user:password@host/databasename // // FIXME: My version Pear::DB seems to be broken enough that there // is no way to connect to a mysql server over a socket = right now. //'dsn' =3D> 'mysql://guest@:/var/lib/mysql/mysql.sock/test', //'dsn' =3D> 'mysql://guest@localhost/test', //'dsn' =3D> 'pgsql://localhost/test', =20 // Used by all DB types: // prefix for filenames or table names /*=20 * currently you MUST EDIT THE SQL file too (in the schemas/ * directory because we aren't doing on the fly sql generation * during the installation. */ //'prefix' =3D> 'phpwiki_', =20 // Used by 'dba' 'directory' =3D> "/tmp/wiki133", //'dba_handler' =3D> 'gdbm', // Either of 'gdbm' or 'db2' work = great for me. //'dba_handler' =3D> 'db2', 'dba_handler' =3D> 'db3', // doesn't work at all for me.... 'timeout' =3D> 20, //'timeout' =3D> 5 ); - Starting the web server. - Going to http://xxx.xxx.xxx.xxx/phpwiki/index.php - The screen=20 - I click on edit and 'page not found..."=20 The link it try to find is : = http://xxx.xxx.xxx.xxx/phpwiki/index.php/phpwiki/index.php?action=3Dedit Note the addition of /phpwiki/index.php that should not be here. Laurent.\ ----- Original Message -----=20 Subject: Re: [Phpwiki-talk] Strange url behaviour >=20 > Hi Laurent, >=20 > Try commenting out these two lines near the bottom of index.php by = putting=20 > two slashes in front: >=20 > //define('SCRIPT_NAME', '/some/where/index.php'); >=20 > //define('USE_PATH_INFO', false); >=20 > Does this fix the url problem? >=20 >=20 > Regarding the missing bracket problem, I double-checked the latest = version=20 > of index.php and the default file tests ok on my system. Are you = sure you=20 > are looking at the correct file on your computer? It sounds like you = may=20 > have accidentally deleted the ); on line 232, or inserted a = semicolon=20 > instead of a comma, or deleted a comma at the end of one of the = lines=20 > somewhere from line 193 to 232. >=20 > Carsten |
From: Carsten K. <car...@ma...> - 2002-03-26 01:13:09
|
Hi Laurent, I don't have any experience using PhpWiki on Windows, is there anyone = else=20 on the list who can help? I think you've hit on a clue with the html source you provided, the urls=20= should look like this: | <a href=3D"HomePage?action=3DPageHistory" = class=3D"wikiaction">PageHistory</a> | <a href=3D"HomePage?action=3Ddiff" class=3D"wikiaction">Diff</a> Question, are you using the cgi version of PHP? The only thing I can think of is that USE_PATH_INFO is being calculated=20= incorrectly for your setup in the "Autodetect URL settings" inside = config. php. Have you tried using the "pretty" url settings? index.php: define('USE_PATH_INFO', true); define('VIRTUAL_PATH', '/phpwiki'); The above might get it working, but there might still be a bug here... Carsten On Monday, March 25, 2002, at 04:49 pm, Laurent Marechal wrote: > I have checked the html generated and it looks fine. > I.e for the edit (as in my previous mail), it return the following = html=20 > code: > =A0 > =A0 <td> > =A0 <div id=3D"actionbuttons"> > =A0=A0=A0 <a href=3D"phpwiki/index.php?action=3Dedit" = class=3D"wikiaction">Edit</a> > =A0=A0 | <a href=3D"phpwiki/index.php?action=3DPageHistory"=20 > class=3D"wikiaction">PageHistory</a>=A0 | <a=20 > href=3D"phpwiki/index.php?action=3Ddiff" class=3D"wikiaction">Diff</a> > =A0 | <a href=3D"phpwiki/index.php?action=3DInfo" = class=3D"wikiaction">Info</a>=A0=20 > </div> > =A0 </td> > =A0 > The patch is correct. > > ----- Original Message ----- > From: Laurent Marechal > To: Carsten Klapp > Cc: PhpWiki List > Sent: Monday, March 25, 2002 10:22 PM > Subject: Re: [Phpwiki-talk] Strange url behaviour > > Hello, > =A0 > No luck with commenting the two lines. > =A0 > I started over from scratch: > - decompressing phpwiki-1.3.3.tar > - moving the whole tree under the web folder (wwwroot) under phpwiki. > - Editing the index.php. No change apart from the database section=20 > changed to: > =A0 > $DBParams =3D array( > =A0=A0 // Select the database type: > =A0=A0 //'dbtype' =3D> 'SQL', > =A0=A0 'dbtype'=A0=A0 =3D> 'dba', > =A0=A0 > =A0=A0 // For SQL based backends, specify the database as a DSN > =A0=A0 // The most general form of a DSN looks like: > =A0=A0 // > =A0=A0 //=A0=A0 = phptype(dbsyntax)://username:password@protocol+hostspec/database > =A0=A0 // > =A0=A0 // For a MySQL database, the following should work: > =A0=A0 // > =A0=A0 //=A0=A0 mysql://user:password@host/databasename > =A0=A0 // > =A0=A0 // FIXME: My version Pear::DB seems to be broken enough that = there > =A0=A0 //=A0=A0=A0=A0=A0=A0=A0 is no way to connect to a mysql server = over a socket right=20 > now. > =A0=A0 //'dsn' =3D> 'mysql://guest@:/var/lib/mysql/mysql.sock/test', > =A0=A0 //'dsn' =3D> 'mysql://guest@localhost/test', > =A0=A0 //'dsn' =3D> 'pgsql://localhost/test', > =A0=A0 > =A0=A0 // Used by all DB types: > =A0 > =A0=A0 // prefix for filenames or table names > =A0=A0 /* > =A0=A0=A0 * currently you MUST EDIT THE SQL file too (in the schemas/ > =A0=A0=A0 * directory because we aren't doing on the fly sql = generation > =A0=A0=A0 * during the installation. > =A0=A0 */ > =A0=A0 //'prefix' =3D> 'phpwiki_', > =A0=A0 > =A0=A0 // Used by 'dba' > =A0=A0 'directory'=A0=A0=A0=A0 =3D> "/tmp/wiki133", > =A0=A0 //'dba_handler'=A0=A0 =3D> 'gdbm',=A0=A0 // Either of 'gdbm' or = 'db2' work great=20 > for me. > =A0=A0 //'dba_handler' =3D> 'db2', > =A0=A0 'dba_handler' =3D> 'db3',=A0=A0=A0 // doesn't work at all for = me.... > =A0=A0 'timeout'=A0=A0 =3D> 20, > =A0=A0 //'timeout' =3D> 5 > ); > =A0 > - Starting the web server. > - Going to http://xxx.xxx.xxx.xxx/phpwiki/index.php > - The screen > - I click on edit and 'page not found..." > The link it try to find is :=20 > http://xxx.xxx.xxx.xxx/phpwiki/index.php/phpwiki/index.php?action=3Dedit= > =A0 > Note the addition of /phpwiki/index.php=A0that should not be here. > =A0 > Laurent.\ > =A0 > ----- Original Message ----- > Subject: Re: [Phpwiki-talk] Strange url behaviour > > > > > Hi Laurent, > > > > Try commenting out these two lines near the bottom of index.php by=20= > putting > > two slashes in front: > > > > //define('SCRIPT_NAME', '/some/where/index.php'); > > > > //define('USE_PATH_INFO', false); > > > > Does this fix the url problem? > > > > > > Regarding the missing bracket problem, I double-checked the latest=20= > version > > of index.php and the default file tests ok on my system. Are you = sure=20 > you > > are looking at the correct file on your computer? It sounds like you = may > > have accidentally deleted the ); on line 232, or inserted a = semicolon > > instead of a comma, or deleted a comma at the end of one of the = lines > > somewhere from line 193 to 232. > > > > Carsten > |
From: Laurent M. <l.m...@ch...> - 2002-03-26 22:18:56
|
Hello, Thanks you. Changing : define('USE_PATH_INFO', true); define('VIRTUAL_PATH', '/phpwiki'); Make the trick. wiki now start and allow to edit/view. Still some problem to load some page (still not found) but lot better. Looks like the initial load at the first start is not done. But, I thing there's a bug somewhere about this url. As for using PHP in CGI mode, where can I find it ? I'm pretty new in PHP. Laurent.\ ----- Original Message ----- From: "Carsten Klapp" <car...@ma...> To: "Laurent Marechal" <l.m...@ch...> Cc: "PhpWiki List" <php...@li...> Sent: Tuesday, March 26, 2002 2:13 AM Subject: Re: [Phpwiki-talk] Strange url behaviour Hi Laurent, I don't have any experience using PhpWiki on Windows, is there anyone else on the list who can help? I think you've hit on a clue with the html source you provided, the urls should look like this: | <a href="HomePage?action=PageHistory" class="wikiaction">PageHistory</a> | <a href="HomePage?action=diff" class="wikiaction">Diff</a> Question, are you using the cgi version of PHP? The only thing I can think of is that USE_PATH_INFO is being calculated incorrectly for your setup in the "Autodetect URL settings" inside config. php. Have you tried using the "pretty" url settings? index.php: define('USE_PATH_INFO', true); define('VIRTUAL_PATH', '/phpwiki'); The above might get it working, but there might still be a bug here... Carsten On Monday, March 25, 2002, at 04:49 pm, Laurent Marechal wrote: > I have checked the html generated and it looks fine. > I.e for the edit (as in my previous mail), it return the following html > code: > > <td> > <div id="actionbuttons"> > <a href="phpwiki/index.php?action=edit" class="wikiaction">Edit</a> > | <a href="phpwiki/index.php?action=PageHistory" > class="wikiaction">PageHistory</a> | <a > href="phpwiki/index.php?action=diff" class="wikiaction">Diff</a> > | <a href="phpwiki/index.php?action=Info" class="wikiaction">Info</a> > </div> > </td> > > The patch is correct. > > ----- Original Message ----- > From: Laurent Marechal > To: Carsten Klapp > Cc: PhpWiki List > Sent: Monday, March 25, 2002 10:22 PM > Subject: Re: [Phpwiki-talk] Strange url behaviour > > Hello, > > No luck with commenting the two lines. > > I started over from scratch: > - decompressing phpwiki-1.3.3.tar > - moving the whole tree under the web folder (wwwroot) under phpwiki. > - Editing the index.php. No change apart from the database section > changed to: > > $DBParams = array( > // Select the database type: > //'dbtype' => 'SQL', > 'dbtype' => 'dba', > > // For SQL based backends, specify the database as a DSN > // The most general form of a DSN looks like: > // > // phptype(dbsyntax)://username:password@protocol+hostspec/database > // > // For a MySQL database, the following should work: > // > // mysql://user:password@host/databasename > // > // FIXME: My version Pear::DB seems to be broken enough that there > // is no way to connect to a mysql server over a socket right > now. > //'dsn' => 'mysql://guest@:/var/lib/mysql/mysql.sock/test', > //'dsn' => 'mysql://guest@localhost/test', > //'dsn' => 'pgsql://localhost/test', > > // Used by all DB types: > > // prefix for filenames or table names > /* > * currently you MUST EDIT THE SQL file too (in the schemas/ > * directory because we aren't doing on the fly sql generation > * during the installation. > */ > //'prefix' => 'phpwiki_', > > // Used by 'dba' > 'directory' => "/tmp/wiki133", > //'dba_handler' => 'gdbm', // Either of 'gdbm' or 'db2' work great > for me. > //'dba_handler' => 'db2', > 'dba_handler' => 'db3', // doesn't work at all for me.... > 'timeout' => 20, > //'timeout' => 5 > ); > > - Starting the web server. > - Going to http://xxx.xxx.xxx.xxx/phpwiki/index.php > - The screen > - I click on edit and 'page not found..." > The link it try to find is : > http://xxx.xxx.xxx.xxx/phpwiki/index.php/phpwiki/index.php?action=edit > > Note the addition of /phpwiki/index.php that should not be here. > > Laurent.\ > > ----- Original Message ----- > Subject: Re: [Phpwiki-talk] Strange url behaviour > > > > > Hi Laurent, > > > > Try commenting out these two lines near the bottom of index.php by > putting > > two slashes in front: > > > > //define('SCRIPT_NAME', '/some/where/index.php'); > > > > //define('USE_PATH_INFO', false); > > > > Does this fix the url problem? > > > > > > Regarding the missing bracket problem, I double-checked the latest > version > > of index.php and the default file tests ok on my system. Are you sure > you > > are looking at the correct file on your computer? It sounds like you may > > have accidentally deleted the ); on line 232, or inserted a semicolon > > instead of a comma, or deleted a comma at the end of one of the lines > > somewhere from line 193 to 232. > > > > Carsten > |