From: Reini U. <ru...@us...> - 2007-03-19 01:59:54
|
Update of /cvsroot/phpwiki/phpwiki/lib In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv25216/lib Modified Files: TextSearchQuery.php WikiDB.php SemanticWeb.php Log Message: Improve comments Index: TextSearchQuery.php =================================================================== RCS file: /cvsroot/phpwiki/phpwiki/lib/TextSearchQuery.php,v retrieving revision 1.27 retrieving revision 1.28 diff -u -2 -b -p -d -r1.27 -r1.28 --- TextSearchQuery.php 21 Jan 2007 23:27:32 -0000 1.27 +++ TextSearchQuery.php 18 Mar 2007 17:35:26 -0000 1.28 @@ -154,5 +154,6 @@ class TextSearchQuery { /** - * Make an SQL clause which matches the query. (deprecated, use makeSqlClause instead) + * Make an SQL clause which matches the query. + * Deprecated, use makeSqlClauseObj instead. * * @param $make_sql_clause_cb WikiCallback @@ -162,7 +163,7 @@ class TextSearchQuery { * be in all lower case. * - * TODO: support db-specific extensions, like MATCH AGAINST or REGEX + * Support db-specific extensions, like MATCH AGAINST or REGEX * mysql => 4.0.1 can also do Google: MATCH AGAINST IN BOOLEAN MODE - * How? WikiDB backend method? + * by using makeSqlClauseObj * * Old example usage: @@ -379,5 +380,6 @@ class NumericSearchQuery /** * Check the symbolic definition query against unwanted functions and characters. - * "population < 20000 and area > 1000000" vs "area > 1000000 and mail($me,file("/etc/passwd"),...)" + * "population < 20000 and area > 1000000" vs + * "area > 1000000 and mail($me,file("/etc/passwd"),...)" * http://localhost/wikicvs/SemanticSearch?attribute=*&attr_op=<0 and find(1)>&s=-0.01&start_debug=1 */ @@ -431,5 +433,6 @@ class NumericSearchQuery */ } else { - // Detect illegal characters besides nums, words and ops. So attribute names can not be utf-8 + // Detect illegal characters besides nums, words and ops. + // So attribute names can not be utf-8 $c = "/([^\d\w.,\s".preg_quote(join("",$this->_allowed_operators),"/")."])/"; if (preg_match($c, $query, $m)) { @@ -545,5 +548,5 @@ class NumericSearchQuery //if (DEBUG & _DEBUG_VERBOSE) // trigger_error("\$result = (boolean)($search);", E_USER_NOTICE); - // we might have a numerical problem: + // We might have a numerical problem: // php-4.2.2 eval'ed as module: "9.636e+08 > 1000" false; // php-5.1.2 cgi true, 4.2.2 cgi true @@ -1124,4 +1127,7 @@ class TextSearchQuery_Lexer { // $Log$ +// Revision 1.28 2007/03/18 17:35:26 rurban +// Improve comments +// // Revision 1.27 2007/01/21 23:27:32 rurban // Fix ->_backend->qstr() Index: WikiDB.php =================================================================== RCS file: /cvsroot/phpwiki/phpwiki/lib/WikiDB.php,v retrieving revision 1.149 retrieving revision 1.150 diff -u -2 -b -p -d -r1.149 -r1.150 --- WikiDB.php 17 Feb 2007 14:16:37 -0000 1.149 +++ WikiDB.php 18 Mar 2007 17:35:27 -0000 1.150 @@ -315,4 +315,5 @@ class WikiDB { * Pages are returned in alphabetical order whenever it is * practical to do so. + * TODO: Sort by ranking. Only postgresql with tsearch2 can do ranking so far. * * @access public @@ -342,4 +343,5 @@ class WikiDB { * Pages are returned in alphabetical order whenever it is * practical to do so. + * TODO: Sort by ranking. Only postgresql with tsearch2 can do ranking so far. * * @access public @@ -995,4 +997,5 @@ class WikiDB_Page include_once("lib/MailNotify.php"); $MailNotify = new MailNotify($newrevision->getName()); + // FIXME: this breaks after-edit-redirect $MailNotify->onChangePage ($this->_wikidb, $wikitext, $version, $meta); } @@ -2194,4 +2197,7 @@ function _sql_debuglog_shutdown_function // $Log$ +// Revision 1.150 2007/03/18 17:35:27 rurban +// Improve comments +// // Revision 1.149 2007/02/17 14:16:37 rurban // isWikiPage no error on empty pagenames. MailNotify->onChangePage fix by ?? Index: SemanticWeb.php =================================================================== RCS file: /cvsroot/phpwiki/phpwiki/lib/SemanticWeb.php,v retrieving revision 1.5 retrieving revision 1.6 diff -u -2 -b -p -d -r1.5 -r1.6 --- SemanticWeb.php 20 Jan 2007 11:41:10 -0000 1.5 +++ SemanticWeb.php 18 Mar 2007 17:35:27 -0000 1.6 @@ -175,5 +175,5 @@ class ModelWriter extends OwlWriter { * Do we need a real parser or can we just regexp over some allowed unit * suffixes to detect the numbers? - * see man units(1) and /usr/share/units.dat + * See man units(1) and /usr/share/units.dat * base units: $ units "1 million miles" * Definition: 1.609344e+09 m |