From: David M. <run...@us...> - 2011-09-12 17:07:21
|
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "pdl". The branch, master has been updated via 519832c448588937a6b737e0928185cc67049611 (commit) via 638fbf5f750462d51e37c7da22464b78b123769b (commit) from baee6b8830da70898ebb718630217b1cf6360854 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 519832c448588937a6b737e0928185cc67049611 Author: David Mertens <dcm...@gm...> Date: Mon Sep 12 12:01:22 2011 -0500 Remove unnecessary HASP2Child key. The HASP2Child key was essentially a value for P2Child that had the same boolean evaluation but was guaranteed to be defined as a numeric value of either 0 or 1. However, the value of HASP2Child was never used in any arithmetic, only in boolean context. Since undef evaluates to false, all references to HASP2Child can be replaced by _P2Child with impunity. I believe that is much clearer. It says, "If the user indicated a value for P2Child, pass that, otherwise pass the undefined value." It clearly points back to a user-level key, which I believe is preferable to an internally defined key derived directly from the user-level one. commit 638fbf5f750462d51e37c7da22464b78b123769b Author: David Mertens <dcm...@gm...> Date: Mon Sep 12 12:00:29 2011 -0500 Added doc strings to some rules. I'm working to understand the workings of each of the rules. Adding doc-strings is a good practice, and it helps me build an automated documentation system, too. ----------------------------------------------------------------------- Summary of changes: Basic/Gen/PP.pm | 58 ++++++++++++++++++++++++++++++++++++------------------- 1 files changed, 38 insertions(+), 20 deletions(-) hooks/post-receive -- pdl |