This bug was introduced yet in 1.2.1 but reported only now. Wonderful, wonderful... Thank you very much for the report. I hope this issue is fixed by latest commit in the LibFM GIT repository. Try it when possible, please, and report back if something is still not fixed.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Ah, may be I was misleaded by the fact the rubberbanding was invisible since 1.2.1. You probably meant the icon is not highlighted with GTK3 as it was with GTK2, right? In GTK3 they've changed icons support and all theme engines seems to ignore the GTK_STATE_FLAG_SELECTED for icons (that was not the case with GTK2 and themes took GTK_STATE_SELECTED into consideration) and they change icon background for selected items instead which is pretty much another look and feel, right? It's why selected items cannot be recolored with GTK3 anymore. Therefore to have it changed color it will require a decision what to do with it and some efforts in LibFM to implement this dropped feature of GTK2 (or replacement for it). I ever told you I hate GTK3?
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Well, with GTK2 it is not background what is changed but icon itself, all colors are shifted to reflect state change. I can provide you an example screenshot to illustrate what I mean. If you fill the whole icon rectangle with changed background then that will be completely different look and feel as selected icons will be surrounded by the rectangles (the same way as the file name is). I mean GTK2 and GTK3 will be much different, and the difference will be bigger than it is now, and I don't like that idea, to be honest.
P.S. I already mentioned all this in previous comment, BTW.
Last edit: Lonely Stranger 2015-07-05
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Well, while GTK-2 pcmanfm
A) changes the icon (icon gets "darkened"),
B) GTK-2 pcmanfm also changes the background of the "text" below the icon
showing the basename of the file specified by the icon.
With GTK-3 neither of them happens, i.e.
A') in fact icon does not change,
B') however also the text under the icon does not change its background,
so we don't know completely what was selected.
So at least we want the background of the "text" (not icon) under the icon
changed when selecting icon.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
The attached patch seems to fix the issue B) (i.e. the text area
seems to change its background with this patch). Still
the issue A) is not fixed with this patch, however I think
this is a possible "workaround" for a moment.
Thank you very much for the fix, apparently it worked with older versions of GTK3, text has background changed still, it's why I didn't see the problem with text, only with icon. Applied your patch to the GIT sources.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
This bug was introduced yet in 1.2.1 but reported only now. Wonderful, wonderful... Thank you very much for the report. I hope this issue is fixed by latest commit in the LibFM GIT repository. Try it when possible, please, and report back if something is still not fixed.
Ah, may be I was misleaded by the fact the rubberbanding was invisible since 1.2.1. You probably meant the icon is not highlighted with GTK3 as it was with GTK2, right? In GTK3 they've changed icons support and all theme engines seems to ignore the GTK_STATE_FLAG_SELECTED for icons (that was not the case with GTK2 and themes took GTK_STATE_SELECTED into consideration) and they change icon background for selected items instead which is pretty much another look and feel, right? It's why selected items cannot be recolored with GTK3 anymore. Therefore to have it changed color it will require a decision what to do with it and some efforts in LibFM to implement this dropped feature of GTK2 (or replacement for it). I ever told you I hate GTK3?
Well,
https://developer.gnome.org/gtk3/stable/GtkStyleContext.html#gtk-style-context-get-background-color
http://www.lanedo.com/users/cgarnacho/gtk3-doc/gtk-migrating-GtkStyleContext.html
seems to be saying that we have to write some css style file
to define background when selected, then call gtk_render_background().
Need to read more documentation and examples...
Well, with GTK2 it is not background what is changed but icon itself, all colors are shifted to reflect state change. I can provide you an example screenshot to illustrate what I mean. If you fill the whole icon rectangle with changed background then that will be completely different look and feel as selected icons will be surrounded by the rectangles (the same way as the file name is). I mean GTK2 and GTK3 will be much different, and the difference will be bigger than it is now, and I don't like that idea, to be honest.
P.S. I already mentioned all this in previous comment, BTW.
Last edit: Lonely Stranger 2015-07-05
Well, while GTK-2 pcmanfm
A) changes the icon (icon gets "darkened"),
B) GTK-2 pcmanfm also changes the background of the "text" below the icon
showing the basename of the file specified by the icon.
With GTK-3 neither of them happens, i.e.
A') in fact icon does not change,
B') however also the text under the icon does not change its background,
so we don't know completely what was selected.
So at least we want the background of the "text" (not icon) under the icon
changed when selecting icon.
The attached patch seems to fix the issue B) (i.e. the text area
seems to change its background with this patch). Still
the issue A) is not fixed with this patch, however I think
this is a possible "workaround" for a moment.
Thank you very much for the fix, apparently it worked with older versions of GTK3, text has background changed still, it's why I didn't see the problem with text, only with icon. Applied your patch to the GIT sources.