Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#757 Space in samba server name not escaped correctly

1.2
closed-fixed
libfm (264)
6
2013-08-03
2013-07-26
alister.hood
No

I clicked "Go>Network Drives".
I clicked on the server called "GREEN ROOM".
I waited a while, and then got an error message: "Failed to retrieve share list from server: Connection refused"
After stuffing around for a long time stopping and restarting my samba daemons and stuff like that, I noticed that PCManFM had the wrong thing in the address bar - it was smb://green%2520room/ (or possibly smb://green%25%20room/).
I changed the address to smb://green%20room/ and then all my shares were listed :)
I clicked back, and then clicked on "GREEN ROOM" again, and this time it got the address right...

So - is this a bug in pcmanfm, or is the problem with gvfs or something?

Discussion

  • alister.hood
    alister.hood
    2013-07-26

    Note, this is with the GTK version of pcmanfm from git ( a day or so old).

     
  • alister.hood
    alister.hood
    2013-07-26

    Oh, and then I click on a share and get the same problem again - it tries to connect to smb://green%2520room/Puppy instead of smb://green%20room/Puppy

     
  • alister.hood
    alister.hood
    2013-07-26

    Oh, and then if I correct the path it changes it to "smb://green%20room/._Puppy", so I can't access any files anyway.
    FWIW I've installed nautilus to test and I can access it fine there.

     
  • This is a very interesting issue. Yes, it is a fact that host names are treated a bit differently than files, both in libfm and in gvfs (and files are treated correctly with current code). Unfortunately I cannot test it since I have no host in reach with spaces in name to test. I would like you to test the same behavior with libfm-1.1.1 and tell me whether it is the same wrong or it is correct with that version. Thank you in advance.

     
    • assigned_to: nobody --> lstranger
    • priority: 5 --> 6
    • milestone: --> 1.2
    • labels: --> libfm
     
  • alister.hood
    alister.hood
    2013-07-29

    With libfm and pcmanfm 1.1.1 it doesn't show the wrong path, but first I get an error message: "Failed to mount Windows share: Invalid argument", and then "The specified location is not mounted".

     
  • That is very odd. Seems 1.1.1 also doesn't work correctly with spaces in there. Thank you very much. I'll try to explore it further then.

     
  • Check the libfm GIT, please. I hope the latest commit should fix the issue. Close the report as fixed if the issue is fixed. Thank you very much.

     
  • alister.hood
    alister.hood
    2013-08-03

    • status: open --> closed-fixed
     
  • alister.hood
    alister.hood
    2013-08-03

    Yes, fixed :)