#52 par2cmdline (0.4) dies when passed a directory as a 'file'

open
nobody
None
5
2006-04-07
2006-04-07
Michael J Evans
No

Previously closed threads don't fix "The source file
does not exist:" errors.

The problem is that when the shell expands the
wildcards for you, it doesn't filter for files, but
par2cmdline doesn't filter for files for anything
it's given as an argument. (Except for a Literal */?,
which I couldn't figure out how to escape through an
argument to a shellscript... in such a way that it
Wasn't escaped inside par2cmdline but was during it's
invocation.)

The solution to the problem though, is to not trust
the invoker, and actually check anything we're not
planning on using as our par2 file to see if we
should even bother looking at it.

This patch does exactly that.

Discussion

  • Logged In: YES
    user_id=329158

    I realized when I woke up this morning that Win32 would
    probably not compile with the patch, so here's this version
    that will probably work. Untested.