#121 can not post to task forum

[Greg Rundlett]

Basically, you can not post a message to the forum for
a particular task. It will show up in the database,
but the 'att_type' field is empty. I'm guessing that
is part of the problem. The forum for the task
continues to appear empty after you submit the new post.

Reproduce:
Create a new task.
From the task detail view, click the link for 'Task
Forum' in the leftnav.
Create a new post (message) for that forum.
Click submit.
Try to find it. It __will__ be in the database table
'forums', with an empty value for att_type

Fix:
Upon further examination, there appears to be a
conflict in usage between 'task' and 'tasks'. After
changing the forums table, I could see the proper count
of messages in the forum, however the messages
themselves do not display. I'm guessing the display
page is looking for att_type=='task'

ALTER TABLE `forums` CHANGE `att_type` `att_type` ENUM(
'system', 'people', 'companies', 'nl_list', 'nl_issue',
'nl_entries', 'know', 'ip', 'documents', 'email',
'e_attach', 'help', 'mime_icons', 'news', 'projects',
'requests', 'tasks', 'task_category' ) DEFAULT 'system'
NOT NULL

Basically, all the code that references att_type needs
to be consistent, with the prefered word being 'tasks'
since most other values are plural in the ENUM

[Greg Rundlett]

Logged In: YES
user_id=143603

Well, after updating the 'forums' table definition with the
ALTER TABLE statement above, I __can__ see the forum
messages if I am logged in as Admin. So now the issue is
permission related.

I am looking at opt/include/urights.php now

[Martin Vernooij]

Logged In: YES
user_id=608879

The enum type was setup wrong during initialization. The
opt_init.sql has been fixed. For existing installations, use
the suggested SQL script and insert "tasks" in the forums
tables where it's now empty.

ALTER TABLE `forums` CHANGE `att_type` `att_type` ENUM(
'system', 'people', 'companies', 'nl_list', 'nl_issue',
'nl_entries', 'know', 'ip', 'documents', 'email',
'e_attach', 'help', 'mime_icons', 'news', 'projects',
'requests', 'tasks', 'task_category' ) DEFAULT 'system'
NOT NULL ;

UPDATE `forums` SET `att_type` = 'tasks' WHERE `att_type` = "";

Beware that the last statement changes all empty entries to
be task related forum items. I believe this is the only
entry that's wrong, but use this last update statement with
precaution.

I'm not able to reproduce the permission error of admin
being the only one to be able to post as described below, as
I can add comments as a "normal" user to existing posts done
by admin, as well as add new posts. I'll close this bug for
now untill someone can give me more specifics and a
reproduction method.

Martin.