#6 Update to libpng 1.6.8

Unstable (example)
closed-fixed
nobody
None
5
2014-08-04
2013-12-28
Oliver Schneider
No

Attached is the bundle with the update to libpng 1.6.8 from upstream. The patch will also be attached as a .bz2 file. So make sure to extract that first (it was 5 MiB before compression).

Easier is to use the "hg pull" method described in the previous ticket (#5).

// Oliver

1 Attachments

Discussion

  • removed

     
    Last edit: Oliver Schneider 2013-12-29
  • removed

     
    Last edit: Oliver Schneider 2013-12-29
  • Apologies, this requires a change. It seems when I was cleaning my diffs I cleaned one file too much (pnglibconf.h). Attaching new bundle and patch.

     
  • Also: this introduces a warning that png_data_freer() is deprecated.

     
    Last edit: Oliver Schneider 2013-12-29
  • removed

     
    Last edit: Oliver Schneider 2013-12-29
  • Cosmin Truta
    Cosmin Truta
    2013-12-29

    Thank you very much for the patch. Could you please redo the change as follows:

    • Just say "libpng 1.6.8 from upstream", without other comments, in the commit message. The other two notes (about README and MinGW) are superfluous.
    • Include <string.h> at the top of opngreduc.c (after #include "opngreduc.h"), not at the bottom of opngreduc.h, because it's part of the implementation, not interface. Also, please avoid #include <cstring> for C++, since that idiom isn't used anywhere else in zlib or libpng.
     
    Last edit: Cosmin Truta 2013-12-29
  • Hi Cosmin, I added the #include line there, because it used to be in png.h, so since you were relying on it to be declared in the headers, this was the natural choice. WIll upload another bundle soon.

     
  • Here's the new bundle.

    $ sha1sum.exe libpng-1.6.8.bundle
    7b48509429b4c31e46637f22fa39415d43ff4e76 *libpng-1.6.8.bundle
    
     
    Attachments
  • Cosmin Truta
    Cosmin Truta
    2013-12-29

    One more thing I noticed: in the latest patch you have an inadvertent change in zlib/contrib/iostream2/zstream.h, make sure you remove that.

     
  • Cosmin Truta
    Cosmin Truta
    2013-12-29

    Here's the new bundle.

    Ok, Oliver, I found one commit (the upgrade to libpng-1.6.8) and I pushed it. Thanks.

     
  • Ramona Truta
    Ramona Truta
    2014-08-04

    • status: open --> closed-fixed