From: Mark P. <mpe...@ca...> - 2013-05-21 20:25:08
|
I'd like to revive this old patch from 2008: diff -u a/utils/opcontrol b/utils/opcontrol --- a/utils/opcontrol 2008-11-11 14:31:25.000000000 +0100 +++ b/utils/opcontrol 2008-11-11 12:30:42.000000000 +0100 @@ -187,7 +187,7 @@ fi fi mkdir /dev/oprofile >/dev/null 2>&1 - grep oprofilefs /etc/mtab >/dev/null + grep oprofilefs /proc/mounts >/dev/null if test "$?" -ne 0; then mount -t oprofilefs nodev /dev/oprofile >/dev/null fi @@ -1607,7 +1607,7 @@ do_deinit() { # unmount /dev/oprofile if it is mounted - OPROF_FS=`grep /dev/oprofile /etc/mtab` + OPROF_FS=`grep /dev/oprofile /proc/mounts` if test -n "$OPROF_FS"; then umount /dev/oprofile fi @@ -1705,7 +1705,7 @@ check_version() { OPROFILE_AVAILABLE=no - grep oprofilefs /etc/mtab >/dev/null + grep oprofilefs /proc/mounts >/dev/null if test "$?" -eq 0; then # need to have oprofilefs mounted for this to work on 2.6 KERNEL_SUPPORT=yes Regards, Patrik Hägglund Let me know if there is anything I can do to help with this. Turns out this fix is important for our busybox system as well. Thanks Mark Pearson |
From: Maynard J. <may...@us...> - 2013-05-22 13:35:10
|
On 05/21/2013 02:54 PM, Mark Pearson wrote: > I'd like to revive this old patch from 2008: Hi, Mark, Yeah, this patch seemed on the verge of being accepted back in November 2008. I reviewed the patch and made some comments to the submitter (Patrik), but he never replied, and it just got forgotten in the backlog. Since we have the original patch from Patrik with his Signed-off-by line -- and the patch has been fully reviewed/vetted already -- I went ahead and committed it to our upstream git repo. Enjoy! -Maynard > > diff -u a/utils/opcontrol b/utils/opcontrol > --- a/utils/opcontrol 2008-11-11 14:31:25.000000000 +0100 > +++ b/utils/opcontrol 2008-11-11 12:30:42.000000000 +0100 > @@ -187,7 +187,7 @@ > fi > fi > mkdir /dev/oprofile >/dev/null 2>&1 > - grep oprofilefs /etc/mtab >/dev/null > + grep oprofilefs /proc/mounts >/dev/null > if test "$?" -ne 0; then > mount -t oprofilefs nodev /dev/oprofile >/dev/null > fi > @@ -1607,7 +1607,7 @@ > do_deinit() > { > # unmount /dev/oprofile if it is mounted > - OPROF_FS=`grep /dev/oprofile /etc/mtab` > + OPROF_FS=`grep /dev/oprofile /proc/mounts` > if test -n "$OPROF_FS"; then > umount /dev/oprofile > fi > @@ -1705,7 +1705,7 @@ > check_version() > { > OPROFILE_AVAILABLE=no > - grep oprofilefs /etc/mtab >/dev/null > + grep oprofilefs /proc/mounts >/dev/null > if test "$?" -eq 0; then > # need to have oprofilefs mounted for this to work on 2.6 > KERNEL_SUPPORT=yes > > Regards, > Patrik Hägglund > > Let me know if there is anything I can do to help with this. Turns out this fix is important for our busybox system as well. > > Thanks > Mark Pearson > > > ------------------------------------------------------------------------------ > Try New Relic Now & We'll Send You this Cool Shirt > New Relic is the only SaaS-based application performance monitoring service > that delivers powerful full stack analytics. Optimize and monitor your > browser, app, & servers with just a few lines of code. Try New Relic > and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may > > > > _______________________________________________ > oprofile-list mailing list > opr...@li... > https://lists.sourceforge.net/lists/listinfo/oprofile-list > |
From: Mark P. <mpe...@ca...> - 2013-05-22 15:17:44
|
Awesome - many thanks :) Mark On 13-05-22 09:34 AM, Maynard Johnson wrote: > On 05/21/2013 02:54 PM, Mark Pearson wrote: >> I'd like to revive this old patch from 2008: > Hi, Mark, > Yeah, this patch seemed on the verge of being accepted back in November 2008. I reviewed the patch and made some comments to the submitter (Patrik), but he never replied, and it just got forgotten in the backlog. Since we have the original patch from Patrik with his Signed-off-by line -- and the patch has been fully reviewed/vetted already -- I went ahead and committed it to our upstream git repo. Enjoy! > > -Maynard >> diff -u a/utils/opcontrol b/utils/opcontrol >> --- a/utils/opcontrol 2008-11-11 14:31:25.000000000 +0100 >> +++ b/utils/opcontrol 2008-11-11 12:30:42.000000000 +0100 >> @@ -187,7 +187,7 @@ >> fi >> fi >> mkdir /dev/oprofile >/dev/null 2>&1 >> - grep oprofilefs /etc/mtab >/dev/null >> + grep oprofilefs /proc/mounts >/dev/null >> if test "$?" -ne 0; then >> mount -t oprofilefs nodev /dev/oprofile >/dev/null >> fi >> @@ -1607,7 +1607,7 @@ >> do_deinit() >> { >> # unmount /dev/oprofile if it is mounted >> - OPROF_FS=`grep /dev/oprofile /etc/mtab` >> + OPROF_FS=`grep /dev/oprofile /proc/mounts` >> if test -n "$OPROF_FS"; then >> umount /dev/oprofile >> fi >> @@ -1705,7 +1705,7 @@ >> check_version() >> { >> OPROFILE_AVAILABLE=no >> - grep oprofilefs /etc/mtab >/dev/null >> + grep oprofilefs /proc/mounts >/dev/null >> if test "$?" -eq 0; then >> # need to have oprofilefs mounted for this to work on 2.6 >> KERNEL_SUPPORT=yes >> >> Regards, >> Patrik Hägglund >> >> Let me know if there is anything I can do to help with this. Turns out this fix is important for our busybox system as well. >> >> Thanks >> Mark Pearson >> >> >> ------------------------------------------------------------------------------ >> Try New Relic Now & We'll Send You this Cool Shirt >> New Relic is the only SaaS-based application performance monitoring service >> that delivers powerful full stack analytics. Optimize and monitor your >> browser, app, & servers with just a few lines of code. Try New Relic >> and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may >> >> >> >> _______________________________________________ >> oprofile-list mailing list >> opr...@li... >> https://lists.sourceforge.net/lists/listinfo/oprofile-list >> |
From: Patrik H. H <pat...@er...> - 2013-05-22 16:52:48
|
> I reviewed the patch and made some comments to the submitter (Patrik), but he never replied Sorry, I must have missed that, and I havn't used OProfile since then. Good to see the patch used. :-) Regards, Patrik Hägglund -----Original Message----- From: Maynard Johnson [mailto:may...@us...] Sent: den 22 maj 2013 15:35 To: Mark Pearson Cc: opr...@li...; Patrik Hägglund H Subject: Re: Revive this old patch On 05/21/2013 02:54 PM, Mark Pearson wrote: > I'd like to revive this old patch from 2008: Hi, Mark, Yeah, this patch seemed on the verge of being accepted back in November 2008. I reviewed the patch and made some comments to the submitter (Patrik), but he never replied, and it just got forgotten in the backlog. Since we have the original patch from Patrik with his Signed-off-by line -- and the patch has been fully reviewed/vetted already -- I went ahead and committed it to our upstream git repo. Enjoy! -Maynard > > diff -u a/utils/opcontrol b/utils/opcontrol > --- a/utils/opcontrol 2008-11-11 14:31:25.000000000 +0100 > +++ b/utils/opcontrol 2008-11-11 12:30:42.000000000 +0100 > @@ -187,7 +187,7 @@ > fi > fi > mkdir /dev/oprofile >/dev/null 2>&1 > - grep oprofilefs /etc/mtab >/dev/null > + grep oprofilefs /proc/mounts >/dev/null > if test "$?" -ne 0; then > mount -t oprofilefs nodev /dev/oprofile >/dev/null > fi > @@ -1607,7 +1607,7 @@ > do_deinit() > { > # unmount /dev/oprofile if it is mounted > - OPROF_FS=`grep /dev/oprofile /etc/mtab` > + OPROF_FS=`grep /dev/oprofile /proc/mounts` > if test -n "$OPROF_FS"; then > umount /dev/oprofile > fi > @@ -1705,7 +1705,7 @@ > check_version() > { > OPROFILE_AVAILABLE=no > - grep oprofilefs /etc/mtab >/dev/null > + grep oprofilefs /proc/mounts >/dev/null > if test "$?" -eq 0; then > # need to have oprofilefs mounted for this to work on 2.6 > KERNEL_SUPPORT=yes > > Regards, > Patrik Hägglund > > Let me know if there is anything I can do to help with this. Turns out this fix is important for our busybox system as well. > > Thanks > Mark Pearson > > > ------------------------------------------------------------------------------ > Try New Relic Now & We'll Send You this Cool Shirt > New Relic is the only SaaS-based application performance monitoring service > that delivers powerful full stack analytics. Optimize and monitor your > browser, app, & servers with just a few lines of code. Try New Relic > and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may > > > > _______________________________________________ > oprofile-list mailing list > opr...@li... > https://lists.sourceforge.net/lists/listinfo/oprofile-list > |