From: Maynard J. <may...@us...> - 2009-10-22 23:17:15
Attachments:
op-callgraph.patch
|
Unfortunately, with the assistance of my colleage, Qi Liang (VPA deveoper), I found another regression in 0.9.5. My June 18 change to make sure that all callgraph symbols are reported, even when there are zero samples, resulted in breaking the reporting of count values. While looking at this, I used a tool that validates XML documents with their corresponding schema. I found a few issues that needed to be fixed with the schema, too (mostly unrelated to the regression bug). I decided to put those changes into this patch, too, and bump the schema version. *Richard*, can you please review and test out this patch. Thanks. -Maynard |
From: Richard P. <rp...@rp...> - 2009-10-28 14:55:40
|
On Thu, 2009-10-22 at 18:17 -0500, Maynard Johnson wrote: > Unfortunately, with the assistance of my colleage, Qi Liang (VPA > deveoper), I found another regression in 0.9.5. My June 18 change to > make sure that all callgraph symbols are reported, even when there are > zero samples, resulted in breaking the reporting of count values. > While looking at this, I used a tool that validates XML documents with > their corresponding schema. I found a few issues that needed to be > fixed with the schema, too (mostly unrelated to the regression bug). > I decided to put those changes into this patch, too, and bump the > schema version. > > *Richard*, can you please review and test out this patch. Reading through the patch it looks fine to me in principle. I'm travelling at the moment and won't be able to test until next week though. Cheers, Richard |
From: Maynard J. <may...@us...> - 2009-10-28 17:37:05
|
Richard Purdie wrote: > On Thu, 2009-10-22 at 18:17 -0500, Maynard Johnson wrote: >> Unfortunately, with the assistance of my colleage, Qi Liang (VPA >> deveoper), I found another regression in 0.9.5. My June 18 change to >> make sure that all callgraph symbols are reported, even when there are >> zero samples, resulted in breaking the reporting of count values. >> While looking at this, I used a tool that validates XML documents with >> their corresponding schema. I found a few issues that needed to be >> fixed with the schema, too (mostly unrelated to the regression bug). >> I decided to put those changes into this patch, too, and bump the >> schema version. >> >> *Richard*, can you please review and test out this patch. > > Reading through the patch it looks fine to me in principle. I'm > travelling at the moment and won't be able to test until next week > though. Thanks, Richard. Patch is committed. Please test it out as soon as you can and let me know your results. The patch works well with the VPA tool mentioned above, but want to make sure your OProfileUI works OK, too. -Maynard > > Cheers, > > Richard > > |