From: graydon h. <gr...@re...> - 2003-06-23 22:24:55
|
opreport crashes mid-sentence on "multiple unit mask" summaries. fixed by this hunk. ok to commit? -graydon Index: op_header.cpp =================================================================== RCS file: /cvsroot/oprofile/oprofile/libpp/op_header.cpp,v retrieving revision 1.4 diff -u -r1.4 op_header.cpp --- op_header.cpp 11 Jun 2003 18:36:37 -0000 1.4 +++ op_header.cpp 23 Jun 2003 22:23:01 -0000 @@ -150,7 +150,7 @@ char old_fill = out.fill(); out << " with a unit mask of 0x" << hex << setw(2) << setfill('0') << unsigned(um) << " (" - << um_desc << ")"; + << (um_desc ? um_desc : "multiple flags") << ")"; out << setfill(old_fill) << setw(old_width) << dec; } out << " count " << dec << count << endl; |
From: Philippe E. <ph...@wa...> - 2003-06-23 23:23:34
|
graydon hoare wrote: > opreport crashes mid-sentence on "multiple unit mask" summaries. fixed > by this hunk. ok to commit? > > -graydon > > > Index: op_header.cpp > =================================================================== > RCS file: /cvsroot/oprofile/oprofile/libpp/op_header.cpp,v > retrieving revision 1.4 > diff -u -r1.4 op_header.cpp > --- op_header.cpp 11 Jun 2003 18:36:37 -0000 1.4 > +++ op_header.cpp 23 Jun 2003 22:23:01 -0000 > @@ -150,7 +150,7 @@ > char old_fill = out.fill(); > out << " with a unit mask of 0x" > << hex << setw(2) << setfill('0') << unsigned(um) << " (" > - << um_desc << ")"; > + << (um_desc ? um_desc : "multiple flags") << ")"; > out << setfill(old_fill) << setw(old_width) << dec; we need to output the um numeric value when multiple flags, something like "(0x3f multiple flags)". Ok to commit with this change. oh and btw can you correct the u16 um as parameter, it's completely wrong nope ? Would be u32. regards, Phil |
From: Philippe E. <ph...@wa...> - 2003-06-24 00:16:29
|
Philippe Elie wrote: > graydon hoare wrote: >> << " (" >> - << um_desc << ")"; >> + << (um_desc ? um_desc : "multiple flags") << ")"; >> out << setfill(old_fill) << setw(old_width) << dec; > > > we need to output the um numeric value when multiple flags, > something like "(0x3f multiple flags)". > > Ok to commit with this change. > > oh and btw can you correct the u16 um as parameter, it's > completely wrong nope ? Would be u32. errm u16 should be safe, ignore this comment regards, Phil |
From: Philippe E. <ph...@wa...> - 2003-06-24 00:20:44
|
Philippe Elie wrote: > Philippe Elie wrote: > >> graydon hoare wrote: > > > >>> << " (" >>> - << um_desc << ")"; >>> + << (um_desc ? um_desc : "multiple flags") << ")"; >>> out << setfill(old_fill) << setw(old_width) << dec; >> >> >> >> we need to output the um numeric value when multiple flags, >> something like "(0x3f multiple flags)". >> >> Ok to commit with this change. >> >> oh and btw can you correct the u16 um as parameter, it's >> completely wrong nope ? Would be u32. > > > errm u16 should be safe, ignore this comment re-errm, ignore the two other mail, commit as it please regards, Phil |