From: Gilles A. <gil...@or...> - 2013-05-30 16:34:08
|
Check boxes associated to non significant bits in unit mask should not be visible. This patch prevents from showing irrelevant check boxes in 'Unit mask' sub- window. Signed-off-by: Gilles Allard <gil...@or...> --- gui/oprof_start.cpp | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/gui/oprof_start.cpp b/gui/oprof_start.cpp index 002fe1e..1f09f4c 100644 --- a/gui/oprof_start.cpp +++ b/gui/oprof_start.cpp @@ -804,8 +804,9 @@ void oprof_start::setup_unit_masks(op_event_descr const & descr) unit_mask_group->setExclusive(um->unit_type_mask == utm_exclusive); - for (size_t i = 0; i < OP_MAX_HANDLED_UMS; ++i) { - QCheckBox * check = 0; + QCheckBox * check = NULL; + + for (size_t i = 0; i < um->num; ++i) { switch (i) { case 0: check = check0; break; case 1: check = check1; break; -- 1.7.1 |
From: Maynard J. <may...@us...> - 2013-06-13 13:10:55
|
On 05/30/2013 01:06 PM, Gilles Allard wrote: > Hi, Gilles, Sorry for the delay in handling this patch. I had put it on the back burner, and I almost forgot about it. Two things I want to mention . . . First, just a very minor nit . . . When you post patches, please include the one line patch description (from the subject line) in the body of the patch message as the first line. That way, all I need to do is copy the complete text description up to and including your signed-off-line when I do 'git commit'. And when 'git log' is run, you see the nice one-line description at the top of the entry for that commit. Second, when I ran 'git apply' for this patch, it failed with "fatal: corrupt patch at line 19". Line 19 is: > descr) This is an illegal break-up of the previous line. Your email client probably munged the patch. See 'Documentation/email-clients.txt' in the kernel source tree for a good discussion on email clients and patch posting. I was able to fix the corrupted patch and successfully tested it. You patch has been committed and pushed upstream. Thanks! -Maynard > Check boxes associated to non significant bits in unit mask should not be > visible. > This patch prevents from showing irrelevant check boxes in 'Unit mask' sub- > window. > > Signed-off-by: Gilles Allard <gil...@or...> > --- > gui/oprof_start.cpp | 5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/gui/oprof_start.cpp b/gui/oprof_start.cpp > index 002fe1e..1f09f4c 100644 > --- a/gui/oprof_start.cpp > +++ b/gui/oprof_start.cpp > @@ -804,8 +804,9 @@ void oprof_start::setup_unit_masks(op_event_descr const & > descr) > > unit_mask_group->setExclusive(um->unit_type_mask == utm_exclusive); > > - for (size_t i = 0; i < OP_MAX_HANDLED_UMS; ++i) { > - QCheckBox * check = 0; > + QCheckBox * check = NULL; > + > + for (size_t i = 0; i < um->num; ++i) { > switch (i) { > case 0: check = check0; break; > case 1: check = check1; break; > |
From: Gilles A. <gil...@or...> - 2013-06-14 09:38:40
|
Hi Maynard On Thursday, June 13, 2013 08:10:37 AM you wrote: > On 05/30/2013 01:06 PM, Gilles Allard wrote: > > Two things I want to mention . . . > First, just a very minor nit . . . When you post patches, please include the > one line patch description (from the subject line) in the body of the patch > message as the first line. That way, all I need to do is copy the complete > text description up to and including your signed-off-line when I do 'git > commit'. And when 'git log' is run, you see the nice one-line description > at the top of the entry for that commit. > OK. I'll take care of that point for next postings. Thanks for your comment. > Second, when I ran 'git apply' for this patch, it failed with "fatal: corrupt patch at line 19". Line 19 is: > > descr) > > This is an illegal break-up of the previous line. Your email client > probably munged the patch. See 'Documentation/email-clients.txt' in the > kernel source tree for a good discussion on email clients and patch > posting. > I just noticed that my email client wrapped the lines at column 78. That's, I think, the reason why the patch is corrupted. I'll modify this setup and make some tests before next posting. > I was able to fix the corrupted patch and successfully tested it. You patch > has been committed and pushed upstream. Thanks! > > -Maynard > Sorry for these troubles. Gilles Allard |