From: Adrian B. <adr...@mo...> - 2007-12-28 18:56:59
|
This patch restores the Cell OProfile support that was killed by commit 09cadedbdc01f1a4bea1f427d4fb4642eaa19da9. Signed-off-by: Adrian Bunk <adr...@mo...> --- kernel/Kconfig.instrumentation | 8 ++++++++ 1 file changed, 8 insertions(+) 6d1446d35d367fdbdd2a0a29e0d156646ff40630 diff --git a/kernel/Kconfig.instrumentation b/kernel/Kconfig.instrumentation index a76635d..9d143e6 100644 --- a/kernel/Kconfig.instrumentation +++ b/kernel/Kconfig.instrumentation @@ -53,2 +53,10 @@ config HARDWARE_PM +config OPROFILE_CELL + bool "OProfile for Cell Broadband Engine" + depends on PPC && (SPU_FS = y && OPROFILE = m) || (SPU_FS = y && OPROFILE = y) + default y + help + Profiling of Cell BE SPUs requires special support enabled + by this option. + config KPROBES |
From: Mathieu D. <mat...@po...> - 2007-12-28 19:30:06
|
* Adrian Bunk (adr...@mo...) wrote: > This patch restores the Cell OProfile support that was killed by > commit 09cadedbdc01f1a4bea1f427d4fb4642eaa19da9. > > Signed-off-by: Adrian Bunk <adr...@mo...> > Same here : why isn't this on by default when SPU_FS and OPROFILE are enabled ? > --- > > kernel/Kconfig.instrumentation | 8 ++++++++ > 1 file changed, 8 insertions(+) > > 6d1446d35d367fdbdd2a0a29e0d156646ff40630 > diff --git a/kernel/Kconfig.instrumentation b/kernel/Kconfig.instrumentation > index a76635d..9d143e6 100644 > --- a/kernel/Kconfig.instrumentation > +++ b/kernel/Kconfig.instrumentation > @@ -53,2 +53,10 @@ config HARDWARE_PM > > +config OPROFILE_CELL > + bool "OProfile for Cell Broadband Engine" > + depends on PPC && (SPU_FS = y && OPROFILE = m) || (SPU_FS = y && OPROFILE = y) > + default y > + help > + Profiling of Cell BE SPUs requires special support enabled > + by this option. > + > config KPROBES > -- Mathieu Desnoyers Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68 |
From: Mathieu D. <mat...@po...> - 2007-12-29 16:09:18
|
This patch restores the Cell OProfile support that was killed by commit 09cadedbdc01f1a4bea1f427d4fb4642eaa19da9. It puts it in arch/powerpc/Kconfig. Since I don't see any good reason to leave this as a supplementary user-selectable option, it is now automatically enabled whenever SPU_FS and OPROFILE are enabled. Signed-off-by: Mathieu Desnoyers <mat...@po...> CC: Adrian Bunk <adr...@mo...> CC: Randy Dunlap <ran...@or...> CC: ph...@wa... CC: pa...@sa... CC: lin...@oz... CC: opr...@li... --- arch/powerpc/Kconfig | 4 ++++ 1 file changed, 4 insertions(+) Index: linux-2.6-lttng/arch/powerpc/Kconfig =================================================================== --- linux-2.6-lttng.orig/arch/powerpc/Kconfig 2007-12-28 17:00:24.000000000 -0500 +++ linux-2.6-lttng/arch/powerpc/Kconfig 2007-12-28 17:00:39.000000000 -0500 @@ -163,6 +163,10 @@ config PPC_OF_PLATFORM_PCI depends on PPC64 # not supported on 32 bits yet default n +config OPROFILE_CELL + def_bool y + depends on (SPU_FS = y && OPROFILE = m) || (SPU_FS = y && OPROFILE = y) + source "init/Kconfig" source "arch/powerpc/platforms/Kconfig" -- Mathieu Desnoyers Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68 |
From: Arnd B. <ar...@ar...> - 2007-12-31 16:10:56
|
On Saturday 29 December 2007, Mathieu Desnoyers wrote: > This patch restores the Cell OProfile support that was killed by > commit 09cadedbdc01f1a4bea1f427d4fb4642eaa19da9. > > It puts it in arch/powerpc/Kconfig. Since I don't see any good reason to leave > this as a supplementary user-selectable option, it is now automatically enabled > whenever SPU_FS and OPROFILE are enabled. This one has already been superceded by the fix in aed3a8c9bb1a8623a618232087c5ff62718e3b9a, which made CONFIG_OPROFILE_CELL an automatically selected option, from arch/powerpc/platforms/cell/Kconfig. Arnd <>< |
From: Mathieu D. <mat...@po...> - 2008-01-02 17:52:32
|
* Arnd Bergmann (ar...@ar...) wrote: > On Saturday 29 December 2007, Mathieu Desnoyers wrote: > > This patch restores the Cell OProfile support that was killed by > > commit 09cadedbdc01f1a4bea1f427d4fb4642eaa19da9. > > > > It puts it in arch/powerpc/Kconfig. Since I don't see any good reason to leave > > this as a supplementary user-selectable option, it is now automatically enabled > > whenever SPU_FS and OPROFILE are enabled. > > This one has already been superceded by the fix in > aed3a8c9bb1a8623a618232087c5ff62718e3b9a, which made CONFIG_OPROFILE_CELL an > automatically selected option, from arch/powerpc/platforms/cell/Kconfig. > Great, so my patch should be dropped. Thanks! Mathieu > Arnd <>< > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to maj...@vg... > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- Mathieu Desnoyers Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68 |