From: <ol...@li...> - 2007-05-17 23:47:09
|
Hi, This patch contains the needed changes to get support for oprofile on PA Semi PA6T. events/Makefile.in | 3 +- events/ppc64/pa6t/event_mappings | 47 ++++++++++++++++++++++++++++++++++= ++ events/ppc64/pa6t/events | 50 ++++++++++++++++++++++++++++++++++= +++++ events/ppc64/pa6t/unit_masks | 4 +++ libop/op_cpu_type.c | 1=20 libop/op_cpu_type.h | 1=20 libop/op_events.c | 5 +++ utils/opcontrol | 2 - utils/ophelp.c | 5 +++ 9 files changed, 116 insertions(+), 2 deletions(-) Index: oprofile/events/Makefile.in =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- oprofile.orig/events/Makefile.in 2007-05-17 14:21:54.000000000 -0700 +++ oprofile/events/Makefile.in 2007-05-17 14:27:39.000000000 -0700 @@ -210,6 +210,7 @@ ppc64/970/events ppc64/970/event_mappings ppc64/970/unit_masks \ ppc64/970MP/events ppc64/970MP/event_mappings ppc64/970MP/unit_masks \ ppc64/cell-be/events ppc64/cell-be/unit_masks \ + ppc64/pa6t/events ppc64/pa6t/event_mappings ppc64/pa6t/unit_masks \ rtc/events rtc/unit_masks \ x86-64/hammer/events x86-64/hammer/unit_masks \ x86-64/family10/events x86-64/family10/unit_masks \ @@ -273,7 +274,7 @@ =20 =20 distdir: $(DISTFILES) - $(mkdir_p) $(distdir)/alpha/ev4 $(distdir)/alpha/ev5 $(distdir)/alpha/ev6= $(distdir)/alpha/ev67 $(distdir)/alpha/pca56 $(distdir)/arm/xscale1 $(dist= dir)/arm/xscale2 $(distdir)/i386/athlon $(distdir)/i386/core $(distdir)/i38= 6/core_2 $(distdir)/i386/p4 $(distdir)/i386/p4-ht $(distdir)/i386/p6_mobile= $(distdir)/i386/pii $(distdir)/i386/piii $(distdir)/i386/ppro $(distdir)/i= a64/ia64 $(distdir)/ia64/itanium $(distdir)/ia64/itanium2 $(distdir)/mips/2= 0K $(distdir)/mips/24K $(distdir)/mips/25K $(distdir)/mips/34K $(distdir)/m= ips/5K $(distdir)/mips/r10000 $(distdir)/mips/r12000 $(distdir)/mips/rm7000= $(distdir)/mips/rm9000 $(distdir)/mips/sb1 $(distdir)/mips/vr5432 $(distdi= r)/mips/vr5500 $(distdir)/ppc/7450 $(distdir)/ppc/e500 $(distdir)/ppc/e500v= 2 $(distdir)/ppc64/970 $(distdir)/ppc64/970MP $(distdir)/ppc64/cell-be $(di= stdir)/ppc64/power4 $(distdir)/ppc64/power5 $(distdir)/ppc64/power5+ $(dist= dir)/ppc64/power6 $(distdir)/rtc $(distdir)/x86-64/family10 $(distdir)/x86-= 64/hammer + $(mkdir_p) $(distdir)/alpha/ev4 $(distdir)/alpha/ev5 $(distdir)/alpha/ev6= $(distdir)/alpha/ev67 $(distdir)/alpha/pca56 $(distdir)/arm/xscale1 $(dist= dir)/arm/xscale2 $(distdir)/i386/athlon $(distdir)/i386/core $(distdir)/i38= 6/core_2 $(distdir)/i386/p4 $(distdir)/i386/p4-ht $(distdir)/i386/p6_mobile= $(distdir)/i386/pii $(distdir)/i386/piii $(distdir)/i386/ppro $(distdir)/i= a64/ia64 $(distdir)/ia64/itanium $(distdir)/ia64/itanium2 $(distdir)/mips/2= 0K $(distdir)/mips/24K $(distdir)/mips/25K $(distdir)/mips/34K $(distdir)/m= ips/5K $(distdir)/mips/r10000 $(distdir)/mips/r12000 $(distdir)/mips/rm7000= $(distdir)/mips/rm9000 $(distdir)/mips/sb1 $(distdir)/mips/vr5432 $(distdi= r)/mips/vr5500 $(distdir)/ppc/7450 $(distdir)/ppc/e500 $(distdir)/ppc/e500v= 2 $(distdir)/ppc64/970 $(distdir)/ppc64/970MP $(distdir)/ppc64/cell-be $(di= stdir)/ppc64/pa6t $(distdir)/ppc64/power4 $(distdir)/ppc64/power5 $(distdir= )/ppc64/power5+ $(distdir)/ppc64/power6 $(distdir)/rtc $(distdir)/x86-64/fa= mily10 $(distdir)/x86-64/hammer @srcdirstrip=3D`echo "$(srcdir)" | sed 's|.|.|g'`; \ topsrcdirstrip=3D`echo "$(top_srcdir)" | sed 's|.|.|g'`; \ list=3D'$(DISTFILES)'; for file in $$list; do \ Index: oprofile/libop/op_cpu_type.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- oprofile.orig/libop/op_cpu_type.c 2007-04-13 12:43:01.000000000 -0700 +++ oprofile/libop/op_cpu_type.c 2007-05-17 14:25:47.000000000 -0700 @@ -47,6 +47,7 @@ { "ppc64 POWER5", "ppc64/power5", CPU_PPC64_POWER5, 6 }, { "ppc64 POWER5+", "ppc64/power5+", CPU_PPC64_POWER5p, 6 }, { "ppc64 970", "ppc64/970", CPU_PPC64_970, 8 }, + { "ppc64 PA6T", "ppc64/pa6t", CPU_PPC64_PA6T, 6 }, { "MIPS 20K", "mips/20K", CPU_MIPS_20K, 1}, { "MIPS 24K", "mips/24K", CPU_MIPS_24K, 2}, { "MIPS 25K", "mips/25K", CPU_MIPS_25K, 2}, Index: oprofile/libop/op_cpu_type.h =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- oprofile.orig/libop/op_cpu_type.h 2007-04-13 12:43:01.000000000 -0700 +++ oprofile/libop/op_cpu_type.h 2007-05-17 14:25:47.000000000 -0700 @@ -43,6 +43,7 @@ CPU_PPC64_POWER5, /**< ppc64 POWER5 family */ CPU_PPC64_POWER5p, /**< ppc64 Power5+ family */ CPU_PPC64_970, /**< ppc64 970 family */ + CPU_PPC64_PA6T, /**< ppc64 PA6T */ CPU_MIPS_20K, /**< MIPS 20K */ CPU_MIPS_24K, /**< MIPS 24K */ CPU_MIPS_25K, /**< MIPS 25K */ Index: oprofile/libop/op_events.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- oprofile.orig/libop/op_events.c 2007-03-23 12:28:59.000000000 -0700 +++ oprofile/libop/op_events.c 2007-05-17 14:47:31.000000000 -0700 @@ -642,6 +642,7 @@ FILE * fp =3D open_event_mapping_file(cpu_name); char const * map =3D NULL; switch (cpu_type) { + case CPU_PPC64_PA6T: case CPU_PPC64_970: case CPU_PPC64_970MP: case CPU_PPC64_POWER4: @@ -787,6 +788,7 @@ descr->name =3D "CPU_CYCLES"; break; =20 + case CPU_PPC64_PA6T: case CPU_PPC64_970: case CPU_PPC64_970MP: case CPU_PPC_7450: Index: oprofile/utils/opcontrol =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- oprofile.orig/utils/opcontrol 2007-05-10 16:33:07.000000000 -0700 +++ oprofile/utils/opcontrol 2007-05-17 14:28:36.000000000 -0700 @@ -1040,7 +1040,7 @@ { case "$1" in ppc64/power4 | ppc64/power5 | ppc64/power5+ | \ - ppc64/power6 | ppc64/970 | ppc64/970MP ) + ppc64/power6 | ppc64/970 | ppc64/970MP | ppc64/pa6t ) return 1; ;; *) Index: oprofile/utils/ophelp.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- oprofile.orig/utils/ophelp.c 2007-04-10 06:09:43.000000000 -0700 +++ oprofile/utils/ophelp.c 2007-05-17 14:25:47.000000000 -0700 @@ -426,6 +426,11 @@ break; break; =20 + case CPU_PPC64_PA6T: + printf("See PA6T Power Implementation Features Book IV\n" + "Chapter 7 Performance Counters\n"); + break; + case CPU_PPC64_POWER4: case CPU_PPC64_POWER5: case CPU_PPC64_POWER6: Index: oprofile/events/ppc64/pa6t/event_mappings =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- /dev/null 1970-01-01 00:00:00.000000000 +0000 +++ oprofile/events/ppc64/pa6t/event_mappings 2007-05-17 15:30:11.000000000= -0700 @@ -0,0 +1,48 @@ +# pa6t does not have an mmcra. mmcr0 has all the enables and config +# bits. mmcr1 contains the event selectors for the four programmable +# events + +# Group Default +event:0x1 mmcr0:0x000000000005b81b mmcr1:0x0000000000949f00 mmcra:0x0 +event:0x3 mmcr0:0x000000000005b81b mmcr1:0x0000000000949f00 mmcra:0x0 +event:0x4 mmcr0:0x000000000005b81b mmcr1:0x0000000000949f00 mmcra:0x0 + +# Group 1, Load/Store +event:0x10 mmcr0:0x000000000007f83f mmcr1:0x00000000a8c0cab1 mmcra:0x0 +event:0x11 mmcr0:0x000000000007f83f mmcr1:0x00000000a8c0cab1 mmcra:0x0 +event:0x12 mmcr0:0x000000000007f83f mmcr1:0x00000000a8c0cab1 mmcra:0x0 +event:0x13 mmcr0:0x000000000007f83f mmcr1:0x00000000a8c0cab1 mmcra:0x0 +event:0x14 mmcr0:0x000000000007f83f mmcr1:0x00000000a8c0cab1 mmcra:0x0 +event:0x15 mmcr0:0x000000000007f83f mmcr1:0x00000000a8c0cab1 mmcra:0x0 + +# Group 2, Frontend +event:0x20 mmcr0:0x000000000007f83f mmcr1:0x0000000002058401 mmcra:0x0 +event:0x21 mmcr0:0x000000000007f83f mmcr1:0x0000000002058401 mmcra:0x0 +event:0x22 mmcr0:0x000000000007f83f mmcr1:0x0000000002058401 mmcra:0x0 +event:0x23 mmcr0:0x000000000007f83f mmcr1:0x0000000002058401 mmcra:0x0 +event:0x24 mmcr0:0x000000000007f83f mmcr1:0x0000000002058401 mmcra:0x0 +event:0x25 mmcr0:0x000000000007f83f mmcr1:0x0000000002058401 mmcra:0x0 + +# Group 3, Branches +event:0x30 mmcr0:0x000000000007f83f mmcr1:0x000000008d8b8988 mmcra:0x0 +event:0x31 mmcr0:0x000000000007f83f mmcr1:0x000000008d8b8988 mmcra:0x0 +event:0x32 mmcr0:0x000000000007f83f mmcr1:0x000000008d8b8988 mmcra:0x0 +event:0x33 mmcr0:0x000000000007f83f mmcr1:0x000000008d8b8988 mmcra:0x0 +event:0x34 mmcr0:0x000000000007f83f mmcr1:0x000000008d8b8988 mmcra:0x0 +event:0x35 mmcr0:0x000000000007f83f mmcr1:0x000000008d8b8988 mmcra:0x0 + +# Group 4, Translation +event:0x40 mmcr0:0x000000000007f83f mmcr1:0x0000000086baa7a8 mmcra:0x0 +event:0x41 mmcr0:0x000000000007f83f mmcr1:0x0000000086baa7a8 mmcra:0x0 +event:0x42 mmcr0:0x000000000007f83f mmcr1:0x0000000086baa7a8 mmcra:0x0 +event:0x43 mmcr0:0x000000000007f83f mmcr1:0x0000000086baa7a8 mmcra:0x0 +event:0x44 mmcr0:0x000000000007f83f mmcr1:0x0000000086baa7a8 mmcra:0x0 +event:0x45 mmcr0:0x000000000007f83f mmcr1:0x0000000086baa7a8 mmcra:0x0 + +# Group 5, Memory +event:0x50 mmcr0:0x000000000007f83f mmcr1:0x00000000c030cab1 mmcra:0x0 +event:0x51 mmcr0:0x000000000007f83f mmcr1:0x00000000c030cab1 mmcra:0x0 +event:0x52 mmcr0:0x000000000007f83f mmcr1:0x00000000c030cab1 mmcra:0x0 +event:0x53 mmcr0:0x000000000007f83f mmcr1:0x00000000c030cab1 mmcra:0x0 +event:0x54 mmcr0:0x000000000007f83f mmcr1:0x00000000c030cab1 mmcra:0x0 +event:0x55 mmcr0:0x000000000007f83f mmcr1:0x00000000c030cab1 mmcra:0x0 Index: oprofile/events/ppc64/pa6t/events =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- /dev/null 1970-01-01 00:00:00.000000000 +0000 +++ oprofile/events/ppc64/pa6t/events 2007-05-17 15:33:10.000000000 -0700 @@ -0,0 +1,52 @@ +# ppc64 pa6t events +# +# Unlike the IBM ppc64 chips, any of pa6t's events can be programmed into = any +# of the counters (pmc2-5). The notion of groups on pa6t is thus +# artificial. That said, we can still define useful aggregations to guide = the +# user in his choice of group for a profiling session. + +# Group Default +event:0x1 counters:0 um:zero minimum:10000 name:CYCLES : Processor Cycles +event:0x3 counters:3 um:zero minimum:10000 name:ISS_CYCLES : Processor Cyc= les with instructions issued +event:0x4 counters:4 um:zero minimum:10000 name:RET_UOP : Retired Micro-op= eratioins + +# Group 1, Load/Store +event:0x10 counters:0 um:zero minimum:10000 name:GRP1_CYCLES : Processor C= ycles +event:0x11 counters:1 um:zero minimum:10000 name:GRP1_INST_RETIRED : Instr= uctions retired +event:0x12 counters:2 um:zero minimum:1000 name:GRP1_DCACHE_RD_MISS__NS : = Dcache read misses NS +event:0x13 counters:3 um:zero minimum:500 name:GRP1_MRB_LD_MISS_L2__NS : L= oad misses filling from memory +event:0x14 counters:4 um:zero minimum:500 name:GRP1_MRB_ST_MISS_ALLOC__NS = : Store misses in L1D and allocates an MRB entry +event:0x15 counters:5 um:zero minimum:500 name:GRP1_TLB_MISS_D__NS : TLB m= isses NS (D- only) + +# Group 2, Frontend +event:0x20 counters:0 um:zero minimum:10000 name:GRP2_CYCLES : Processor C= ycles +event:0x21 counters:1 um:zero minimum:10000 name:GRP2_INST_RETIRED : Instr= uctions retired +event:0x22 counters:2 um:zero minimum:2000 name:GRP2_FETCH_REQ : Demand fe= tch requests made to the Icache +event:0x23 counters:3 um:zero minimum:500 name:GRP2_ICACHE_MISS_DEM__NS : = Demand fetch requests missing in the Icache +event:0x24 counters:4 um:zero minimum:500 name:GRP2_ICACHE_MISS_ALL : Dema= nd and spec fetch requests missing in the Icache +event:0x25 counters:5 um:zero minimum:2000 name:GRP2_ICACHE_ACC : Icache a= ccesses + +# Group 3, Branches +event:0x30 counters:0 um:zero minimum:10000 name:GRP3_CYCLES : Processor C= ycles +event:0x31 counters:1 um:zero minimum:10000 name:GRP3_INST_RETIRED : Instr= uctions retired +event:0x32 counters:2 um:zero minimum:500 name:GRP3_NXT_LINE_MISPRED__NS := Next fetch address mispredict +event:0x33 counters:3 um:zero minimum:500 name:GRP3_DIRN_MISPRED__NS : Bra= nch direction mispredict +event:0x34 counters:4 um:zero minimum:500 name:GRP3_TGT_ADDR_MISPRED__NS := Branch target address mispredict +event:0x35 counters:5 um:zero minimum:2000 name:GRP3_BRA_TAKEN__NS : Taken= branches + +# Group 4, Translation +event:0x40 counters:0 um:zero minimum:10000 name:GRP4_CYCLES : Processor C= ycles +event:0x41 counters:1 um:zero minimum:10000 name:GRP4_INST_RETIRED : Instr= uctions retired +event:0x42 counters:2 um:zero minimum:500 name:GRP4_TLB_MISS_D__NS : TLB M= isses (D-) +event:0x43 counters:3 um:zero minimum:500 name:GRP4_TLB_MISS_I__NS : TLB M= Isses (I-) +event:0x44 counters:4 um:zero minimum:500 name:GRP4_DERAT_MISS__NS : DERAT= Misses +event:0x45 counters:5 um:zero minimum:500 name:GRP4_IERAT_MISS__NS : IERAT= Misses + +# Group 5, Memory +event:0x50 counters:0 um:zero minimum:10000 name:GRP5_CYCLES : Processor C= ycles +event:0x51 counters:1 um:zero minimum:10000 name:GRP5_INST_RETIRED : Instr= uctions retired +event:0x52 counters:2 um:zero minimum:500 name:GRP5_DCACHE_RD_MISS__NS : D= cache read misses NS +event:0x53 counters:3 um:zero minimum:500 name:GRP5_MRB_LD_MISS_L2__NS : L= oad misses filling from memory +event:0x54 counters:4 um:zero minimum:500 name:GRP5_DCACHE_VIC : Dcache li= ne evicted (snoops not included) +event:0x55 counters:5 um:zero minimum:500 name:GRP5_MRB_ST_MISS_ALLOC__NS = : Store misses in L1D and allocates an MRB entry + Index: oprofile/events/ppc64/pa6t/unit_masks =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- /dev/null 1970-01-01 00:00:00.000000000 +0000 +++ oprofile/events/ppc64/pa6t/unit_masks 2007-05-17 14:25:47.000000000 -07= 00 @@ -0,0 +1,4 @@ +# ppc64 pa6t possible unit masks +# +name:zero type:mandatory default:0x0 + 0x0 No unit mask |
From: John L. <le...@mo...> - 2007-05-18 18:04:28
|
On Thu, May 17, 2007 at 06:50:39PM -0500, Olof Johansson wrote: > This patch contains the needed changes to get support for oprofile on PA > Semi PA6T. Is the kernel support merged upstream? john |
From: <ol...@li...> - 2007-05-18 18:24:11
|
Hi, On Fri, May 18, 2007 at 06:28:07PM +0100, John Levon wrote: > On Thu, May 17, 2007 at 06:50:39PM -0500, Olof Johansson wrote: > > > This patch contains the needed changes to get support for oprofile on PA > > Semi PA6T. > > Is the kernel support merged upstream? > > john Yep! 2.6.21 had it. -Olof |
From: John L. <le...@mo...> - 2007-05-19 14:01:21
|
On Thu, May 17, 2007 at 06:50:39PM -0500, Olof Johansson wrote: > This patch contains the needed changes to get support for oprofile on PA > Semi PA6T. Applied thanks john |
From: William C. <wc...@re...> - 2007-05-20 15:55:43
|
Olof Johansson wrote: > Hi, > > This patch contains the needed changes to get support for oprofile on PA > Semi PA6T. list='$(DISTFILES)'; for file in $$list; do \ > Index: oprofile/libop/op_cpu_type.c > =================================================================== > --- oprofile.orig/libop/op_cpu_type.c 2007-04-13 12:43:01.000000000 -0700 > +++ oprofile/libop/op_cpu_type.c 2007-05-17 14:25:47.000000000 -0700 > @@ -47,6 +47,7 @@ > { "ppc64 POWER5", "ppc64/power5", CPU_PPC64_POWER5, 6 }, > { "ppc64 POWER5+", "ppc64/power5+", CPU_PPC64_POWER5p, 6 }, > { "ppc64 970", "ppc64/970", CPU_PPC64_970, 8 }, > + { "ppc64 PA6T", "ppc64/pa6t", CPU_PPC64_PA6T, 6 }, > { "MIPS 20K", "mips/20K", CPU_MIPS_20K, 1}, > { "MIPS 24K", "mips/24K", CPU_MIPS_24K, 2}, > { "MIPS 25K", "mips/25K", CPU_MIPS_25K, 2}, > Index: oprofile/libop/op_cpu_type.h > =================================================================== > --- oprofile.orig/libop/op_cpu_type.h 2007-04-13 12:43:01.000000000 -0700 > +++ oprofile/libop/op_cpu_type.h 2007-05-17 14:25:47.000000000 -0700 > @@ -43,6 +43,7 @@ > CPU_PPC64_POWER5, /**< ppc64 POWER5 family */ > CPU_PPC64_POWER5p, /**< ppc64 Power5+ family */ > CPU_PPC64_970, /**< ppc64 970 family */ > + CPU_PPC64_PA6T, /**< ppc64 PA6T */ > CPU_MIPS_20K, /**< MIPS 20K */ > CPU_MIPS_24K, /**< MIPS 24K */ > CPU_MIPS_25K, /**< MIPS 25K */ I thought that the new processors were added at the end of the lists to avoid changing the enumeration between versions of OProfile? Or do we expected that only the really ancient kernels use that mechanism, so that this data enum is only used internally and grouping by processor type make the code easier for programmers to understand? -Will |
From: John L. <le...@mo...> - 2007-05-20 17:19:36
|
On Sun, May 20, 2007 at 11:55:15AM -0400, William Cohen wrote: > I thought that the new processors were added at the end of the lists to avoid > changing the enumeration between versions of OProfile? Or do we expected that > only the really ancient kernels use that mechanism, so that this data enum is > only used internally and grouping by processor type make the code easier for > programmers to understand? I fixed this up when applying this patch. All new processor types go at the end of the enum. regards john |