From: Arnd B. <ar...@ar...> - 2013-05-02 15:33:27
|
Hi subsystem maintainers, This is a set of patches to to fix build errors I hit while trying to build lots of randconfig kernels on linux-next. Most of them are simple missing dependencies in Kconfig, but some are more substantial. I would like to see at least the obvious patches get merged for 3.10. If you are happy with the patches, feel free to apply them directly, otherwise please provide feedback. No single patch out of these is very important though, most of them only concern corner cases and don't matter in practice. Arnd Arnd Bergmann (22): can: move CONFIG_HAVE_CAN_FLEXCAN out of CAN_DEV cpufreq: ARM_DT_BL_CPUFREQ needs ARM_CPU_TOPOLOGY cpuidle: calxeda: select ARM_CPU_SUSPEND staging/drm: imx: add missing dependencies drm: always provide debugfs function prototypes gpu/drm: host1x: add dependency on Tegra drm/tilcd: select BACKLIGHT_LCD_SUPPORT OMAPDSS: DPI needs DSI crypto: lz4: don't build on ARM mfd: ab8500: debugfs code depends on gpadc iwlegacy: il_pm_ops is only provided for PM_SLEEP thermal: cpu_cooling: fix stub function staging/logger: use kuid_t internally oprofile: always enable IRQ_WORK USB: EHCI: remove bogus #error USB: UHCI: clarify Kconfig dependencies USB: OHCI: clarify Kconfig dependencies Xen: SWIOTLB is only used on x86 staging/solo6x10: depend on CONFIG_FONTS media: coda: select GENERIC_ALLOCATOR davinci: vpfe_capture needs i2c radio-si4713: depend on SND_SOC arch/Kconfig | 1 + crypto/Kconfig | 2 ++ drivers/cpufreq/Kconfig.arm | 1 + drivers/cpuidle/Kconfig | 1 + drivers/gpu/drm/tilcdc/Kconfig | 1 + drivers/gpu/host1x/drm/Kconfig | 1 + drivers/media/platform/Kconfig | 1 + drivers/media/platform/davinci/Kconfig | 3 ++ drivers/media/radio/Kconfig | 1 + drivers/mfd/Kconfig | 2 +- drivers/net/can/Kconfig | 6 ++-- drivers/net/wireless/iwlegacy/common.h | 2 +- drivers/staging/android/logger.c | 4 +-- drivers/staging/android/logger.h | 2 +- drivers/staging/imx-drm/Kconfig | 4 +++ drivers/staging/media/solo6x10/Kconfig | 1 + drivers/usb/host/Kconfig | 65 +++++++++++++++++++++++++++++----- drivers/usb/host/Makefile | 4 +-- drivers/usb/host/ehci-hcd.c | 17 --------- drivers/usb/host/ohci-hcd.c | 19 ---------- drivers/usb/host/uhci-hcd.c | 4 +-- drivers/video/console/Makefile | 2 ++ drivers/video/omap2/dss/Kconfig | 1 + drivers/xen/Kconfig | 2 +- include/drm/drmP.h | 3 +- include/linux/cpu_cooling.h | 2 +- 26 files changed, 91 insertions(+), 61 deletions(-) -- 1.8.1.2 Cc: Alan Stern <st...@ro...> Cc: Daniel Lezcano <dan...@li...> Cc: Dave Airlie <ai...@re...> Cc: Greg Kroah-Hartman <gr...@li...> Cc: Hans Verkuil <hve...@xs...> Cc: Herbert Xu <he...@go...> Cc: John W. Linville <lin...@tu...> Cc: Konrad Rzeszutek Wilk <kon...@or...> Cc: Mauro Carvalho Chehab <mc...@in...> Cc: Oliver Hartkopp <soc...@ha...> Cc: Rafael J. Wysocki <rj...@si...> Cc: Robert Richter <rr...@ke...> Cc: Samuel Ortiz <sa...@li...> Cc: Shawn Guo <sha...@li...> Cc: Thierry Reding <thi...@av...> Cc: Tomi Valkeinen <tom...@ti...> Cc: Viresh Kumar <vir...@li...> Cc: Zhang Rui <rui...@in...> Cc: cp...@vg... Cc: dri...@li... Cc: lin...@vg... Cc: lin...@vg... Cc: lin...@vg... Cc: opr...@li... |
From: Arnd B. <ar...@ar...> - 2013-05-02 15:31:06
|
oprofile fails to build if CONFIG_IRQ_WORK is not already enabled, because of the dependency on the RING_BUFFER code that now uses the irq work library. kernel/built-in.o: In function `ring_buffer_unlock_commit': :(.text+0x5b8f0): undefined reference to `irq_work_queue' kernel/built-in.o: In function `ring_buffer_write': :(.text+0x5bd10): undefined reference to `irq_work_queue' Cc: Robert Richter <rr...@ke...> Cc: opr...@li... Signed-off-by: Arnd Bergmann <ar...@ar...> --- arch/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/Kconfig b/arch/Kconfig index a6b1056..434a8dc 100644 --- a/arch/Kconfig +++ b/arch/Kconfig @@ -8,6 +8,7 @@ config OPROFILE depends on HAVE_OPROFILE select RING_BUFFER select RING_BUFFER_ALLOW_SWAP + select IRQ_WORK help OProfile is a profiling system capable of profiling the whole system, include the kernel, kernel modules, libraries, -- 1.8.1.2 |
From: Robert R. <rr...@ke...> - 2013-05-03 11:53:43
|
On 02.05.13 17:16:18, Arnd Bergmann wrote: > oprofile fails to build if CONFIG_IRQ_WORK is not already enabled, > because of the dependency on the RING_BUFFER code that now uses > the irq work library. > > kernel/built-in.o: In function `ring_buffer_unlock_commit': > :(.text+0x5b8f0): undefined reference to `irq_work_queue' > kernel/built-in.o: In function `ring_buffer_write': > :(.text+0x5bd10): undefined reference to `irq_work_queue' Shouldn't this be fixed in the ring_buffer implementation? I also do not see, where this comes from. I was successfully compiling a kernel with OPROFILE and RING_BUFFER enabled but IRQ_WORK disabled. Do you have that config still available? Thanks, -Robert > > Cc: Robert Richter <rr...@ke...> > Cc: opr...@li... > Signed-off-by: Arnd Bergmann <ar...@ar...> > --- > arch/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/Kconfig b/arch/Kconfig > index a6b1056..434a8dc 100644 > --- a/arch/Kconfig > +++ b/arch/Kconfig > @@ -8,6 +8,7 @@ config OPROFILE > depends on HAVE_OPROFILE > select RING_BUFFER > select RING_BUFFER_ALLOW_SWAP > + select IRQ_WORK > help > OProfile is a profiling system capable of profiling the > whole system, include the kernel, kernel modules, libraries, > -- > 1.8.1.2 > |
From: Steven R. <ro...@go...> - 2013-05-03 15:02:52
|
On Fri, 2013-05-03 at 13:53 +0200, Robert Richter wrote: > On 02.05.13 17:16:18, Arnd Bergmann wrote: > > oprofile fails to build if CONFIG_IRQ_WORK is not already enabled, > > because of the dependency on the RING_BUFFER code that now uses > > the irq work library. > > > > kernel/built-in.o: In function `ring_buffer_unlock_commit': > > :(.text+0x5b8f0): undefined reference to `irq_work_queue' > > kernel/built-in.o: In function `ring_buffer_write': > > :(.text+0x5bd10): undefined reference to `irq_work_queue' > > Shouldn't this be fixed in the ring_buffer implementation? Hmm, I thought I had ring buffer select irq work. I must have not have done that. > > I also do not see, where this comes from. I was successfully compiling > a kernel with OPROFILE and RING_BUFFER enabled but IRQ_WORK disabled. > Do you have that config still available? > The ring buffer code can now wake up waiters, and to do so it requires irq_work. I'll send a patch. Thanks, -- Steve |
From: Rafael J. W. <rj...@si...> - 2013-05-02 18:58:01
|
On Thursday, May 02, 2013 05:16:04 PM Arnd Bergmann wrote: > Hi subsystem maintainers, > > This is a set of patches to to fix build errors I hit while trying to > build lots of randconfig kernels on linux-next. > > Most of them are simple missing dependencies in Kconfig, but some are > more substantial. I would like to see at least the obvious patches > get merged for 3.10. If you are happy with the patches, feel free > to apply them directly, otherwise please provide feedback. > > No single patch out of these is very important though, most of them > only concern corner cases and don't matter in practice. For cpufreq and cpuidle: Acked-by: Rafael J. Wysocki <raf...@in...> > Arnd Bergmann (22): > can: move CONFIG_HAVE_CAN_FLEXCAN out of CAN_DEV > cpufreq: ARM_DT_BL_CPUFREQ needs ARM_CPU_TOPOLOGY > cpuidle: calxeda: select ARM_CPU_SUSPEND > staging/drm: imx: add missing dependencies > drm: always provide debugfs function prototypes > gpu/drm: host1x: add dependency on Tegra > drm/tilcd: select BACKLIGHT_LCD_SUPPORT > OMAPDSS: DPI needs DSI > crypto: lz4: don't build on ARM > mfd: ab8500: debugfs code depends on gpadc > iwlegacy: il_pm_ops is only provided for PM_SLEEP > thermal: cpu_cooling: fix stub function > staging/logger: use kuid_t internally > oprofile: always enable IRQ_WORK > USB: EHCI: remove bogus #error > USB: UHCI: clarify Kconfig dependencies > USB: OHCI: clarify Kconfig dependencies > Xen: SWIOTLB is only used on x86 > staging/solo6x10: depend on CONFIG_FONTS > media: coda: select GENERIC_ALLOCATOR > davinci: vpfe_capture needs i2c > radio-si4713: depend on SND_SOC > > arch/Kconfig | 1 + > crypto/Kconfig | 2 ++ > drivers/cpufreq/Kconfig.arm | 1 + > drivers/cpuidle/Kconfig | 1 + > drivers/gpu/drm/tilcdc/Kconfig | 1 + > drivers/gpu/host1x/drm/Kconfig | 1 + > drivers/media/platform/Kconfig | 1 + > drivers/media/platform/davinci/Kconfig | 3 ++ > drivers/media/radio/Kconfig | 1 + > drivers/mfd/Kconfig | 2 +- > drivers/net/can/Kconfig | 6 ++-- > drivers/net/wireless/iwlegacy/common.h | 2 +- > drivers/staging/android/logger.c | 4 +-- > drivers/staging/android/logger.h | 2 +- > drivers/staging/imx-drm/Kconfig | 4 +++ > drivers/staging/media/solo6x10/Kconfig | 1 + > drivers/usb/host/Kconfig | 65 +++++++++++++++++++++++++++++----- > drivers/usb/host/Makefile | 4 +-- > drivers/usb/host/ehci-hcd.c | 17 --------- > drivers/usb/host/ohci-hcd.c | 19 ---------- > drivers/usb/host/uhci-hcd.c | 4 +-- > drivers/video/console/Makefile | 2 ++ > drivers/video/omap2/dss/Kconfig | 1 + > drivers/xen/Kconfig | 2 +- > include/drm/drmP.h | 3 +- > include/linux/cpu_cooling.h | 2 +- > 26 files changed, 91 insertions(+), 61 deletions(-) > > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. |
From: Steven R. <ro...@go...> - 2013-05-03 15:15:03
|
On Fri, 2013-05-03 at 13:53 +0200, Robert Richter wrote: > On 02.05.13 17:16:18, Arnd Bergmann wrote: > > oprofile fails to build if CONFIG_IRQ_WORK is not already enabled, > > because of the dependency on the RING_BUFFER code that now uses > > the irq work library. > > > > kernel/built-in.o: In function `ring_buffer_unlock_commit': > > :(.text+0x5b8f0): undefined reference to `irq_work_queue' > > kernel/built-in.o: In function `ring_buffer_write': > > :(.text+0x5bd10): undefined reference to `irq_work_queue' > > Shouldn't this be fixed in the ring_buffer implementation? Does this patch fix it? -- Steve diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig index 5e9efd4..015f85a 100644 --- a/kernel/trace/Kconfig +++ b/kernel/trace/Kconfig @@ -71,6 +71,7 @@ config TRACE_CLOCK config RING_BUFFER bool select TRACE_CLOCK + select IRQ_WORK config FTRACE_NMI_ENTER bool @@ -107,7 +108,6 @@ config TRACING select BINARY_PRINTF select EVENT_TRACING select TRACE_CLOCK - select IRQ_WORK config GENERIC_TRACER bool |
From: Arnd B. <ar...@ar...> - 2013-05-03 21:27:05
|
On Friday 03 May 2013, Steven Rostedt wrote: > On Fri, 2013-05-03 at 13:53 +0200, Robert Richter wrote: > > On 02.05.13 17:16:18, Arnd Bergmann wrote: > > > oprofile fails to build if CONFIG_IRQ_WORK is not already enabled, > > > because of the dependency on the RING_BUFFER code that now uses > > > the irq work library. > > > > > > kernel/built-in.o: In function `ring_buffer_unlock_commit': > > > :(.text+0x5b8f0): undefined reference to `irq_work_queue' > > > kernel/built-in.o: In function `ring_buffer_write': > > > :(.text+0x5bd10): undefined reference to `irq_work_queue' > > > > Shouldn't this be fixed in the ring_buffer implementation? > > Does this patch fix it? > Yes, this works, and looks much nicer than my version. Thanks! Arnd |