#16 Version 1.9.2 fails to build from source on Debian unstable

[Markus Koschany]

I tried to compile version 1.9.2 in an up-to-date build environment on Debian unstable but it fails to build from source. The old version 1.9.1 with Debian wx3.0-compat.patch works instead. The following error message appears:

g++ -DHAVE_CONFIG_H -I. -I.. -D_FORTIFY_SOURCE=2 -I/usr/lib/x86_64-linux-gnu/wx/include/gtk2-unicode-3.0 -I/usr/include/wx-3.0 -D_FILE_OFFSET_BITS=64 -DWXUSINGDLL -DWXGTK -pthread -g -O2 -fPIE -fstack-protector-strong -Wformat -Werror=format-security -std=c++0x -c -o MainFrame.o MainFrame.cpp
In file included from /usr/include/wx-3.0/wx/crt.h:19:0,
from /usr/include/wx-3.0/wx/string.h:4305,
from /usr/include/wx-3.0/wx/memory.h:15,
from /usr/include/wx-3.0/wx/object.h:19,
from /usr/include/wx-3.0/wx/wx.h:15,
from MainFrame.cpp:28:
/usr/include/wx-3.0/wx/wxcrt.h: In instantiation of 'long int wxStrtol(const wxString&, T, int) [with T = long int]':
MainFrame.cpp:513:56: required from here
/usr/include/wx-3.0/wx/wxcrt.h:890:56: error: no type named 'Type' in 'struct wxStrtoxCharType<long int="">'
typedef typename wxStrtoxCharType<T>::Type CharType; \ ^
/usr/include/wx-3.0/wx/wxcrt.h:900:1: note: in expansion of macro 'WX_STRTOX_FUNC'
WX_STRTOX_FUNC(long, wxStrtol, wxCRT_StrtolA, wxCRT_StrtolW)
^
/usr/include/wx-3.0/wx/wxcrt.h:892:62: error: 'AsPointer' is not a member of 'wxStrtoxCharType<long int="">'
wxStrtoxCharType<T>::AsPointer(endptr), \ ^
/usr/include/wx-3.0/wx/wxcrt.h:900:1: note: in expansion of macro 'WX_STRTOX_FUNC'
WX_STRTOX_FUNC(long, wxStrtol, wxCRT_StrtolA, wxCRT_StrtolW)
^
Makefile:425: recipe for target 'MainFrame.o' failed

[Guy Rutenberg]

I've succeeded to compile in Jessie against wxGTK 3.0.1 without a problem. Which version of wxGTK did you compile against?

The problem seems to manifest from wxStrtol which is an undocumented function which probably I should avoid using :-)

[Markus Koschany]

On 22.10.2014 23:16, Guy Rutenberg wrote:

I've succeeded to compile in Jessie against wxGTK 3.0.1 without a
problem. Which version of wxGTK did you compile against?

The problem seems to manifest from wxStrtol which is an undocumented
function which probably I should avoid using :-)

Hi,

I have tried again on Debian Sid but Openyahtzee still fails to build.
I'm using the latest version of libwxgtk3.0-dev (3.0.2-1)

[Guy Rutenberg]

I've just updated my Debian Testing to wxGTK 3.0.2 (see below) but I still can't reproduce the bug.

user@debian:~/openyahtzee$ apt-cache show libwxgtk3.0-dev
Package: libwxgtk3.0-dev
Source: wxwidgets3.0 (3.0.2-1)
Version: 3.0.2-1+b1

I've made a patch that should fix this error. Could you please test if it works for you?

[Markus Koschany]

On 25.10.2014 15:10, Guy Rutenberg wrote:

I've just updated my Debian Testing to wxGTK 3.0.2 (see below) but I
still can't reproduce the bug.

user@debian:~/openyahtzee$ apt-cache show libwxgtk3.0-dev
Package: libwxgtk3.0-dev
Source: wxwidgets3.0 (3.0.2-1)
Version: 3.0.2-1+b1

I've made a patch that should fix this error. Could you please test if
it works for you?

Attachment: wxstrtol_fix.patch (2.2 kB; text/x-diff)

Thanks. The patch fixes the issue. You probably need to build the game
in a clean Sid build environment to reproduce the error.

Regards,

Markus