Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#483 engage_rtp_proxy() causes errors if called from branch_route

trunk
closed-fixed
modules (454)
5
2012-03-22
2012-03-07
Dynamic Packet
No

When calling engage_rtp_proxy() from a branch route on initial invite, replies with status 18x cause "ERROR:rtpproxy:engage_force_rtpproxy: cannot fetch first parameter" in log file. If engage_rtp_proxy() is called from main request route before branching, no error occurs on 18x replies.

It seems this bug is hitting line 2502 in rtpproxy.c . Running with debug=6 shows the following when processing the 18x reply in question:

Mar 7 11:44:44 core6 /usr/sbin/opensips[32402]: DBG:core:decode_mime_type: Decoding MIME type for:[application/sdp]
Mar 7 11:44:44 core6 /usr/sbin/opensips[32402]: DBG:rtpproxy:engage_force_rtpproxy: method id is 1 SDP: 1
Mar 7 11:44:44 core6 /usr/sbin/opensips[32402]: DBG:rtpproxy:engage_force_rtpproxy: handling 200 OK? - 183
Mar 7 11:44:44 core6 /usr/sbin/opensips[32402]: DBG:rtpproxy:move_bavp2dlg: nothing moved - message type 2 code 183
Mar 7 11:44:44 core6 /usr/sbin/opensips[32402]: DBG:rtpproxy:engage_force_rtpproxy: has sdp? 1 - offer 0
Mar 7 11:44:44 core6 /usr/sbin/opensips[32402]: DBG:dialog:fetch_dlg_value: looking for <rtpproxy_1>
Mar 7 11:44:44 core6 /usr/sbin/opensips[32402]: DBG:dialog:fetch_dlg_value: var NOT found!
Mar 7 11:44:44 core6 /usr/sbin/opensips[32402]: ERROR:rtpproxy:engage_force_rtpproxy: cannot fetch first parameter

Whats even stranger, is after the 183, on 200 OK, error does not seem to occur. Could this be related to a failure to track the dialog for 18x replies?

Discussion

    • assigned_to: nobody --> razvancrainea
    • status: open --> open-accepted
     
  • Razvan Crainea
    Razvan Crainea
    2012-03-22

    Hi, Rudy!

    I have committed a fix for this on 1.7 and future 1.8. Let me know if you still have any problems.

    Regards,
    Răzvan

     
  • Razvan Crainea
    Razvan Crainea
    2012-03-22

    • status: open-accepted --> closed-fixed