#27 Inconsistency and error between PduFactory.createPdu methods

[Anonymous]

The edu.nps.moves.disutil.PduFactory.java class is not consistent between the createPdu(byte data[]) and the createPdu(java.nio.ByteBuffer buff) methods. For example, the byte array method produces a SetDataPdu while the ByteBuffer does not. The fix I have made in my own code is to derive the PduFactory class and in the ByteBuffer method, change the body to this:

Pdu pdu = null;

if (arg0 != null) {
byte[] array = arg0.array();
pdu = createPdu(array);
}

return pdu;

This forces the logic into a single method and I'm able to generate a SetDataPdu from my DIS stream. Could someone fix this in a future release please? Thanks.

[Christopher Hopkins]

Sorry. I wasn't logged in when I created the bug.