The attached patch fixes the yyparse parameter compile issue on ptlib 2.10.11 on Linux using Bison 3.0.2, without having to patch bison.simple (which, despite what it says in ReadMe.txt, doesn't even exist on Bison 3.0.2).
I no longer even have that version on my machine. If you can confirm it is backward compatible with bison 2.6 which is still pretty common, then I am happy to commit it.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Status: open Created: Sun Dec 15, 2013 12:43 AM UTC by Dan Fandrich Last Updated: Thu Feb 06, 2014 05:02 AM UTC Owner: nobody
The attached patch fixes the yyparse parameter compile issue on ptlib
2.10.11 on Linux using Bison 3.0.2, without having to patch
bison.simple (which, despite what it says in ReadMe.txt, doesn't even
exist on Bison 3.0.2).
Status: closed-accepted Created: Sun Dec 15, 2013 12:43 AM UTC by Dan Fandrich Last Updated: Thu Feb 06, 2014 08:23 AM UTC Owner: nobody
The attached patch fixes the yyparse parameter compile issue on ptlib
2.10.11 on Linux using Bison 3.0.2, without having to patch
bison.simple (which, despite what it says in ReadMe.txt, doesn't even
exist on Bison 3.0.2).
I confirm that bison 3.0 yields an error and that this patch fixes it. I think it should be committed.
I no longer even have that version on my machine. If you can confirm it is backward compatible with bison 2.6 which is still pretty common, then I am happy to commit it.
I applied the patch against ptlib 2.10.10 and compiled it with bison 2.7 without issue.
Thank you very much, I have applied the patch.
Robert Jongbloed
/OPAL/OpenH323/PTLib Architect and Co-founder./
Commercial support at http://www.voxlucida.com.au
On 6/02/2014 7:17 PM, Dan Fandrich wrote:
Related
Patches:
#259I wrote a comment after my initial comment shown here but somehow it did not appear on this page.
What I wrote is that this patch leads to a reproducible crash, cf. http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=735600.
This bug is "fixed" in 2.10 branch with https://sourceforge.net/p/opalvoip/code/31087/. So I will revert back this commit.
Sorry, Robert, for bothering you with this old branch.
My fault for taking so long to get around to it. :-(
Robert Jongbloed
/OPAL/OpenH323/PTLib Architect and Co-founder./
Commercial support at http://www.voxlucida.com.au
On 6/02/2014 8:13 PM, Eugen Dedu wrote:
Related
Patches:
#259I reverted your commit.