#40 Patch For RFE 1138618

3.2.0
closed
Rick McGuire
None
5
2012-08-14
2007-10-04
TheDavidFactor
No

This is my first attempt at C coding, so please double check this. Please give me feedback on this.

Discussion

  • TheDavidFactor
    TheDavidFactor
    2007-10-04

     
  • Rick McGuire
    Rick McGuire
    2007-10-05

    Logged In: YES
    user_id=1125291
    Originator: NO

    Thanks David. This looks very good. I did add one additional error check to raise an error with tostring('c', 'xyz'). If you check for the svn log, I also fixed a lame error message in the old code.

     
  • TheDavidFactor
    TheDavidFactor
    2007-10-05

     
  • TheDavidFactor
    TheDavidFactor
    2007-10-05

    Logged In: YES
    user_id=1011368
    Originator: YES

    This update contains two semantical changes. First, I noticed that one of the comment lines at the top didn't line up with the others and wanted to fix that in my patch and just forgot about it. Second, the comment for the separator argument still referenced the "S" type and wasn't as clear as I thought it should be.
    File Added: array.makestring.2.patch

     


Anonymous


Cancel   Add attachments