From: Mark M. <mie...@gm...> - 2008-10-29 14:42:42
|
This test case for random currently has an off by 1 failure. I'm not sure if it is the test case or the interpreter. I think the interpreter, but I'm not completely sure: ::method testRandom11 r = random(0, 999999999) [error] [20081029 07:31:33.027000] svn: r3584 Change date: 2008-10-21 14:05:04 -0700 Test: TESTRANDOM11 Class: RANDOM.testGroup File: C:\work.ooRexx\ooTest\4.x\ooRexx\base\bif\RANDOM.testGroup Event: [SYNTAX 40.32] raised unexpectedly. RANDOM difference between argument 1 ("0") and argument 2 ("999999999") must not exceed 999,999,999 Line: 166 166 *-* r = random(0, 999999999) The interpreter has this code: /* too big of a spread ? */ if (maximum - minimum >= MAX_DIFFERENCE) { /* this is an error */ reportException(Error_Incorrect_call_random_range, randmin, randmax); } which I think needs to be just greater than, from the wording of the error message. /* too big of a spread ? */ if (maximum - minimum > MAX_DIFFERENCE) { /* this is an error */ reportException(Error_Incorrect_call_random_range, randmin, randmax); } -- Mark Miesfeld |
From: Rick M. <obj...@gm...> - 2008-10-29 14:48:36
|
Hmmm, how did that error get back in there? I fixed that one before I committed the changes to the random code. Your suggested solution is the correct one. Rick On Wed, Oct 29, 2008 at 10:42 AM, Mark Miesfeld <mie...@gm...> wrote: > This test case for random currently has an off by 1 failure. I'm not > sure if it is the test case or the interpreter. I think the > interpreter, but I'm not completely sure: > > ::method testRandom11 > r = random(0, 999999999) > > [error] [20081029 07:31:33.027000] > svn: r3584 Change date: 2008-10-21 14:05:04 -0700 > Test: TESTRANDOM11 > Class: RANDOM.testGroup > File: C:\work.ooRexx\ooTest\4.x\ooRexx\base\bif\RANDOM.testGroup > Event: [SYNTAX 40.32] raised unexpectedly. > RANDOM difference between argument 1 ("0") and argument 2 > ("999999999") must not exceed 999,999,999 > Line: 166 > 166 *-* r = random(0, 999999999) > > The interpreter has this code: > > /* too big of a spread ? */ > if (maximum - minimum >= MAX_DIFFERENCE) > { > /* this is an error */ > reportException(Error_Incorrect_call_random_range, randmin, randmax); > } > > which I think needs to be just greater than, from the wording of the > error message. > > /* too big of a spread ? */ > if (maximum - minimum > MAX_DIFFERENCE) > { > /* this is an error */ > reportException(Error_Incorrect_call_random_range, randmin, randmax); > } > > -- > Mark Miesfeld > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > Build the coolest Linux based applications with Moblin SDK & win great prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > _______________________________________________ > Oorexx-devel mailing list > Oor...@li... > https://lists.sourceforge.net/lists/listinfo/oorexx-devel > |