I will leave this up to the developers to decide if this RFE should be accepted. There is another means of determining this information using the winsystm.cls; however, a bug in that class (already reported) means that the user must explicitly load the external functions.
Personally, I still think these methods would be a nice addition to ooDialog even though the same thing can be achieved in multiple lines of code using the winsystm.cls
if RxFuncAdd("InstWinSysFuncs","RXWINSYS.DLL","InstWinSysFuncs") = 0 then
call InstWinSysFuncs
winObj = .WindowObject~new(handle)
state = winObj~state~translate
if state~wordPos('MINIMIZED') > 0 then
isMinimized = .true
else
isMinimized = .false
if state~wordPos('ZOOMED') > 0 then
isMaximized = .true
else
isMaximized = .false
Lee
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I think it makes sense to have this functionality in ooDialog.
It seems to me:
As users write more sophisticated ooDialog applications the functionality of being able to determine if the dialog is minimized or maximized is needed.
It seems more intuitive that, when writing ooDialog applications, there would be an ooDialog method to get the state of the dialog window.
It would be very little overhead to add the functionality to the ooDialog DLL and then the user would not have to load two separate DLLs and use an extra requires directive in their ooDialog.
Of course it makes the overall Windows ooRexx package slightly bigger because you have a few lines of duplicate code.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Thanks Mark & Rick for the words of "support". In my particular case I was already requiring the winsystm.cls so that I had access to the clipboard; however, that would not be the norm for most ooDialog programs.
I'd be most interested when this is accomplished to know what files were modified so that I can use the SVN compare to see what changes were made - never know, I might even learn something about C programming. :-)
Lee
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
This commit adds the isMaximized and isMinimized methods to the PlainBaseDialog class. It also adds the related methods isVisable and isEnabled to the WindowBase mixin class.
That gives all dialogs the isMaximized and isMinimized methods and gives all dialogs and dialog controls the isVisible and isEnabled methods.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Logged In: YES
user_id=1223125
Originator: YES
I will leave this up to the developers to decide if this RFE should be accepted. There is another means of determining this information using the winsystm.cls; however, a bug in that class (already reported) means that the user must explicitly load the external functions.
Personally, I still think these methods would be a nice addition to ooDialog even though the same thing can be achieved in multiple lines of code using the winsystm.cls
if RxFuncAdd("InstWinSysFuncs","RXWINSYS.DLL","InstWinSysFuncs") = 0 then
call InstWinSysFuncs
winObj = .WindowObject~new(handle)
state = winObj~state~translate
if state~wordPos('MINIMIZED') > 0 then
isMinimized = .true
else
isMinimized = .false
if state~wordPos('ZOOMED') > 0 then
isMaximized = .true
else
isMaximized = .false
Lee
Logged In: YES
user_id=191588
Originator: NO
I think it makes sense to have this functionality in ooDialog.
It seems to me:
As users write more sophisticated ooDialog applications the functionality of being able to determine if the dialog is minimized or maximized is needed.
It seems more intuitive that, when writing ooDialog applications, there would be an ooDialog method to get the state of the dialog window.
It would be very little overhead to add the functionality to the ooDialog DLL and then the user would not have to load two separate DLLs and use an extra requires directive in their ooDialog.
Of course it makes the overall Windows ooRexx package slightly bigger because you have a few lines of duplicate code.
Logged In: YES
user_id=1125291
Originator: NO
I believe these methods should be added also. This function belongs as part of the base class rather than achieved in a back-door fashion.
Logged In: YES
user_id=1223125
Originator: YES
Thanks Mark & Rick for the words of "support". In my particular case I was already requiring the winsystm.cls so that I had access to the clipboard; however, that would not be the norm for most ooDialog programs.
I'd be most interested when this is accomplished to know what files were modified so that I can use the SVN compare to see what changes were made - never know, I might even learn something about C programming. :-)
Lee
Logged In: YES
user_id=191588
Originator: NO
Sending platform\windows\oodialog\oovutil.c
Sending platform\windows\oodialog\oovutil.def
Sending platform\windows\oodialog\plbdlg.cls
Transmitting file data ...
Committed revision 797.
This commit adds the isMaximized and isMinimized methods to the PlainBaseDialog class. It also adds the related methods isVisable and isEnabled to the WindowBase mixin class.
That gives all dialogs the isMaximized and isMinimized methods and gives all dialogs and dialog controls the isVisible and isEnabled methods.