#358 ooDialog - MessageExtensions methods ignore errors

[Mark Miesfeld]

The ConnectXXX methods in the ooDialog MessageExtensions class are failing to check the return of self~AddUserMsg.

Because of this the methods are failing to return detectable errors to the caller of the methods.

In addition, the docs state for all of these methods that "This method does not return a value" when the methods do in fact return a value. The methods currently return 0 on success and -1 on some of the detectable errors.

The methods themselves need to return all detectable error codes and the docs need to be updated to correctly identify the return codes.

[Mark Miesfeld]

Logged In: YES
user_id=191588
Originator: YES

Committed revision 610.

This commit fixes the code so that all the ConnectXXX methods in the MessageExtensions class return the same, consistent code.

0 on success
-1 if the resource ID could not be resovled or an incorrect keyword was used.
1 if the underlying C function detected an error. (Max message table reached, the message is invalid, no dialog admin, etc..)

Leaving this open until I update the docs.

[Mark Miesfeld]

Logged In: YES
user_id=191588
Originator: YES

Committed revision 612.

This commit updates the ooDialog documentation to reflect the return codes for the MessageExtensions class.