#580 Finderinfo is destroyed when doing "rsync -E"

[HAT]

Finderinfo is destroyed when doing "rsync -E"

Finderinfo is destroyed when transmitting the file with FinderInfo and ResourceFork to Netatalk 3.1.6 from OS X 10.9.5 using "rsync -E".

$ cd /Users/hat/Desktop/rsync_test/

$ xattr ICONandEA.txt
com.apple.FinderInfo
com.apple.ResourceFork

$ xattr -p com.apple.FinderInfo ICONandEA.txt
54 45 58 54 63 45 64 31 05 0C 04 55 00 81 00 00
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00

$ /usr/bin/rsync -avE -8 --delete /Users/hat/Desktop/rsync_test/ /Volumes/hat/test
building file list ... done
./
.DS_Store
._.DS_Store
ICONandEA.txt
._ICONandEA.txt

sent 11912 bytes  received 114 bytes  8017.33 bytes/sec
total size is 6373  speedup is 0.53

$ cd /Volumes/hat/test/

$ xattr -p com.apple.FinderInfo ICONandEA.txt
00 00 00 00 00 00 00 00 05 0C 04 55 00 81 00 00
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00

logfile:

Oct 01 01:05:26.746985 afpd[1652] {filedir.c:208} (error:AFPDaemon): check_name: illegal name: '._ICONandEA.txt'
Oct 01 01:05:26.747178 afpd[1652] {filedir.c:208} (error:AFPDaemon): check_name: illegal name: '._ICONandEA.txt'
Oct 01 01:05:26.750267 afpd[1652] {ad_flush.c:320} (error:Default): sys_fsetxattr(ad_data_fileno(ad), AD_EA_META, ad->ad_data, AD_DATASZ_EA, 0) failed: Permission denied
Oct 01 01:05:26.753804 afpd[1652] {filedir.c:208} (error:AFPDaemon): check_name: illegal name: '._ICONandEA.txt'
Oct 01 01:05:26.753969 afpd[1652] {filedir.c:208} (error:AFPDaemon): check_name: illegal name: '._ICONandEA.txt'
Oct 01 01:05:26.757874 afpd[1652] {ad_flush.c:320} (error:Default): sys_fsetxattr(ad_data_fileno(ad), AD_EA_META, ad->ad_data, AD_DATASZ_EA, 0) failed: Permission denied

There is no problem when the file without ResourceFork is transmitted.

The filename "._ICONandEA.txt" seems to conflict.

[Daniel Markstedt]

Fixed in https://github.com/Netatalk/netatalk/pull/1702; will be part of a future 4.0.4 release.