Thread: [Mplayerplug-in-devel] [PATCH] fix for apple/trailers crash
Brought to you by:
kdekorte
From: Avi R. <avi...@gm...> - 2009-05-02 18:05:10
Attachments:
signature.asc
apple-trailers-crash.patch
|
Hi, Since the beginning of last month I can't access any movie trailer on apple.com - I get a segmentation fault as soon as the link to the .mov file is accessed. For reference: I'm running Debian/testing, Iceweasel 3.0.9 (unbranded firefox), Debian packaged v 3.55 of mplayer plugin, and mplayer 1.0.rc2svn20090412 (packaged by debian-multimedia.org). This seems to have already been reported as Ubuntu bug #360222 [1], and Arch Linux bug #14155 [2]. I get the following typical output when running from a terminal: ADDED URL: harrypotterhalfbloodprince-tlr4b_h640w.mov code: 42 speed -1 and then the segfault. I used this text as a starting point for debugging and luck was on my side :-) The crash happens at plugin-list.cpp, line 414, during the call to memmem. The cause is a typo in the exit condition at line 411 - 'p' appears instead of 'buffer' (see attached patch), so that we get to line 414 even if there's no next "rmda" (consider lines 348, 418). All line numbers refer to the code from the daily snapshot. I'm guessing that something must have changed at apple.com to trigger this specific code path. In any case, the patched plugin seems to work nicely at my end. Cheers, Avi. [1] https://bugs.launchpad.net/bugs/360222 [2] http://bugs.archlinux.org/task/14155 |
From: Kevin D. <kde...@gm...> - 2009-05-02 19:54:41
|
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 05/02/2009 12:04 PM, Avi Rozen wrote: > Hi, > > Since the beginning of last month I can't access any movie trailer on > apple.com - I get a segmentation fault as soon as the link to the .mov > file is accessed. > > For reference: I'm running Debian/testing, Iceweasel 3.0.9 (unbranded > firefox), Debian packaged v 3.55 of mplayer plugin, and mplayer > 1.0.rc2svn20090412 (packaged by debian-multimedia.org). > > This seems to have already been reported as Ubuntu bug #360222 [1], and > Arch Linux bug #14155 [2]. > > I get the following typical output when running from a terminal: > > ADDED URL: harrypotterhalfbloodprince-tlr4b_h640w.mov > code: 42 > speed -1 > > and then the segfault. > > I used this text as a starting point for debugging and luck was on my > side :-) > > The crash happens at plugin-list.cpp, line 414, during the call to > memmem. The cause is a typo in the exit condition at line 411 - 'p' > appears instead of 'buffer' (see attached patch), so that we get to line > 414 even if there's no next "rmda" (consider lines 348, 418). All line > numbers refer to the code from the daily snapshot. > > I'm guessing that something must have changed at apple.com to trigger > this specific code path. In any case, the patched plugin seems to work > nicely at my end. > > Cheers, > Avi. > > [1] https://bugs.launchpad.net/bugs/360222 > [2] http://bugs.archlinux.org/task/14155 Avi, Can you please provide a sample site that I can test with. I'm using mplayerplug-in from CVS and I don't see any crashes with the Apple site... I tried "the international" and "17 again" trailers. Also, have you tried gecko-mediaplayer? Kevin - -- Get my public GnuPG key from http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x7D0BD5D1 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAkn8pPEACgkQ6w2kMH0L1dFHbQCeMy5cyqnxax/sljJBZT0ehOIg IyIAnRF7Wv4lMXp37inU7euvZBh95ueG =kxry -----END PGP SIGNATURE----- |
From: Avi R. <avi...@gm...> - 2009-05-02 20:41:07
Attachments:
signature.asc
|
Kevin DeKorte wrote: > Avi, > > Can you please provide a sample site that I can test with. I'm using > mplayerplug-in from CVS and I don't see any crashes with the Apple > site... I tried "the international" and "17 again" trailers. > Both crash on my end (official Debian mozilla-mplayer package 3.55-1.1) without the patch. Both play with the patch applied (I applied the patch to the Debian package source code). > Also, have you tried gecko-mediaplayer? I was not aware of it. I was rather happy with mplayerplug-in. Is it dead? Debian has gecko-mediaplayer 0.9.5-1 and it plays both trailers. Is there a way to cache the whole clip before playback? my connection is rather flaky when it comes to streaming video. Looks like it's time to switch... Thanks, Avi |
From: Kevin D. <kde...@gm...> - 2009-05-02 22:25:37
|
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 05/02/2009 02:41 PM, Avi Rozen wrote: > Kevin DeKorte wrote: >> Avi, >> >> Can you please provide a sample site that I can test with. I'm using >> mplayerplug-in from CVS and I don't see any crashes with the Apple >> site... I tried "the international" and "17 again" trailers. >> > > Both crash on my end (official Debian mozilla-mplayer package 3.55-1.1) > without the patch. > Both play with the patch applied (I applied the patch to the Debian > package source code). > Can you please try with CVS? I don't know what patches are applied to the Debian packages >> Also, have you tried gecko-mediaplayer? > > I was not aware of it. I was rather happy with mplayerplug-in. Is it dead? > > Debian has gecko-mediaplayer 0.9.5-1 and it plays both trailers. Is > there a way to cache the whole clip before playback? my connection is > rather flaky when it comes to streaming video. > > Looks like it's time to switch... Yes, mplayerplug-in is depreciated, I shutdown new development on it about 24 months ago and all new effort has been on gecko-mediaplayer. http://kdekorte.blogspot.com/2007/02/mplayerplug-in-being-changed-to-gecko.html Kevin - -- Get my public GnuPG key from http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x7D0BD5D1 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAkn8yFsACgkQ6w2kMH0L1dHLEACeJ19c0G90P6lqgSRIusa/aAU5 63MAn24QqEjOH6V9g3RZrVeeR/vAlca0 =Vq8q -----END PGP SIGNATURE----- |
From: Kevin D. <kde...@gm...> - 2009-05-03 13:05:54
|
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 05/03/2009 03:59 AM, Avi Rozen wrote: > Kevin DeKorte wrote: >> Can you please try with CVS? I don't know what patches are applied to >> the Debian packages >> > > Tried it. Same results: crashes with a clean CVS build, plays with my > patch applied. > > Cheers, > Avi. > > BTW you can browse the Debian patches here: > http://patch-tracking.debian.net/package/mplayerplug-in/3.55-1.1 Can you please post the backtrace? And the verbose log of mplayerplug-in crashing. Unless I can duplicate the crash, I really don't want to merge the patch in. Kevin - -- Get my public GnuPG key from http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x7D0BD5D1 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAkn9lqgACgkQ6w2kMH0L1dFiEgCgkywrL8WkkfzAnUJSEoY4Vo9p 3fMAnR3iW2FQB9JisnjtjTlzcwaawrG8 =JCuW -----END PGP SIGNATURE----- |
From: Avi R. <avi...@gm...> - 2009-05-03 13:55:34
|
Kevin DeKorte wrote: > Can you please post the backtrace? And the verbose log of mplayerplug-in > crashing. I've set DEBUG to 3 in plugin-setup.cpp, recompiled (without the fix) and got the attached log messages and backtrace. > > Unless I can duplicate the crash, I really don't want to merge the > patch in. Your call, obviously. But please have a look at it - it's really a minor fix. Avi. |
From: Giuseppe G. <gh...@ma...> - 2009-05-03 13:21:49
|
Kevin DeKorte wrote: > On 05/03/2009 03:59 AM, Avi Rozen wrote: > > Kevin DeKorte wrote: > >> Can you please try with CVS? I don't know what patches are applied to > >> the Debian packages > >> > > Tried it. Same results: crashes with a clean CVS build, plays with my > > patch applied. > > > Cheers, > > Avi. > > > BTW you can browse the Debian patches here: > > http://patch-tracking.debian.net/package/mplayerplug-in/3.55-1.1 > > Can you please post the backtrace? And the verbose log of mplayerplug-in > crashing. > > Unless I can duplicate the crash, I really don't want to merge the > patch in. > > Kevin > > BTW, kevin, sound that mandriva is affected too (curiosly it doesn't happens on 2009.0 so probably depends on something triggered by glibc 2.9), see: See also: https://qa.mandriva.com/show_bug.cgi?id=47207 (there you can find also a valgrind output). Mandriva package is here: http://svn.mandriva.com/cgi-bin/viewvc.cgi/packages/cooker/mplayerplugin/current/ note that some patches from the CVS (e.g. those for threads) were already merged some time ago. Bye Giuseppe. |
From: Kevin D. <kde...@gm...> - 2009-05-03 16:17:24
|
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 05/03/2009 07:21 AM, Giuseppe Ghibò wrote: > Kevin DeKorte wrote: >> On 05/03/2009 03:59 AM, Avi Rozen wrote: >>> Kevin DeKorte wrote: >>>> Can you please try with CVS? I don't know what patches are applied to >>>> the Debian packages >>>> >>> Tried it. Same results: crashes with a clean CVS build, plays with my >>> patch applied. >>> Cheers, >>> Avi. >>> BTW you can browse the Debian patches here: >>> http://patch-tracking.debian.net/package/mplayerplug-in/3.55-1.1 >> Can you please post the backtrace? And the verbose log of mplayerplug-in >> crashing. >> >> Unless I can duplicate the crash, I really don't want to merge the >> patch in. >> >> Kevin >> >> > BTW, kevin, sound that mandriva is affected too (curiosly it doesn't > happens on 2009.0 so probably depends on something triggered by glibc 2.9), > see: I don't think it is glibc 2.9, cause my Fedora 11 box works just fine without the patch. I still would like to see a backtrace and then do "up" to have it show the line that it is crashed on. The patch changes the logic of what is being checked a little, and so I want to make sure that we are actually going to the next item and not restarting back at the first item on the list. That is my only concern with the patch. Kevin - -- Get my public GnuPG key from http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x7D0BD5D1 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAkn9w4QACgkQ6w2kMH0L1dECmQCeL3vnkwHhABx/qkQAIb2rXNxY zD4AoIRe5XNs2T0GRtT2P/2kYWSh8iFp =easP -----END PGP SIGNATURE----- |
From: Kevin D. <kde...@gm...> - 2009-05-03 16:23:41
|
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 05/03/2009 03:59 AM, Avi Rozen wrote: > Kevin DeKorte wrote: >> Can you please try with CVS? I don't know what patches are applied to >> the Debian packages >> > > Tried it. Same results: crashes with a clean CVS build, plays with my > patch applied. > > Cheers, > Avi. Avi, Can you please retest CVS, I made a patch based on the gecko-mediaplayer code and I want to know if that fixes the problem for you. Thanks, Kevin - -- Get my public GnuPG key from http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x7D0BD5D1 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAkn9xQUACgkQ6w2kMH0L1dGtfACfbR/FPAtLXPgUG5goEHkQNACg Z/kAoItb/iaZEg1AWuEQyLjBmWdM7tdm =dfKc -----END PGP SIGNATURE----- |
From: Avi R. <avi...@gm...> - 2009-05-03 17:15:57
Attachments:
signature.asc
|
Kevin DeKorte wrote: > Avi, > > Can you please retest CVS, I made a patch based on the gecko-mediaplayer > code and I want to know if that fixes the problem for you. Works nicely :-) Thanks. Avi. |
From: Avi R. <avi...@gm...> - 2009-05-03 09:59:48
Attachments:
signature.asc
|
Kevin DeKorte wrote: > > Can you please try with CVS? I don't know what patches are applied to > the Debian packages > Tried it. Same results: crashes with a clean CVS build, plays with my patch applied. Cheers, Avi. BTW you can browse the Debian patches here: http://patch-tracking.debian.net/package/mplayerplug-in/3.55-1.1 |