Thread: [Mplayerplug-in-devel] patch: on remote display, XShm will be disabled
Brought to you by:
kdekorte
From: Yasuhiro M. <mat...@ho...> - 2004-12-29 00:47:25
|
hi, on remote display, XShm will be disabled. thus, mplayer stop when specified -xy (or -x, -y) option. following patch ignore maintain_aspect when x11 is running on remote display. please check and include. thanks. - Yasuhiro Index: Source/plugin-threads.cpp =================================================================== RCS file: /cvsroot/mplayerplug-in/mplayerplug-in/Source/plugin-threads.cpp,v retrieving revision 1.133 diff -c -r1.133 plugin-threads.cpp *** Source/plugin-threads.cpp 14 Dec 2004 16:25:42 -0000 1.133 --- Source/plugin-threads.cpp 29 Dec 2004 00:42:41 -0000 *************** *** 396,403 **** } } if ((instance->embed_width == 0) ! || (instance->noembed == 1)) { // do nothing } else { if (instance->mode == NP_EMBED) { --- 396,418 ---- } } + /* on remote display, XShm will be disabled. + it should not specified aspect. */ + char *dispName = XDisplayName(NULL); + bool isRemoteDisplay = false; + if (dispName) { + if (strncmp(dispName, "unix:", 5) == 0) + dispName += 4; + else if (strncmp(dispName, "localhost:", 10) == 0) + dispName += 9; + if (*dispName != ':' || atoi(dispName + 1) >= 10) { + isRemoteDisplay = true; + printf("x11 is running on remote display.\n"); + } + } + if ((instance->embed_width == 0) ! || (instance->noembed == 1) || isRemoteDisplay) { // do nothing } else { if (instance->mode == NP_EMBED) { |
From: Yasuhiro M. <mat...@ho...> - 2004-12-29 01:04:07
|
hi all. on remote display, XShm will be disabled. thus, mplayer stop when specified -xy (or -x, -y) option. following patch ignore maintain_aspect when x11 is running on remote display. please check and include. thanks. # sorry, i sent broken patch few minutes ago. # if you recieved it, please remove. - Yasuhiro Index: Source/plugin-threads.cpp =================================================================== RCS file: /cvsroot/mplayerplug-in/mplayerplug-in/Source/plugin-threads.cpp,v retrieving revision 1.133 diff -c -r1.133 plugin-threads.cpp *** Source/plugin-threads.cpp 14 Dec 2004 16:25:42 -0000 1.133 --- Source/plugin-threads.cpp 29 Dec 2004 00:56:38 -0000 *************** *** 396,403 **** } } if ((instance->embed_width == 0) ! || (instance->noembed == 1)) { // do nothing } else { if (instance->mode == NP_EMBED) { --- 396,419 ---- } } + /* on remote display, XShm will be disabled. + it should not specified aspect. */ + char *dispName = XDisplayName(NULL); + bool isRemoteDisplay = false; + if (dispName) { + if (strncmp(dispName, "unix:", 5) == 0) + dispName += 4; + else if (strncmp(dispName, "localhost:", 10) == 0) + dispName += 9; + if (*dispName != ':' || atoi(dispName + 1) >= 10) { + isRemoteDisplay = true; + if (DEBUG) + printf("x11 is running on remote display.\n"); + } + } + if ((instance->embed_width == 0) ! || (instance->noembed == 1) || isRemoteDisplay) { // do nothing } else { if (instance->mode == NP_EMBED) { |
From: Kevin D. <kde...@ya...> - 2004-12-29 01:35:54
|
Yasuhiro, I have applied a form of this patch to the code. Search for "-xy" in=20 plugin-threads.cpp after I commit the changes to CVS to see the change that= I=20 made. Kevin On Tuesday 28 December 2004 05:46 pm, Yasuhiro Matsumoto wrote: > hi, > > on remote display, XShm will be disabled. > thus, mplayer stop when specified -xy (or -x, -y) option. > > following patch ignore maintain_aspect when x11 is running > on remote display. > > please check and include. > thanks. > > - Yasuhiro > > Index: Source/plugin-threads.cpp > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: > /cvsroot/mplayerplug-in/mplayerplug-in/Source/plugin-threads.cpp,v > retrieving revision 1.133 > diff -c -r1.133 plugin-threads.cpp > *** Source/plugin-threads.cpp 14 Dec 2004 16:25:42 -0000 1.133 > --- Source/plugin-threads.cpp 29 Dec 2004 00:42:41 -0000 > *************** > *** 396,403 **** > } > } > > if ((instance->embed_width =3D=3D 0) > ! || (instance->noembed =3D=3D 1)) { > // do nothing > } else { > if (instance->mode =3D=3D NP_EMBED) { > --- 396,418 ---- > } > } > > + /* on remote display, XShm will be disabled. > + it should not specified aspect. */ > + char *dispName =3D XDisplayName(NULL); > + bool isRemoteDisplay =3D false; > + if (dispName) { > + if (strncmp(dispName, "unix:", 5) =3D=3D 0) > + dispName +=3D 4; > + else if (strncmp(dispName, "localhost:", 10) =3D=3D 0) > + dispName +=3D 9; > + if (*dispName !=3D ':' || atoi(dispName + 1) >=3D 10) { > + isRemoteDisplay =3D true; > + printf("x11 is running on remote display.\n"); > + } > + } > + > if ((instance->embed_width =3D=3D 0) > ! || (instance->noembed =3D=3D 1) || isRemoteDisplay) { > // do nothing > } else { > if (instance->mode =3D=3D NP_EMBED) { > > > ------------------------------------------------------- > SF email is sponsored by - The IT Product Guide > Read honest & candid reviews on hundreds of IT Products from real users. > Discover which products truly live up to the hype. Start reading now. > http://productguide.itmanagersjournal.com/ > _______________________________________________ > Mplayerplug-in-devel mailing list > Mpl...@li... > https://lists.sourceforge.net/lists/listinfo/mplayerplug-in-devel |