Thread: [Mplayerplug-in-devel] bugs
Brought to you by:
kdekorte
From: John M. <tt...@te...> - 2004-10-25 01:22:05
|
Check out this link, it seems to have two windows (I am guessing one is supposed to be just controls). This is really annoying. http://www.bbc.co.uk/cult/farscape/interviews/raeleehill.shtml Also, with xinerama, the fullscreen window always pops up on the first screen, with totem, is based on the screen that the window is in. -- John McCutchan <tt...@te...> |
From: John M. <tt...@te...> - 2004-11-30 22:27:52
|
Hi, -When you pause videos from here, then unpause them they aren't right. http://www.comedycentral.com/tv_shows/thedailyshowwithjonstewart/videos.jhtml -The background should be black not the background color. All other movie players and plugins do it this way. -When xinerama is enabled, and you press fullscreen button, it always fullscreens on the first screen, it should fullscreen on whatever screen the browser is on. -When in fullscreen mode, the window title is just "Galeon ". It should say MplayerPlug-in or the url or something... Thanks for all your hard work. -- John McCutchan <tt...@te...> |
From: Kevin D. <kde...@ya...> - 2004-11-30 22:49:39
|
John, Pause and unpause is controlled by mplayer. Need to have it fixed there Are you using GTK1 or GTK2 widgets? In GTK1, yes the background color is wrong and xinerama is not supported by= =20 the GTK1 tool kit.=20 In GTK2, the background color should be right, it is on my machine. Also, I= =20 have copied code from totem and xinerama support is enabled. However, I=20 cannot confirm as I don't have a machine with xinerama support and when I d= id=20 do fixes for you last time, I never got an answer back if it worked or not. As for the fullscreen mode not working properly, what window manager are yo= u=20 using. Recently a bug was found the caused the fullscreen mode to be drawn= =20 incorrectly when e 16.6 was used. Upgrading to 16.7 of e fixed the problem.= I=20 use KDE and I see none of these errors. There should be no window title at= =20 all. Kevin On Tuesday 30 November 2004 03:27 pm, John McCutchan wrote: > Hi, > > -When you pause videos from here, then unpause them they aren't right. > > http://www.comedycentral.com/tv_shows/thedailyshowwithjonstewart/videos.j= ht >ml > > -The background should be black not the background color. All other > movie players and plugins do it this way. > > -When xinerama is enabled, and you press fullscreen button, it always > fullscreens on the first screen, it should fullscreen on whatever screen > the browser is on. > > -When in fullscreen mode, the window title is just "Galeon ". It should > say MplayerPlug-in or the url or something... > > Thanks for all your hard work. |
From: John M. <tt...@te...> - 2004-12-01 03:10:19
|
On Tue, 2004-11-30 at 15:47 -0700, Kevin DeKorte wrote: > John, > > Pause and unpause is controlled by mplayer. Need to have it fixed there > I kind of figured that.. I have tried filing bugs with mplayer before and I was ignored.. I guess I will just have to wait until someone fixes pausing with mms streams. > Are you using GTK1 or GTK2 widgets? > GTK2 > In GTK1, yes the background color is wrong and xinerama is not supported by > the GTK1 tool kit. > > In GTK2, the background color should be right, it is on my machine. Also, I > have copied code from totem and xinerama support is enabled. However, I > cannot confirm as I don't have a machine with xinerama support and when I did > do fixes for you last time, I never got an answer back if it worked or not. The background color is the themes background color, not black. All video players and video playing browser plugins use a black background for the video window. And it looks nicer. MPP-I should change the background color to be black. Or at the very least add a preference. Xinerama works really well except for this one problem. You must have missed something in the totem code, because the fullscreen window opens in whatever screen totem is on. > > As for the fullscreen mode not working properly, what window manager are you > using. Recently a bug was found the caused the fullscreen mode to be drawn > incorrectly when e 16.6 was used. Upgrading to 16.7 of e fixed the problem. I > use KDE and I see none of these errors. There should be no window title at > all. > Fullscreen mode works properly. The bug is really just a minor detail, I have two monitors, so when I am watching something fullscreened in MPP-I I can see my task bar. The Window name of the fullscreen window is just "Galeon", I think it should be "Galeon - MPlayerPlug-In Fullscreened" or something.. -- John McCutchan <tt...@te...> |
From: Kevin D. <kde...@ya...> - 2004-12-01 15:21:25
|
John, Ok I think I have fixed the things I can in the current CVS code. =46or GTK2 I have set the window title I believe I have it going to the correct Xinerama subscreen, I'm going to= =20 need you to test this for me And the border in fullscreen mode is now black. I don't know what changed,= =20 but this used to work fine. So I found another way to change it and it is=20 definately black on my machine now. Kevin On Tuesday 30 November 2004 08:10 pm, John McCutchan wrote: > On Tue, 2004-11-30 at 15:47 -0700, Kevin DeKorte wrote: > > John, > > > > Pause and unpause is controlled by mplayer. Need to have it fixed there > > I kind of figured that.. I have tried filing bugs with mplayer before > and I was ignored.. I guess I will just have to wait until someone fixes > pausing with mms streams. > > > Are you using GTK1 or GTK2 widgets? > > GTK2 > > > In GTK1, yes the background color is wrong and xinerama is not supported > > by the GTK1 tool kit. > > > > In GTK2, the background color should be right, it is on my machine. Als= o, > > I have copied code from totem and xinerama support is enabled. However,= I > > cannot confirm as I don't have a machine with xinerama support and when= I > > did do fixes for you last time, I never got an answer back if it worked > > or not. > > The background color is the themes background color, not black. All > video players and video playing browser plugins use a black background > for the video window. And it looks nicer. MPP-I should change the > background color to be black. Or at the very least add a preference. > > > Xinerama works really well except for this one problem. You must have > missed something in the totem code, because the fullscreen window opens > in whatever screen totem is on. > > > As for the fullscreen mode not working properly, what window manager are > > you using. Recently a bug was found the caused the fullscreen mode to be > > drawn incorrectly when e 16.6 was used. Upgrading to 16.7 of e fixed the > > problem. I use KDE and I see none of these errors. There should be no > > window title at all. > > Fullscreen mode works properly. The bug is really just a minor detail, I > have two monitors, so when I am watching something fullscreened in MPP-I > I can see my task bar. The Window name of the fullscreen window is just > "Galeon", I think it should be "Galeon - MPlayerPlug-In Fullscreened" or > something.. |
From: John M. <tt...@te...> - 2004-12-01 18:19:50
|
On Wed, 2004-12-01 at 08:21 -0700, Kevin DeKorte wrote: > John, > > Ok I think I have fixed the things I can in the current CVS code. > > For GTK2 > > I have set the window title Works thanks. > I believe I have it going to the correct Xinerama subscreen, I'm going to > need you to test this for me Doesn't work. > And the border in fullscreen mode is now black. I don't know what changed, > but this used to work fine. So I found another way to change it and it is > definately black on my machine now. Okay, this doesn't work now. The fullscreen window has a gray background -- I think it used to be black. This was a miscommunication I want both the fullscreen and non-fullscreen window to be black. -- John McCutchan <tt...@te...> |
From: Kevin D. <kde...@ya...> - 2004-12-01 19:08:58
|
John, Ok, I need a little more info about the Xinerama problem... screen shot wou= ld=20 be good. Preferrably with annotations so I know what is wrong and what is=20 expected. Also, for the player window... I am NOT going to change the background to=20 black when in normal mode... Read the archives why. This has been a=20 discussion that has went on since the first version of the player. =46or the full screen mode. I have made some changes here that should fix t= he=20 black borders in full screen mode. I'll commit it to CVS here in moment. Kevin On Wednesday 01 December 2004 11:19 am, John McCutchan wrote: > On Wed, 2004-12-01 at 08:21 -0700, Kevin DeKorte wrote: > > John, > > > > Ok I think I have fixed the things I can in the current CVS code. > > > > For GTK2 > > > > I have set the window title > > Works thanks. > > > I believe I have it going to the correct Xinerama subscreen, I'm going > > to need you to test this for me > > Doesn't work. > > > And the border in fullscreen mode is now black. I don't know what > > changed, but this used to work fine. So I found another way to change it > > and it is definately black on my machine now. > > Okay, this doesn't work now. The fullscreen window has a gray background > -- I think it used to be black. This was a miscommunication I want both > the fullscreen and non-fullscreen window to be black. |
From: John M. <tt...@te...> - 2004-12-01 19:54:01
|
On Wed, 2004-12-01 at 12:08 -0700, Kevin DeKorte wrote: > John, > > Ok, I need a little more info about the Xinerama problem... screen shot would > be good. Preferrably with annotations so I know what is wrong and what is > expected. > Okay, I will make an attempt at an ascii drawing 1 2 +----+---+ | B | | +----+---+ B = Browser window In the above state, when you press fullscreen you get this: 1 2 +---+---+ | F | | +---+---+ F = Fullscreened Window The above is correct. The below is incorrect. 1 2 +----+---+ | | B | +----+---+ Press fullscreen: 1 2 +---+---+ | F | | +---+---+ It should be: 1 2 +---+---+ | | F | +---+---+ > Also, for the player window... I am NOT going to change the background to > black when in normal mode... Read the archives why. This has been a > discussion that has went on since the first version of the player. I don't understand your reasoning. All video browser plugins on windows, use black as the background color. As well, all video players that I have ever seen use a black background. In all real life situations, the border around a video is black. In the theatre and on a television. Just because a toolkit has the notion of a default background color doesn't mean it makes sense in all cases! What about _atleast_ adding a preference? -- John McCutchan <tt...@te...> |
From: Kevin D. <kde...@ya...> - 2004-12-02 00:49:50
|
John, I made a patch to CVS that might fix the Xinerama screen position problem. Kevin On Wednesday 01 December 2004 12:53 pm, John McCutchan wrote: > On Wed, 2004-12-01 at 12:08 -0700, Kevin DeKorte wrote: > > John, > > > > Ok, I need a little more info about the Xinerama problem... screen shot > > would be good. Preferrably with annotations so I know what is wrong and > > what is expected. > > Okay, I will make an attempt at an ascii drawing > > 1 2 > +----+---+ > > | B | | > > +----+---+ > > B = Browser window > > In the above state, when you press fullscreen you get this: > > 1 2 > +---+---+ > > | F | | > > +---+---+ > > F = Fullscreened Window > > > The above is correct. The below is incorrect. > > 1 2 > +----+---+ > > | | B | > > +----+---+ > > Press fullscreen: > > 1 2 > +---+---+ > > | F | | > > +---+---+ > > > It should be: > > 1 2 > +---+---+ > > | | F | > > +---+---+ > |
From: Kevin D. <kde...@ya...> - 2004-12-01 21:25:52
|
John, Ok I see what the xinerama issue is. The totem code is no help, so I'm doin= g=20 some more research. As for the black background... I'm going to make a config option for this.= =20 black-background=3D1 It looks ugly, but it seems to work.. I have followed the GTK2 programming= =20 guide to implement it.=20 My reasoning is simple, people pick their colors and I should respect that= =20 choice. Think of someone with contrast issues or color-blindness and you'll= =20 see why hardcoding colors is bad. I have personally worked with someone who= =20 is color blind and I could not stand to look at his screen, but he could no= t=20 read mine, which is normally black, white and blue. I've even had complaint= s=20 that the buttons are too small for some people. So there are a lot of visua= l=20 issues. Just because black is the standard does not mean it is always the=20 right choice. And BTW on some widescreen TVs, the boarders are grey by=20 default, not black. Kevin On Wednesday 01 December 2004 12:53 pm, John McCutchan wrote: > On Wed, 2004-12-01 at 12:08 -0700, Kevin DeKorte wrote: > > John, > > > > Ok, I need a little more info about the Xinerama problem... screen shot > > would be good. Preferrably with annotations so I know what is wrong and > > what is expected. > > Okay, I will make an attempt at an ascii drawing > > 1 2 > +----+---+ > > | B | | > > +----+---+ > > B =3D Browser window > > In the above state, when you press fullscreen you get this: > > 1 2 > +---+---+ > > | F | | > > +---+---+ > > F =3D Fullscreened Window > > > The above is correct. The below is incorrect. > > 1 2 > +----+---+ > > | | B | > > +----+---+ > > Press fullscreen: > > 1 2 > +---+---+ > > | F | | > > +---+---+ > > > It should be: > > 1 2 > +---+---+ > > | | F | > > +---+---+ > > > Also, for the player window... I am NOT going to change the background = to > > black when in normal mode... Read the archives why. This has been a > > discussion that has went on since the first version of the player. > > I don't understand your reasoning. All video browser plugins on windows, > use black as the background color. As well, all video players that I > have ever seen use a black background. In all real life situations, the > border around a video is black. In the theatre and on a television. Just > because a toolkit has the notion of a default background color doesn't > mean it makes sense in all cases! > > What about _atleast_ adding a preference? |
From: John M. <tt...@te...> - 2004-12-02 01:50:43
|
On Wed, 2004-12-01 at 14:25 -0700, Kevin DeKorte wrote: > It looks ugly, but it seems to work.. I have followed the GTK2 programming > guide to implement it. > Yes it does look ugly. But only the logo, which has white/gray around it. What about the new logo that was posted on the list recently? Blending a new logo with alpha in it would look excellent no matter what the background color. > My reasoning is simple, people pick their colors and I should respect that > choice. Think of someone with contrast issues or color-blindness and you'll > see why hardcoding colors is bad. I have personally worked with someone who > is color blind and I could not stand to look at his screen, but he could not > read mine, which is normally black, white and blue. I've even had complaints > that the buttons are too small for some people. So there are a lot of visual > issues. Just because black is the standard does not mean it is always the > right choice. And BTW on some widescreen TVs, the boarders are grey by > default, not black. I am fine with this, now that there is an option. -- John McCutchan <tt...@te...> |
From: Kevin D. <kde...@ya...> - 2004-10-25 18:00:39
|
Fixed in CVS Kevin On Sunday 24 October 2004 07:24 pm, John McCutchan wrote: > Check out this link, it seems to have two windows (I am guessing one is > supposed to be just controls). This is really annoying. > > http://www.bbc.co.uk/cult/farscape/interviews/raeleehill.shtml > > Also, with xinerama, the fullscreen window always pops up on the first > screen, with totem, is based on the screen that the window is in. |