Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#3 Rename get_cp_from_locale() to get_codepage

closed-fixed
NightStrike
None
5
2008-04-28
2008-04-26
NightStrike
No

This is part of the 3.10 to 3.11 update. Danny Smith did the change to 3.11 on September 1st, 2006. I don't know why it was done.. I'm just porting it.

Discussion

  • NightStrike
    NightStrike
    2008-04-26

    Rename all get_cp_from_locale references to get_codepage

     
  • NightStrike
    NightStrike
    2008-04-26

    Logged In: YES
    user_id=1864092
    Originator: YES

    Updated patch to include the rewrite of the get_codepage() method, not just renaming it.
    File Added: get_codepage.patch.txt

     
  • Kai Tietz
    Kai Tietz
    2008-04-26

    Logged In: YES
    user_id=1598680
    Originator: NO

    Ok, this patch is fine. You can apply.

    Cheers,
    Kai

     
  • Kai Tietz
    Kai Tietz
    2008-04-26

    • assigned_to: nobody --> nightstrike
    • status: open --> open-accepted
     
  • Kai Tietz
    Kai Tietz
    2008-04-27

    • status: open-accepted --> closed-fixed
     
  • Kai Tietz
    Kai Tietz
    2008-04-27

    Logged In: YES
    user_id=1598680
    Originator: NO

    Committed revision 380.

     
  • NightStrike
    NightStrike
    2008-04-28

    Logged In: YES
    user_id=1864092
    Originator: YES

    Comment from Danny:

    The cephes string-to-float conversion functions were replaced with faster and more flexible versions from Davod Gay's gdtoa package. As part of that, strtof and wcstof became real functions, not just truncations of the double versions.

     
  • NightStrike
    NightStrike
    2008-04-28

    • status: closed-fixed --> open-fixed
     
  • NightStrike
    NightStrike
    2008-04-28

    • status: open-fixed --> closed-fixed