From: Li M. <mi...@mp...> - 2000-09-15 13:35:41
|
This data structure struct display_list_compilation { struct display_list *list; union node *current_block; GLuint current_pos; }; which defined in the dlist.h seems to be no use any more. I can't grep "display_list_compilation" in any other source files. After I read the function static Node *alloc_instruction( GLcontext *ctx, OpCode opcode, GLint argcount ), I find this link operation now is taken over by GLcontext. This can be inferred from the following code snippet: n = ctx->CurrentBlock + ctx->CurrentPos; n[0].opcode = OPCODE_CONTINUE; newblock = (Node *) MALLOC( sizeof(Node) * BLOCK_SIZE ); if (!newblock) { gl_error( ctx, GL_OUT_OF_MEMORY, "Building display list" ); return NULL; } n[1].next = (Node *) newblock; ctx->CurrentBlock = newblock; ctx->CurrentPos = 0; Am I right? -Li Ming |
From: Brian P. <br...@va...> - 2000-09-15 17:04:06
|
Li Ming wrote: > > This data structure > > struct display_list_compilation { > struct display_list *list; > union node *current_block; > GLuint current_pos; > }; > > which defined in the dlist.h seems to be no use any more. > I can't grep "display_list_compilation" in any other source files. I'll remove this since it's unused. > After I read the function > static Node *alloc_instruction( GLcontext *ctx, OpCode opcode, GLint > argcount ), > > I find this link operation now is taken over by GLcontext. This can be > inferred from > the following code snippet: > > n = ctx->CurrentBlock + ctx->CurrentPos; > n[0].opcode = OPCODE_CONTINUE; > newblock = (Node *) MALLOC( sizeof(Node) * BLOCK_SIZE ); > if (!newblock) { > gl_error( ctx, GL_OUT_OF_MEMORY, "Building display list" ); > return NULL; > } > n[1].next = (Node *) newblock; > ctx->CurrentBlock = newblock; > ctx->CurrentPos = 0; > > Am I right? This code has been in place for a long time, longer I bet than the display_list_compilation struct. -Brian |