Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#115 Check return codes everywhere

open
GI
None
5
2007-04-13
2007-02-12
Markus Elfring
No

Some checks for return codes are missing.

Examples:
Would you like to add more error handling for return values from "write" like in the function "rxvt_update_lastlog" and from "fclose" in the function "PngReadFileToPixmap"?
http://materm.svn.sourceforge.net/viewvc/materm/mrxvt05b/src/logging.c?revision=90&view=markup
http://materm.svn.sourceforge.net/viewvc/materm/mrxvt05b/src/mpng.c?revision=90&view=markup

Discussion

  • GI
    GI
    2007-04-13

    Logged In: YES
    user_id=862337
    Originator: NO

    I'm unclear what you mean. Can you follow up on this on the devel list. If you want to contribute, we'll be happy :).

     
  • Markus Elfring
    Markus Elfring
    2007-04-13

    • assigned_to: nobody --> gi1242
     
  • Markus Elfring
    Markus Elfring
    2007-04-13

    Logged In: YES
    user_id=572001
    Originator: YES

    I suggest to avoid unchecked function calls.

    Would you like to detect every error situation as early as possible?