From: Hannes W. <han...@gm...> - 2006-11-30 13:59:36
Attachments:
keylight.c
Makefile
|
Hello All the following is an alternative to Ludovic Rousseau's keyboard_brigthness shell-script (1). Advantages: - slightly shorter name - allows toggle - can be set SUID and bound to keyboard shortcuts via xbindkeys Let me know what you think! cheers Hannes 1) http://mactel-linux.svn.sourceforge.net/viewvc/mactel-linux/trunk/tools/keyboard_brigthness?view=markup |
From: Ludovic R. <lud...@gm...> - 2006-11-30 15:48:31
|
On 30/11/06, Hannes Wyss <han...@gm...> wrote: > Hello All Hello, > the following is an alternative to Ludovic Rousseau's > keyboard_brigthness shell-script (1). > Advantages: > - slightly shorter name Not relevant if you use xbindkeys. My script is easy to rename :-). You can even rename it as "k" if you like short names. > - allows toggle Good idea. I just implemented it in my script. Now committed in SVN. > - can be set SUID and bound to keyboard shortcuts via xbindkeys Why do you need the SUID bit? On my machine the device is rw for everybody: $ ls -l /sys/class/leds/smc\:kbd_backlight/brightness -rw-rw-rw- 1 root root 4096 2006-11-30 13:04 /sys/class/leds/smc:kbd_backlight/brightness But since you use /var/lib/keylight to store the old value you _have_ to be root to write in /var/lib. My script uses /tmp/keyboard_brigthness_old_value so do not need to be root. > Let me know what you think! Thanks for the idea. My version is 42 lines of shell script. Your version is 113 lines of C (I used sloccount to just count the lines of code). -- Dr. Ludovic Rousseaummm |
From: Hannes W. <han...@gm...> - 2006-11-30 16:22:11
|
On 11/30/06, Ludovic Rousseau <lud...@gm...> wrote: > On 30/11/06, Hannes Wyss <han...@gm...> wrote: > > the following is an alternative to Ludovic Rousseau's > > keyboard_brigthness shell-script (1). > > Advantages: [... indisputable point about "size doesn't matter" conceded :) ...] > Good idea. > I just implemented it in my script. Now committed in SVN. Great, thanks! > > - can be set SUID and bound to keyboard shortcuts via xbindkeys > > Why do you need the SUID bit? On my machine the device is rw for everybody: > $ ls -l /sys/class/leds/smc\:kbd_backlight/brightness > -rw-rw-rw- 1 root root 4096 2006-11-30 13:04 > /sys/class/leds/smc:kbd_backlight/brightness Interesting. Mine isn't (at least not permanently): doubledog hwyss # ls -l /sys/class/leds/smc\:kbd_backlight/brightness -rw-r--r-- 1 root root 4096 2006-11-30 16:58 /sys/class/leds/smc:kbd_backlight/brightness doubledog hwyss # chmod og+w /sys/class/leds/smc\:kbd_backlight/brightness doubledog hwyss # ls -l /sys/class/leds/smc\:kbd_backlight/brightness -rw-rw-rw- 1 root root 4096 2006-11-30 16:58 /sys/class/leds/smc:kbd_backlight/brightness doubledog hwyss # rmmod applesmc; modprobe applesmc doubledog hwyss # ls -l /sys/class/leds/smc\:kbd_backlight/brightness -rw-r--r-- 1 root root 4096 2006-11-30 17:10 /sys/class/leds/smc:kbd_backlight/brightness This is on linux 2.6.18.1 (gentoo) x86_64. Would you have any hints on where to change that? udev? > But since you use /var/lib/keylight to store the old value you _have_ > to be root to write in /var/lib. > My script uses /tmp/keyboard_brigthness_old_value so do not need to be root. Which gives me the advantage that I can keep my favorite keyboard illumination-level across /tmp-wiping reboots. Which I admit is not that incredibly important ;) > My version is 42 lines of shell script. > Your version is 113 lines of C (I used sloccount to just count the > lines of code). Ah, yes - but I learned a lot writing those 113 lines! Thanks Hannes |
From: Ludovic R. <lud...@gm...> - 2006-12-02 16:48:06
|
On 30/11/06, Hannes Wyss <han...@gm...> wrote: > On 11/30/06, Ludovic Rousseau <lud...@gm...> wrote: > > But since you use /var/lib/keylight to store the old value you _have_ > > to be root to write in /var/lib. > > My script uses /tmp/keyboard_brigthness_old_value so do not need to be root. > > Which gives me the advantage that I can keep my favorite keyboard > illumination-level across /tmp-wiping reboots. Which I admit is not > that incredibly important ;) Good idea. I now use ~/.keyboard_brigthness_old_value instead of /tmp/keyboard_brigthness_old_value Bye, -- Dr. Ludovic Rousseau |