#111 StandardFile code refs failing

[Chris Nandor]

When Standard*File hits a callback, it crashes. Find
out why. Maybe another xsubpp issue?

[Chris Nandor]

Logged In: YES
user_id=3660

Hm. There are two problems I've found. One is that
FILEFILTER parameter in StandardGetFile / CustomGetFile is
croaking during XS_CatInfo_DESTROY in Mac::Files. It appears
to happen in free(cat).

The other is that the custom dlgHook is dying. It is hard
for me to track down where, but I did get one error message
about there being no refCon method for package GrafPtr.
Other times it just crashes in CallDlgHook.

[Matthias Neeracher]

Logged In: YES
user_id=37219

I was using dXSARGS instead of dSP, which appears
to leak Perl stack frames and eventually causes
memory to be overwritten (the StandardFile filter proc is
called dozens of times for large directories). This
mistake is repeated in several locations:

Checking in Mac/Lists/Lists.xs;
/cvsroot/macperl/perl/macos/ext/Mac/Lists/Lists.xs,v <--
Lists.xs
new revision: 1.3; previous revision: 1.2
done
Checking in Mac/Menus/Menus.xs;
/cvsroot/macperl/perl/macos/ext/Mac/Menus/Menus.xs,v
<-- Menus.xs
new revision: 1.4; previous revision: 1.3
done
Checking in Mac/Movies/Movies.xs;
/cvsroot/macperl/perl/macos/ext/Mac/Movies/Movies.xs,v
<-- Movies.xs
new revision: 1.3; previous revision: 1.2
done
Checking in Mac/QuickTimeVR/QuickTimeVR.xs;
/cvsroot/macperl/perl/macos/ext/Mac/QuickTimeVR/Qui
ckTimeVR.xs,v <-- QuickTimeVR.xs
new revision: 1.3; previous revision: 1.2
done
Checking in Mac/StandardFile/StandardFile.xs;
/cvsroot/macperl/perl/macos/ext/Mac/StandardFile/Stan
dardFile.xs,v <-- StandardFile.xs
new revision: 1.3; previous revision: 1.2
done
Checking in Mac/Windows/Windows.xs;
/cvsroot/macperl/perl/macos/ext/Mac/Windows/Window
s.xs,v <-- Windows.xs
new revision: 1.4; previous revision: 1.3
done

[Chris Nandor]

Logged In: YES
user_id=3660

Hm, that makes sense. I saw the difference from the 5.2.0
version, but didn't know the significance. Now I gotta go look it
up ... ah, dXSARGS seems to set up more than dSP does,
including dMARK. Building now.

[Chris Nandor]

Logged In: YES
user_id=3660

That seems to fix the callback issue. But I am still getting nasty
pain death in free(cat) during XS_CatInfo_DESTROY in
Mac::Files with CustomGetFile.

[Matthias Neeracher]

Logged In: YES
user_id=37219

Yeah. Files.xs thinks that we allocated all CatInfos ourselves, while StandardFile.xs has different ideas.

Files.xs,1.5

[Chris Nandor]

Logged In: YES
user_id=3660