From: <shu...@or...> - 2013-05-27 06:30:42
|
From: Shuang Qiu <shu...@or...> It does not unmap the mapped address region,so we sometimes still get such warning when cleanup with nfs as TMPDIR although the file descriptor is closed: 0 TWARN : tst_rmdir: rmobj(/mnt/nfsv3/ltp-MOeIFH7102/vma4FwRqb) failed: unlink(/mnt/nfsv3/ltp-MOeIFH7102/vma4FwRqb/.nfs000000000110cb3600000001) failed; errno=16: Device or resource busy Signed-off-by: Shuang Qiu <shu...@or...> --- testcases/kernel/mem/vma/vma03.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/testcases/kernel/mem/vma/vma03.c b/testcases/kernel/mem/vma/vma03.c index 54f605a..6af9960 100644 --- a/testcases/kernel/mem/vma/vma03.c +++ b/testcases/kernel/mem/vma/vma03.c @@ -101,8 +101,10 @@ int main(int argc, char *argv[]) tst_resm(TPASS, "mremap failed as expected."); else tst_resm(TFAIL | TERRNO, "mremap"); + munmap(map, pgsz); } else { tst_resm(TFAIL, "mremap succeeded unexpectedly."); + munmap(remap, 2 * pgsz); } close(fd); -- 1.7.7 |
From: Jan S. <jst...@re...> - 2013-05-27 07:17:28
|
----- Original Message ----- > From: "shuang qiu" <shu...@or...> > To: ltp...@li... > Sent: Monday, 27 May, 2013 8:29:42 AM > Subject: [LTP] [PATCH] Unmap the mapped address region > > From: Shuang Qiu <shu...@or...> > > It does not unmap the mapped address region,so we sometimes still get > such > warning when cleanup with nfs as TMPDIR although the file descriptor is > closed: > 0 TWARN : tst_rmdir: rmobj(/mnt/nfsv3/ltp-MOeIFH7102/vma4FwRqb) > failed: > unlink(/mnt/nfsv3/ltp-MOeIFH7102/vma4FwRqb/.nfs000000000110cb3600000001) > failed; errno=16: Device or resource busy > > Signed-off-by: Shuang Qiu <shu...@or...> Looks good to me. Useful also when test loops. Reviewed-by: Jan Stancek <jst...@re...> > --- > testcases/kernel/mem/vma/vma03.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/testcases/kernel/mem/vma/vma03.c > b/testcases/kernel/mem/vma/vma03.c > index 54f605a..6af9960 100644 > --- a/testcases/kernel/mem/vma/vma03.c > +++ b/testcases/kernel/mem/vma/vma03.c > @@ -101,8 +101,10 @@ int main(int argc, char *argv[]) > tst_resm(TPASS, "mremap failed as expected."); > else > tst_resm(TFAIL | TERRNO, "mremap"); > + munmap(map, pgsz); > } else { > tst_resm(TFAIL, "mremap succeeded unexpectedly."); > + munmap(remap, 2 * pgsz); > } > > close(fd); > -- > 1.7.7 > > > ------------------------------------------------------------------------------ > Try New Relic Now & We'll Send You this Cool Shirt > New Relic is the only SaaS-based application performance monitoring service > that delivers powerful full stack analytics. Optimize and monitor your > browser, app, & servers with just a few lines of code. Try New Relic > and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may > _______________________________________________ > Ltp-list mailing list > Ltp...@li... > https://lists.sourceforge.net/lists/listinfo/ltp-list > |
From: Wanlong G. <gao...@cn...> - 2013-05-27 07:23:25
|
On 05/27/2013 02:29 PM, shu...@or... wrote: > From: Shuang Qiu <shu...@or...> > > It does not unmap the mapped address region,so we sometimes still get > such > warning when cleanup with nfs as TMPDIR although the file descriptor is > closed: > 0 TWARN : tst_rmdir: rmobj(/mnt/nfsv3/ltp-MOeIFH7102/vma4FwRqb) > failed: > unlink(/mnt/nfsv3/ltp-MOeIFH7102/vma4FwRqb/.nfs000000000110cb3600000001) > failed; errno=16: Device or resource busy > > Signed-off-by: Shuang Qiu <shu...@or...> Applied, thank you. Wanlong Gao |