From: Caspar Z. <cz...@re...> - 2011-04-24 15:56:06
Attachments:
0001-mm-remove-unused-libmm.patch
|
As discussed in previous thread, some tests under mem/ links against libmm which seems not necessary. So I removed libmm and the links to clean up. Signed-off-by: Caspar Zhang <cz...@re...> --- testcases/kernel/mem/Makefile | 18 -- testcases/kernel/mem/Makefile.inc | 39 --- testcases/kernel/mem/cpuset/Makefile | 3 +- testcases/kernel/mem/hugetlb/Makefile | 3 +- testcases/kernel/mem/hugetlb/Makefile.inc | 15 +- testcases/kernel/mem/libmm/Makefile | 25 -- testcases/kernel/mem/libmm/mm_core_apis.c | 405 ----------------------------- testcases/kernel/mem/mmapstress/Makefile | 1 - testcases/kernel/mem/mtest01/Makefile | 1 - testcases/kernel/mem/mtest05/Makefile | 1 - testcases/kernel/mem/mtest06/Makefile | 1 - testcases/kernel/mem/mtest07/Makefile | 1 - testcases/kernel/mem/page/Makefile | 1 - testcases/kernel/mem/shmt/Makefile | 1 - testcases/kernel/mem/vmtests/Makefile | 1 - 15 files changed, 8 insertions(+), 508 deletions(-) delete mode 100644 testcases/kernel/mem/Makefile.inc delete mode 100644 testcases/kernel/mem/libmm/Makefile delete mode 100644 testcases/kernel/mem/libmm/mm_core_apis.c |
From: Cyril H. <ch...@su...> - 2011-04-26 16:28:36
|
Hi! Git is not CVS (and understands patches that removes directories), so please provide patch that removes the libmm directory too. -- Cyril Hrubis ch...@su... |
From: Caspar Z. <cz...@re...> - 2011-04-26 17:40:43
|
On 04/27/2011 12:54 AM, Cyril Hrubis wrote: > Hi! > Git is not CVS (and understands patches that removes directories), so > please provide patch that removes the libmm directory too. > Hi, IIRC, GIT would remove the empty automatically while CVS would't. Maybe I'm wrong, but I tested my patch by "git am -3", the libmm directory did gone: $ ls testcases/kernel/mem/ | grep lib lib libmm $ git am -3 ~/Desktop/\[PATCH\]\ \[mm\]\ remove\ unused\ libmm.eml Applying: remove unused libmm $ ls testcases/kernel/mem/ | grep lib lib Thanks, Caspar |
From: Garrett C. <yan...@gm...> - 2011-04-26 18:40:33
|
On Apr 26, 2011, at 9:50 AM, Caspar Zhang <cz...@re...> wrote: > On 04/27/2011 12:54 AM, Cyril Hrubis wrote: >> Hi! >> Git is not CVS (and understands patches that removes directories), so >> please provide patch that removes the libmm directory too. >> > > Hi, IIRC, GIT would remove the empty automatically while CVS would't. > Maybe I'm wrong, but I tested my patch by "git am -3", the libmm > directory did gone: > > $ ls testcases/kernel/mem/ | grep lib > lib > libmm > $ git am -3 ~/Desktop/\[PATCH\]\ \[mm\]\ remove\ unused\ libmm.eml > Applying: remove unused libmm > $ ls testcases/kernel/mem/ | grep lib > lib Honestly though -- it's easy enough to do a git rm on the directory, as long as everything was properly disabled beforehand, so it doesn't break the build like it has a handful of times for me. Thanks! -Garrett |
From: Caspar Z. <cz...@re...> - 2011-04-27 09:31:08
|
On 04/27/2011 02:40 AM, Garrett Cooper wrote: > On Apr 26, 2011, at 9:50 AM, Caspar Zhang <cz...@re...> wrote: > >> On 04/27/2011 12:54 AM, Cyril Hrubis wrote: >>> Hi! >>> Git is not CVS (and understands patches that removes directories), so >>> please provide patch that removes the libmm directory too. >>> >> >> Hi, IIRC, GIT would remove the empty automatically while CVS would't. >> Maybe I'm wrong, but I tested my patch by "git am -3", the libmm >> directory did gone: >> >> $ ls testcases/kernel/mem/ | grep lib >> lib >> libmm >> $ git am -3 ~/Desktop/\[PATCH\]\ \[mm\]\ remove\ unused\ libmm.eml >> Applying: remove unused libmm >> $ ls testcases/kernel/mem/ | grep lib >> lib > > Honestly though -- it's easy enough to do a git rm on the directory, as long as everything was properly disabled beforehand, so it doesn't break the build like it has a handful of times for me. > Thanks! > -Garrett Hi Garrett and Cyril, I'm not very clear what I can do next to get this merged to upstream. I have tested the patch on my own and the build could finish successfully in any directory under mem/ dir. Caspar |
From: Caspar Z. <cz...@re...> - 2011-05-06 03:45:05
|
On 04/27/2011 05:30 PM, Caspar Zhang wrote: > On 04/27/2011 02:40 AM, Garrett Cooper wrote: >> On Apr 26, 2011, at 9:50 AM, Caspar Zhang <cz...@re...> wrote: >> >>> On 04/27/2011 12:54 AM, Cyril Hrubis wrote: >>>> Hi! >>>> Git is not CVS (and understands patches that removes directories), so >>>> please provide patch that removes the libmm directory too. >>>> >>> >>> Hi, IIRC, GIT would remove the empty automatically while CVS would't. >>> Maybe I'm wrong, but I tested my patch by "git am -3", the libmm >>> directory did gone: >>> >>> $ ls testcases/kernel/mem/ | grep lib >>> lib >>> libmm >>> $ git am -3 ~/Desktop/\[PATCH\]\ \[mm\]\ remove\ unused\ libmm.eml >>> Applying: remove unused libmm >>> $ ls testcases/kernel/mem/ | grep lib >>> lib >> >> Honestly though -- it's easy enough to do a git rm on the directory, as long as everything was properly disabled beforehand, so it doesn't break the build like it has a handful of times for me. >> Thanks! >> -Garrett > > Hi Garrett and Cyril, I'm not very clear what I can do next to get this > merged to upstream. I have tested the patch on my own and the build > could finish successfully in any directory under mem/ dir. > > Caspar Hi, any suggestions? Thanks, Caspar |
From: Cyril H. <ch...@su...> - 2011-05-06 12:50:34
|
Hi! > > Hi Garrett and Cyril, I'm not very clear what I can do next to get this > > merged to upstream. I have tested the patch on my own and the build > > could finish successfully in any directory under mem/ dir. > > > > Caspar > > Hi, any suggestions? > Nevermind, the git is dumbier that I expected... Or rather it doesn't track directories at all, commited. -- Cyril Hrubis ch...@su... |