From: Jan S. <jst...@re...> - 2012-07-31 08:33:33
Attachments:
0001-proc01-add-option-to-limit-max-read-bytes.patch
|
Add option -m to set upper limit of read megabytes from single proc file. When this limit is reached testcase will continue with next file. Reason for this new option is to allow running this testcase as sanity test, that doesn't need go through full content of files such as "pagemap" (which can take hours). Signed-off-by: Jan Stancek <jst...@re...> --- testcases/kernel/fs/proc/proc01.c | 22 ++++++++++++++++++---- 1 files changed, 18 insertions(+), 4 deletions(-) |
From: Caspar Z. <ca...@ca...> - 2012-08-23 03:35:07
|
On 07/31/2012 04:33 PM, Jan Stancek wrote: > > Add option -m to set upper limit of read megabytes from > single proc file. When this limit is reached testcase > will continue with next file. > > Reason for this new option is to allow running this testcase > as sanity test, that doesn't need go through full content of > files such as "pagemap" (which can take hours). > > Signed-off-by: Jan Stancek <jst...@re...> Reviewed-by: Caspar Zhang <ca...@ca...> > --- > testcases/kernel/fs/proc/proc01.c | 22 ++++++++++++++++++---- > 1 files changed, 18 insertions(+), 4 deletions(-) |
From: Wanlong G. <gao...@cn...> - 2012-08-23 03:42:23
|
On 08/23/2012 11:34 AM, Caspar Zhang wrote: > On 07/31/2012 04:33 PM, Jan Stancek wrote: >> >> Add option -m to set upper limit of read megabytes from >> single proc file. When this limit is reached testcase >> will continue with next file. >> >> Reason for this new option is to allow running this testcase >> as sanity test, that doesn't need go through full content of >> files such as "pagemap" (which can take hours). >> >> Signed-off-by: Jan Stancek <jst...@re...> > Reviewed-by: Caspar Zhang <ca...@ca...> Pushed, thank you. Wanlong Gao |
From: <ch...@su...> - 2012-09-20 11:56:56
|
Hi! > single proc file. When this limit is reached testcase > will continue with next file. > > Reason for this new option is to allow running this testcase > as sanity test, that doesn't need go through full content of > files such as "pagemap" (which can take hours). Wouldn't adding -m to the proc01 to runtest/fs make sense too? (so we doesn't spend too much time in proc01 in defalt runs) -- Cyril Hrubis ch...@su... |
From: Jan S. <jst...@re...> - 2012-09-20 12:15:30
|
----- Original Message ----- > From: ch...@su... > To: "Jan Stancek" <jst...@re...> > Cc: ltp...@li... > Sent: Tuesday, 16 February, 2010 3:27:19 AM > Subject: Re: [LTP] [PATCH] proc01: add option to limit max read bytes > > Hi! > > single proc file. When this limit is reached testcase > > will continue with next file. > > > > Reason for this new option is to allow running this testcase > > as sanity test, that doesn't need go through full content of > > files such as "pagemap" (which can take hours). > > Wouldn't adding -m to the proc01 to runtest/fs make sense too? Seems like a good idea. Question is, what should we choose as good default for maximum. I'm running it now with: proc01 proc01 -m 128 I chose 128MB as rule of thumb, so I can hit some real pages and holes (in pagemap). 128MB equals to 4194304 pages (32bits per entry). If page_size is 4kB, this covers first 16G of address space, so it's likely you hit all kinds of pagemap entries. Regards, Jan > > (so we doesn't spend too much time in proc01 in defalt runs) > > -- > Cyril Hrubis > ch...@su... > |
From: <ch...@su...> - 2012-10-04 14:23:42
|
Hi! > Seems like a good idea. Question is, what should we choose > as good default for maximum. I'm running it now with: > proc01 proc01 -m 128 > > I chose 128MB as rule of thumb, so I can hit some real pages > and holes (in pagemap). 128MB equals to 4194304 pages (32bits per entry). > If page_size is 4kB, this covers first 16G of address space, so > it's likely you hit all kinds of pagemap entries. I've commited the change in runtest file. (and quoted part of your mail in the commit message) Thanks. -- Cyril Hrubis ch...@su... |