From: James S. <jsi...@in...> - 2005-09-21 21:03:37
|
Let me know if this is acceptable. Some people might not like the name. --- linus-2.6/drivers/video/fbsysfs.c 2005-07-31 15:45:22.000000000 -0700 +++ fbdev-2.6/drivers/video/fbsysfs.c 2005-09-21 13:54:02.000000000 -0700 @@ -242,6 +242,13 @@ fb_info->var.yres_virtual); } +static ssize_t show_stride(struct class_device *class_device, char *buf) +{ + struct fb_info *fb_info = + (struct fb_info *)class_get_devdata(class_device); + return snprintf(buf, PAGE_SIZE, "%d\n", fb_info->fix.line_length); +} + /* Format for cmap is "%02x%c%4x%4x%4x\n" */ /* %02x entry %c transp %4x red %4x blue %4x green \n */ /* 256 rows at 16 chars equals 4096, the normal page size */ @@ -432,6 +439,7 @@ __ATTR(pan, S_IRUGO|S_IWUSR, show_pan, store_pan), __ATTR(virtual_size, S_IRUGO|S_IWUSR, show_virtual, store_virtual), __ATTR(name, S_IRUGO, show_name, NULL), + __ATTR(stride, S_IRUGO, show_stride, NULL), }; int fb_init_class_device(struct fb_info *fb_info) |
From: Kronos <kr...@pe...> - 2005-09-21 23:28:16
|
Il Wed, Sep 21, 2005 at 10:03:29PM +0100, James Simmons ha scritto: > --- linus-2.6/drivers/video/fbsysfs.c 2005-07-31 15:45:22.000000000 -0700 > +++ fbdev-2.6/drivers/video/fbsysfs.c 2005-09-21 13:54:02.000000000 -0700 > @@ -242,6 +242,13 @@ > fb_info->var.yres_virtual); > } > > +static ssize_t show_stride(struct class_device *class_device, char *buf) > +{ > + struct fb_info *fb_info = > + (struct fb_info *)class_get_devdata(class_device); class_get_devdata returns a void*, you can remove the cast and use just one line :) > + return snprintf(buf, PAGE_SIZE, "%d\n", fb_info->fix.line_length); > +} > + > /* Format for cmap is "%02x%c%4x%4x%4x\n" */ > /* %02x entry %c transp %4x red %4x blue %4x green \n */ > /* 256 rows at 16 chars equals 4096, the normal page size */ > @@ -432,6 +439,7 @@ > __ATTR(pan, S_IRUGO|S_IWUSR, show_pan, store_pan), > __ATTR(virtual_size, S_IRUGO|S_IWUSR, show_virtual, store_virtual), > __ATTR(name, S_IRUGO, show_name, NULL), > + __ATTR(stride, S_IRUGO, show_stride, NULL), > }; > > int fb_init_class_device(struct fb_info *fb_info) Luca -- Home: http://kronoz.cjb.net Se non puoi convincerli, confondili. |
From: Geert U. <ge...@li...> - 2005-09-22 09:38:59
|
On Wed, 21 Sep 2005, James Simmons wrote: > Let me know if this is acceptable. Some people might not like the name. > > > --- linus-2.6/drivers/video/fbsysfs.c 2005-07-31 15:45:22.000000000 -0700 > +++ fbdev-2.6/drivers/video/fbsysfs.c 2005-09-21 13:54:02.000000000 -0700 > @@ -242,6 +242,13 @@ > fb_info->var.yres_virtual); > } > > +static ssize_t show_stride(struct class_device *class_device, char *buf) > +{ > + struct fb_info *fb_info = > + (struct fb_info *)class_get_devdata(class_device); > + return snprintf(buf, PAGE_SIZE, "%d\n", fb_info->fix.line_length); Do all drivers set fix.line_length these days? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@li... In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds |
From: Antonino D. <ad...@gm...> - 2005-09-22 10:19:52
|
On 9/22/05, Geert Uytterhoeven <ge...@li...> wrote: > On Wed, 21 Sep 2005, James Simmons wrote: > > Let me know if this is acceptable. Some people might not like the name. > > > > > > --- linus-2.6/drivers/video/fbsysfs.c 2005-07-31 15:45:22.000000000 -07= 00 > > +++ fbdev-2.6/drivers/video/fbsysfs.c 2005-09-21 13:54:02.000000000 -07= 00 > > @@ -242,6 +242,13 @@ > > fb_info->var.yres_virtual); > > } > > > > +static ssize_t show_stride(struct class_device *class_device, char *bu= f) > > +{ > > + struct fb_info *fb_info =3D > > + (struct fb_info *)class_get_devdata(class_device); > > + return snprintf(buf, PAGE_SIZE, "%d\n", fb_info->fix.line_length)= ; > > Do all drivers set fix.line_length these days? > They have to, if they want to use any of the cfb_* drawing functions. Tony |