From: Felipe C. <fel...@gm...> - 2008-11-26 20:35:30
|
From: Felipe Contreras <fel...@no...> The blank operation should receive FB_BLANK_POWERDOWN, not VESA_POWERDOWN. Signed-off-by: Felipe Contreras <fel...@no...> --- drivers/video/omap/omapfb_main.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/video/omap/omapfb_main.c b/drivers/video/omap/omapfb_main.c index 3bb4247..c8db8b2 100644 --- a/drivers/video/omap/omapfb_main.c +++ b/drivers/video/omap/omapfb_main.c @@ -348,7 +348,7 @@ static int omapfb_blank(int blank, struct fb_info *fbi) omapfb_rqueue_lock(fbdev); switch (blank) { - case VESA_NO_BLANKING: + case FB_BLANK_UNBLANK: if (fbdev->state == OMAPFB_SUSPENDED) { if (fbdev->ctrl->resume) fbdev->ctrl->resume(); @@ -359,7 +359,7 @@ static int omapfb_blank(int blank, struct fb_info *fbi) do_update = 1; } break; - case VESA_POWERDOWN: + case FB_BLANK_POWERDOWN: if (fbdev->state == OMAPFB_ACTIVE) { fbdev->panel->disable(fbdev->panel); if (fbdev->ctrl->suspend) @@ -1842,7 +1842,7 @@ static int omapfb_suspend(struct platform_device *pdev, pm_message_t mesg) struct omapfb_device *fbdev = platform_get_drvdata(pdev); if (fbdev != NULL) - omapfb_blank(VESA_POWERDOWN, fbdev->fb_info[0]); + omapfb_blank(FB_BLANK_POWERDOWN, fbdev->fb_info[0]); return 0; } @@ -1852,7 +1852,7 @@ static int omapfb_resume(struct platform_device *pdev) struct omapfb_device *fbdev = platform_get_drvdata(pdev); if (fbdev != NULL) - omapfb_blank(VESA_NO_BLANKING, fbdev->fb_info[0]); + omapfb_blank(FB_BLANK_UNBLANK, fbdev->fb_info[0]); return 0; } -- 1.6.0.4 |
From: Felipe C. <fel...@gm...> - 2008-12-04 22:46:05
|
From: Felipe Contreras <fel...@no...> The blank operation should receive FB_BLANK_POWERDOWN, not VESA_POWERDOWN. Signed-off-by: Felipe Contreras <fel...@no...> --- Resending this patch. The last time it wasn't against HEAD. drivers/video/omap/omapfb_main.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/video/omap/omapfb_main.c b/drivers/video/omap/omapfb_main.c index 5a5e407..6ac51ec 100644 --- a/drivers/video/omap/omapfb_main.c +++ b/drivers/video/omap/omapfb_main.c @@ -338,7 +338,7 @@ static int omapfb_blank(int blank, struct fb_info *fbi) omapfb_rqueue_lock(fbdev); switch (blank) { - case VESA_NO_BLANKING: + case FB_BLANK_UNBLANK: if (fbdev->state == OMAPFB_SUSPENDED) { if (fbdev->ctrl->resume) fbdev->ctrl->resume(); @@ -349,7 +349,7 @@ static int omapfb_blank(int blank, struct fb_info *fbi) do_update = 1; } break; - case VESA_POWERDOWN: + case FB_BLANK_POWERDOWN: if (fbdev->state == OMAPFB_ACTIVE) { fbdev->panel->disable(fbdev->panel); if (fbdev->ctrl->suspend) @@ -1818,7 +1818,7 @@ static int omapfb_suspend(struct platform_device *pdev, pm_message_t mesg) { struct omapfb_device *fbdev = platform_get_drvdata(pdev); - omapfb_blank(VESA_POWERDOWN, fbdev->fb_info[0]); + omapfb_blank(FB_BLANK_POWERDOWN, fbdev->fb_info[0]); return 0; } @@ -1828,7 +1828,7 @@ static int omapfb_resume(struct platform_device *pdev) { struct omapfb_device *fbdev = platform_get_drvdata(pdev); - omapfb_blank(VESA_NO_BLANKING, fbdev->fb_info[0]); + omapfb_blank(FB_BLANK_UNBLANK, fbdev->fb_info[0]); return 0; } -- 1.6.0.4 |
From: Trilok S. <son...@gm...> - 2009-03-11 17:18:04
|
Hi Felipe, On Fri, Dec 5, 2008 at 4:15 AM, Felipe Contreras <fel...@gm...> wrote: > From: Felipe Contreras <fel...@no...> > > The blank operation should receive FB_BLANK_POWERDOWN, not > VESA_POWERDOWN. > Thanks. Looks good. Signed-off-by: Trilok Soni <son...@gm...> -- ---Trilok Soni http://triloksoni.wordpress.com http://www.linkedin.com/in/triloksoni |
From: Andrew M. <ak...@li...> - 2009-03-11 22:23:32
|
On Wed, 11 Mar 2009 22:47:41 +0530 Trilok Soni <son...@gm...> wrote: > Hi Felipe, > > On Fri, Dec 5, 2008 at 4:15 AM, Felipe Contreras I bet he thought we'd forgotten. > <fel...@gm...> wrote: > > From: Felipe Contreras <fel...@no...> > > > > The blank operation should receive FB_BLANK_POWERDOWN, not > > VESA_POWERDOWN. > > > > Thanks. Looks good. > > Signed-off-by: Trilok Soni <son...@gm...> > Unfortunately the changelog didn't give me any hint as to the seriousness of the problem which was fixed. So I queued it for 2.6.30, perhaps inappropriately. |
From: Felipe C. <fel...@gm...> - 2009-03-11 22:43:27
|
On Thu, Mar 12, 2009 at 12:20 AM, Andrew Morton <ak...@li...> wrote: > On Wed, 11 Mar 2009 22:47:41 +0530 > Trilok Soni <son...@gm...> wrote: > >> Hi Felipe, >> >> On Fri, Dec 5, 2008 at 4:15 AM, Felipe Contreras > > I bet he thought we'd forgotten. You bet correctly :) >> <fel...@gm...> wrote: >> > From: Felipe Contreras <fel...@no...> >> > >> > The blank operation should receive FB_BLANK_POWERDOWN, not >> > VESA_POWERDOWN. >> > >> >> Thanks. Looks good. >> >> Signed-off-by: Trilok Soni <son...@gm...> >> > > Unfortunately the changelog didn't give me any hint as to the > seriousness of the problem which was fixed. So I queued it for 2.6.30, > perhaps inappropriately. I noticed because of another bug in omapfb which required blanking in order to actually see something (PM stuff?). If user-space tries to blank the usual way, it wouldn't work. My guess is that it's not a big issue, in part because nobody has noticed, but perhaps I'm wrong. I was hoping the fbdev guys would know better. -- Felipe Contreras |