Thread: [limesurvey-developers] (Substantial) Changes to survey translation screen
The leading Open Source survey tool
Brought to you by:
c_schmitz
From: Andrie de V. <apd...@ya...> - 2010-11-09 12:23:44
|
Dear developers. I have made a substantial change to the survey translation screen: 1. Grouped related topics on the same page. For example, Survey title and description are on the same page. Likewise, question group and group help, etc. This partially implements a suggestion by Menno. In my view this is a big improvement, since it reduces the number of tabs and keeps the translation context. 2. Started to add support for translation of email templates. At the moment, I have only coded the invitation email and the reminder email. Other changes: * Added some CSS to modify the outline of textarea input fields. Again, in response to a suggestion by Menno. Questions and issues: * At the moment, the email templates are always available for translation, regardless of the status of the token table. It needs a bit more thought whether to activate the translation only if the token table exists. I think there is a case for having translation active without a token table, because that is the way I would like to manage my workflow on a typical project. However, given that existing LimeSurvey behaviour is different, I should probably modify the code to check for the existence of the token table first. * I have tried to style the popupEditor fields also, but the CSS to do this is beyond me, and I don't want to modify the global stylesheet for the FCKeditor. Any suggestions are welcome. As always, feedback is welcome. Andrie |
From: Thibault Le M. <Thi...@su...> - 2010-11-09 12:46:54
|
Le 09/11/2010 13:23, Andrie de Vries a écrit : > Dear developers. > > I have made a substantial change to the survey translation screen: > > 1. Grouped related topics on the same page. For example, Survey > title and description are on the same page. Likewise, question > group and group help, etc. This partially implements a > suggestion by Menno. In my view this is a big improvement, > since it reduces the number of tabs and keeps the translation > context. > Great news, thanks. > 1. Started to add support for translation of email templates. At > the moment, I have only coded the invitation email and the > reminder email. > Ok, have you called FCKeditor with correct parameters so that LimereplacementFields shows the placeholders corresponding to email templates ? > Questions and issues: > > * At the moment, the email templates are always available for > translation, regardless of the status of the token table. It > needs a bit more thought whether to activate the translation > only if the token table exists. I think there is a case for > having translation active without a token table, because that is > the way I would like to manage my workflow on a typical > In the past the workflow was different: the email templates were part of the survey Text elements, and thus could be edited without a token table. Technically there is no reason why we should prevent editing email templates when no token table is set. However semantically, this is only useful if a token table is set of course. I think the issue is that we can't access the Token actions before activating a token Table. Maybe we should think about another workflow: * access to the Token GUI is available at any time without requiring to create a token table * Add an icon to Create/Delete the token table * Let the Icon to edit the email templates * Let the current behaviour of LS while activating a survey: ask the user if he wants to switch to closed-access survey by creating a token table > * project. However, given that existing LimeSurvey behaviour is > different, I should probably modify the code to check for the > existence of the token table first. > Or change the default workflow... if this meets users' requirements... > * I have tried to style the popupEditor fields also, but the CSS > to do this is beyond me, and I don't want to modify the global > stylesheet for the FCKeditor. Any suggestions are welcome. > What kind of modifications would you like to do in this CSS ? Thibault |
From: Andrie de V. <apd...@ya...> - 2010-11-11 10:04:02
|
Thibault I have finally figured out what LimeReplacementFields mean! At the moment my code breaks this, but now I know what to look for and test, so will get round to it in the next few days. Andrie On 09/11/2010 12:46, Thibault Le Meur wrote: > Ok, have you called FCKeditor with correct parameters so that > LimereplacementFields shows the placeholders corresponding to email > templates ? > |
From: Andrie de V. <apd...@ya...> - 2010-11-11 10:14:59
|
Thibault In the survey translation I highlight the active input area with a blue outline. This is useful, because the entire screen might be full of textarea input fields, and some of highlighting helps the user by visually identifying where they are on screen. So, in adminstyle.css I added: #translateform textarea:focus{ outline: blue solid thin; } And in fck_editor.css one can refer to HTML editor fields with #xEditingArea. So, I would like to write some code along the lines of: #translateform #xEditingArea:focus{ outline: blue solid thin; } Except this doesn't work. As far as I can tell, the fckEditor sets up an embedded HTML inside the form, so the context of the form is lost. (Sorry, I can't describe this very well, since I don't understand what's going on.) Anyway, is there a way of adding styling to adminstyle.css to affect the style of #xEditingArea, but only for the #translateform? Andrie On 09/11/2010 12:46, Thibault Le Meur wrote: >> > What kind of modifications would you like to do in this CSS ? > I have tried to style the popupEditor fields also, but the CSS to do > this is beyond me, and I don't want to modify the global stylesheet > for the FCKeditor. Any suggestions are welcome. > > Thibault |
From: Marcel M. (Limesurvey) <mar...@li...> - 2010-11-09 13:16:07
|
Hi Andrie, great work so far. About the token table/email translations: Often people set up the token table after they have finished creating the survey. According to workflow issues I recommend to enable email translation even if there is no token table yet (if this can be done from a database point of view, I think Carsten did some changes). We can have a warning like "Only translate email messages if you plan to use 'tokens' (link to manual) at your survey". Just my 2 cents... Best regards, Marcel Am 09.11.2010 13:23, schrieb Andrie de Vries: > At the moment, the email templates are always available for > translation, regardless of the status of the token table. It needs a > bit more thought whether to activate the translation only if the token > table exists. I think there is a case for having translation active > without a token table, because that is the way I would like to manage > my workflow on a typical project. However, given that existing > LimeSurvey behaviour is different, I should probably modify the code > to check for the existence of the token table first. |
From: Carsten S. <car...@go...> - 2010-11-09 13:25:39
|
Hi! Just a note: The email templates are not noly for tokens anyway but also for admin notifications (that was the feature I added recently). -Carsten Am 09.11.2010 14:16, schrieb Marcel Minke (Limesurvey): > Hi Andrie, > > great work so far. About the token table/email translations: Often > people set up the token table after they have finished creating the > survey. According to workflow issues I recommend to enable email > translation even if there is no token table yet (if this can be done > from a database point of view, I think Carsten did some changes). We can > have a warning like "Only translate email messages if you plan to use > 'tokens' (link to manual) at your survey". > Just my 2 cents... > > Best regards, > Marcel > > Am 09.11.2010 13:23, schrieb Andrie de Vries: >> At the moment, the email templates are always available for >> translation, regardless of the status of the token table. It needs a >> bit more thought whether to activate the translation only if the token >> table exists. I think there is a case for having translation active >> without a token table, because that is the way I would like to manage >> my workflow on a typical project. However, given that existing >> LimeSurvey behaviour is different, I should probably modify the code >> to check for the existence of the token table first. > ------------------------------------------------------------------------------ > The Next 800 Companies to Lead America's Growth: New Video Whitepaper > David G. Thomson, author of the best-selling book "Blueprint to a > Billion" shares his insights and actions to help propel your > business during the next growth cycle. Listen Now! > http://p.sf.net/sfu/SAP-dev2dev > _______________________________________________ > limesurvey-developers mailing list > lim...@li... > https://lists.sourceforge.net/lists/listinfo/limesurvey-developers |