Menu

#205 libpng 1.6.1 pngwrite.c png_image_write_main

libpng_code
closed-fixed
None
5
2013-04-26
2013-04-17
No

pngwrite.c : 2090 (png_image_write_main)

png_set_sRGB - not present if i undefined PNG_sRGB_SUPPORTED

maybe -

ifdef PNG_sRGB_SUPPORTED

else if (!(image->flags & PNG_IMAGE_FLAG_COLORSPACE_NOT_sRGB))
png_set_sRGB(png_ptr, info_ptr, PNG_sRGB_INTENT_PERCEPTUAL);

endif

Discussion

  • Glenn Randers-Pehrson

    • status: open --> open-accepted
    • assigned_to: Glenn Randers-Pehrson
     
  • Glenn Randers-Pehrson

    Thanks. Patched in the libpng16 branch of the GIT repo. There are similar situations with cHRM and gAMA which I also patched.

    I'm not sure how well the simplified interface will work with sRGB and gAMA not supported, though.

     
  • Glenn Randers-Pehrson

    It is a mistake to enable the simplified API without enabling sRGB and gAMA as well. In libpng-1.6.3 we will attempt to prevent that condition with appropriate dependencies.

     
  • Glenn Randers-Pehrson

    Fixed in libpng-1.6.2, thanks.

     
  • Glenn Randers-Pehrson

    • status: open-accepted --> closed-fixed
     

Log in to post a comment.