#14 Check return codes everywhere

[Markus Elfring]

Some checks for return codes are missing.

Examples:
Would you like to add more error handling for return values from "fread" like in the function "LoadImagePng" and from "fprintf" in the function "DecodeSchemeC40Text"?
http://libdmtx.svn.sourceforge.net/viewvc/libdmtx/util/dmtxread/dmtxread.c?revision=183&view=markup
http://libdmtx.svn.sourceforge.net/viewvc/libdmtx/dmtxdecode.c?revision=186&view=markup

[Markus Elfring]

I suggest to avoid unchecked function calls.
Would you like to detect every error situation as early as possible?

[Mike Laughton]

Hi Markus,

Yes, I agree with you completely. Earlier today I noticed this bug was still unassigned so I assigned it to myself as a reminder.

Thanks for the bug report,
Mike

[Markus Elfring]

Thanks for your acceptance.

How do you think about to look for any remaining issues by static source code analysis?
http://en.wikipedia.org/wiki/List_of_tools_for_static_code_analysis#C

How do you think about to identify update candidates by compiler-specific extensions like the annotation "__attribute__ ((warn_unused_result))"?
http://gcc.gnu.org/onlinedocs/gcc-4.3.2/gcc/Function-Attributes.html

Which reaction do you like more for failed function calls?
http://en.wikipedia.org/wiki/Crash-only_software

Would you like to reduce the efforts for error code checking by an exception class hierarchy?
http://dietmar-kuehl.de/mirror/c++-faq/exceptions.html#faq-17.1
http://cexcept.sourceforge.net/