Menu

#40 LibreOffice/OO: No cross-paragraph checks

0.9.9
closed-duplicate
nobody
5
2014-09-23
2009-10-24
No

Rules like WordCoherencyRule don't seem to work inside OOo, probably because this code calls getAllRules() which then resets the status of each rule:

paragraphMatches = langTool.check(paraText, false, JLanguageTool.paragraphHandling.ONLYPARA);

Discussion

  • Marcin Miłkowski

    • status: open --> open-accepted
     
  • Marcin Miłkowski

    • assigned_to: milek_pl --> dnaber
     
  • Marcin Miłkowski

    OK, everything is fine on the side of code, only my idea was different. Namely, the paragraph-level rule should check whether it has achieved the end of paragraph. Look at UnpairedQuotesBracketsRule.reset() and how it uses clearMatches() and endofParagraph member. Basically, the state should be handled by the paragraph-level rule by using the internal list of paragraph-level matches.

    Re-assigning, I think it's quite easy to use the concept just by coping and pasting the code from UQBRule. I tried other solutions but I didn't succeed in making them work under OOo.

     
  • Daniel Naber

    Daniel Naber - 2009-10-24

    I'm note sure - WordCoherencyRule isn't a paragraph rule, it's a document-level rule. I don't see yet how the concept you suggest can be applied to the "end of text" situation. Could you maybe explain that in more detail?

     
  • Daniel Naber

    Daniel Naber - 2011-02-26
    • summary: No cross-paragraph checks --> OOo: No cross-paragraph checks
     
  • Daniel Naber

    Daniel Naber - 2012-03-25
    • assigned_to: dnaber --> nobody
     
  • Daniel Naber

    Daniel Naber - 2014-03-25
    • status: open-accepted --> open
     
  • Daniel Naber

    Daniel Naber - 2014-03-25
    • summary: OOo: No cross-paragraph checks --> LibreOffice/OO: No cross-paragraph checks
     
  • Daniel Naber

    Daniel Naber - 2014-09-23
    • status: open --> closed-duplicate
     

Log in to post a comment.