Do not override ReplayGain if write_lame_tag is not set.

A high quality MP3 encoder

Brought to you by: aleidinger, bouvigne, jaz001, rbrito, robert

#66 Do not override ReplayGain if write_lame_tag is not set.

Milestone: None

Status: closed-fixed

Owner: Robert Hegemann

Labels: None

Priority: 5

Updated: 2014-01-28

Created: 2014-01-24

Creator: gimgim

Private: No

lame_init_params() sets ReplayGain to zero if the Xing header is not being saved by Lame. It would be helpful not to override the flags and warn the user instead.
This would allow the generation of the info in the Xing header even when the input to libmp3lame is streamed. The application I have in mind is the addition of the Xing header in ffmpeg.

1 Attachments

patch.txt

Discussion

Robert Hegemann - 2014-01-28

Ok, find peak sample and calculating replay gain won't get disabled in this case anymore.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Robert Hegemann - 2014-01-28

status: open --> closed-fixed

assigned_to: Robert Hegemann

Group: -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Do not override ReplayGain if write_lame_tag is not set.

A high quality MP3 encoder

Group

Searches

Help

#66 Do not override ReplayGain if write_lame_tag is not set.

Discussion