From: Alexander L. <Alexander@Leidinger.net> - 2002-10-15 15:04:44
|
Hi, lame.h contains: ---snip--- /* 1 = write a Xing VBR header frame. default = 1 for VBR/ABR modes, 0 for CBR mode this variable must have been added by a Hungarian notation Windows programmer : -) */ ---snip--- The default is 1 for CBR too, isn't it? Bye, Alexander. -- Speak softly and carry a cellular phone. http://www.Leidinger.net Alexander @ Leidinger.net GPG fingerprint = C518 BC70 E67F 143F BE91 3365 79E2 9C60 B006 3FE7 |
From: Gabriel B. <bou...@mp...> - 2002-10-16 13:36:10
|
> On Tue, 15 Oct 2002 17:12:25 +0200 > "Gabriel Bouvigne" <bou...@mp...> wrote: > > > > The default is 1 for CBR too, isn't it? > > Yes, but If I remember well, the dll is not writing it by default > > Then it isn't '1' by default (except the dll explicitely disables it in > the CBR case). I think we should enable (and not only require) it by > default also in the CBR case (to reduce surprising mp3 output in 3rd party > programs). The dll was calling the be_WriteXingHeader or something like that in the past at the end of encoding, but if I remember well Albert disabled it. The problem was because the dll can be used in a "pipe way" and not always in a file way. The current Info tag is written at the end because it includes some information only available at the end of encoding (seek table and encoder padding value). Perhaps we could (if someone wants/ has the time for it) write the info tag at the beginning, and update the missing fields after encoding is finished if possible? Regards, ---- Gabriel Bouvigne www.mp3-tech.org personal page: http://gabriel.mp3-tech.org |
From: Alexander L. <Alexander@Leidinger.net> - 2002-10-16 14:01:11
|
On Wed, 16 Oct 2002 15:03:19 +0200 "Gabriel Bouvigne" <bou...@mp...> wrote: > > Then it isn't '1' by default (except the dll explicitely disables it in > > the CBR case). I think we should enable (and not only require) it by > > default also in the CBR case (to reduce surprising mp3 output in 3rd party > > programs). > > The dll was calling the be_WriteXingHeader or something like that in the > past at the end of encoding, but if I remember well Albert disabled it. > The problem was because the dll can be used in a "pipe way" and not always > in a file way. > The current Info tag is written at the end because it includes some > information only available at the end of encoding (seek table and encoder > padding value). I think we talked about 2 different things. If nobody calls set_bWriteVbrTag(), will the code reserve space for the info-tag in the mp3 stream? If yes: * old code may write a "malformed" mp3 * the comment is wrong Bye, Alexander. -- The dark ages were caused by the Y1K problem. http://www.Leidinger.net Alexander @ Leidinger.net GPG fingerprint = C518 BC70 E67F 143F BE91 3365 79E2 9C60 B006 3FE7 |
From: Gabriel B. <bou...@mp...> - 2002-10-16 14:42:15
|
> I think we talked about 2 different things. > > If nobody calls set_bWriteVbrTag(), will the code reserve space for the > info-tag in the mp3 stream? > > If yes: > * old code may write a "malformed" mp3 > * the comment is wrong Yes, the code was reserving space for the info-tag, leading to "malformed" mp3 if the writevbrtag function was not called. That is why Albert decided to explicitely disable info-tag in the dll (if I remember well). |
From: Alexander L. <Alexander@Leidinger.net> - 2002-10-16 15:48:54
|
On Wed, 16 Oct 2002 16:27:46 +0200 "Gabriel Bouvigne" <bou...@mp...> wrote: > > I think we talked about 2 different things. > > > > If nobody calls set_bWriteVbrTag(), will the code reserve space for the > > info-tag in the mp3 stream? > > > > If yes: > > * old code may write a "malformed" mp3 > > * the comment is wrong > > Yes, the code was reserving space for the info-tag, leading to "malformed" > mp3 if the writevbrtag function was not called. > That is why Albert decided to explicitely disable info-tag in the dll (if I > remember well). I don't remember when we did the change... (enabled by default). It's in 3.92, isn't it? Bye, Alexander. -- The three Rs of Microsoft support: Retry, Reboot, Reinstall. http://www.Leidinger.net Alexander @ Leidinger.net GPG fingerprint = C518 BC70 E67F 143F BE91 3365 79E2 9C60 B006 3FE7 |
From: Gabriel B. <bou...@mp...> - 2002-10-17 07:45:24
|
> > Yes, the code was reserving space for the info-tag, leading to "malformed" > > mp3 if the writevbrtag function was not called. > > That is why Albert decided to explicitely disable info-tag in the dll (if I > > remember well). > > I don't remember when we did the change... (enabled by default). It's in > 3.92, isn't it? I think that it was before 3.92 |
From: Gabriel B. <bou...@mp...> - 2002-10-16 14:08:31
|
> > > > The default is 1 for CBR too, isn't it? > > > Yes, but If I remember well, the dll is not writing it by default > > > > Then it isn't '1' by default (except the dll explicitely disables it in > > the CBR case). I think we should enable (and not only require) it by > > default also in the CBR case (to reduce surprising mp3 output in 3rd party > > programs). And yes, the dll is explicitely disabling the Info header |