Menu

#14 Unnecessary use of @error-suppression operator

open
nobody
None
5
2009-02-09
2009-02-09
Seldaek
No

Please edit krumo.php at line 574 to be

if ((strToLower($d['function']) == 'krumo') || (isset($d['class']) && strToLower($d['class']) == 'krumo')) {

instead of

if ((strToLower($d['function']) == 'krumo') || (strToLower(@$d['class']) == 'krumo')) {

The @ is really not a good idea and doesn't play well with some error handlers, besides in this case it's really easy to check for it.

Thanks

Discussion


Log in to post a comment.