From: Nicolas V. <nve...@gm...> - 2010-08-17 17:13:17
|
Hi, Could we get rid of the 'dead code' warnings ? Most of them are due to code like : if (true || xxx) ... which makes xxx a dead code. If it's intended, I see 2 ways of removing the warning : - Removing the dead code (if the true is definitive, it will clear it definitely) - Replacing the 'true' by a constant (final static boolean) set to true : it will be a lot more comprehensible and the compiler should stop to complain :) Nico |
From: Jonathan G. <gu...@uw...> - 2010-08-17 21:44:44
|
Nico, Can you point to a specific piece of offending code? If the statements really are the syntax you are suggesting they make little sense. Jonathan On Aug 17, 2010, at 12:12 PM, Nicolas Vervelle wrote: > Hi, > > Could we get rid of the 'dead code' warnings ? > Most of them are due to code like : if (true || xxx) ... > which makes xxx a dead code. > > If it's intended, I see 2 ways of removing the warning : > Removing the dead code (if the true is definitive, it will clear it definitely) > Replacing the 'true' by a constant (final static boolean) set to true : it will be a lot more comprehensible and the compiler should stop to complain :) > Nico > > ------------------------------------------------------------------------------ > This SF.net email is sponsored by > > Make an app they can't live without > Enter the BlackBerry Developer Challenge > http://p.sf.net/sfu/RIM-dev2dev > _______________________________________________ > Jmol-developers mailing list > Jmo...@li... > https://lists.sourceforge.net/lists/listinfo/jmol-developers Dr. Jonathan H. Gutow Chemistry Department gu...@uw... UW-Oshkosh Office: 920-424-1326 800 Algoma Boulevard FAX:920-424-2042 Oshkosh, WI 54901 http://www.uwosh.edu/facstaff/gutow |
From: Robert H. <ha...@st...> - 2010-08-18 02:39:43
|
I'll take a look... Bob On Tue, Aug 17, 2010 at 12:12 PM, Nicolas Vervelle <nve...@gm...>wrote: > Hi, > > Could we get rid of the 'dead code' warnings ? > Most of them are due to code like : if (true || xxx) ... > which makes xxx a dead code. > > If it's intended, I see 2 ways of removing the warning : > > - Removing the dead code (if the true is definitive, it will clear it > definitely) > - Replacing the 'true' by a constant (final static boolean) set to true > : it will be a lot more comprehensible and the compiler should stop to > complain :) > > Nico > > > > ------------------------------------------------------------------------------ > This SF.net email is sponsored by > > Make an app they can't live without > Enter the BlackBerry Developer Challenge > http://p.sf.net/sfu/RIM-dev2dev > _______________________________________________ > Jmol-developers mailing list > Jmo...@li... > https://lists.sourceforge.net/lists/listinfo/jmol-developers > > -- Robert M. Hanson Professor of Chemistry St. Olaf College 1520 St. Olaf Ave. Northfield, MN 55057 http://www.stolaf.edu/people/hansonr phone: 507-786-3107 If nature does not answer first what we want, it is better to take what answer we get. -- Josiah Willard Gibbs, Lecture XXX, Monday, February 5, 1900 |
From: Robert H. <ha...@st...> - 2010-08-18 04:13:36
|
that pretty much does it... On Tue, Aug 17, 2010 at 12:12 PM, Nicolas Vervelle <nve...@gm...>wrote: > Hi, > > Could we get rid of the 'dead code' warnings ? > Most of them are due to code like : if (true || xxx) ... > which makes xxx a dead code. > > If it's intended, I see 2 ways of removing the warning : > > - Removing the dead code (if the true is definitive, it will clear it > definitely) > - Replacing the 'true' by a constant (final static boolean) set to true > : it will be a lot more comprehensible and the compiler should stop to > complain :) > > Nico > > > > ------------------------------------------------------------------------------ > This SF.net email is sponsored by > > Make an app they can't live without > Enter the BlackBerry Developer Challenge > http://p.sf.net/sfu/RIM-dev2dev > _______________________________________________ > Jmol-developers mailing list > Jmo...@li... > https://lists.sourceforge.net/lists/listinfo/jmol-developers > > -- Robert M. Hanson Professor of Chemistry St. Olaf College 1520 St. Olaf Ave. Northfield, MN 55057 http://www.stolaf.edu/people/hansonr phone: 507-786-3107 If nature does not answer first what we want, it is better to take what answer we get. -- Josiah Willard Gibbs, Lecture XXX, Monday, February 5, 1900 |
From: Nicolas V. <nve...@gm...> - 2010-08-18 17:11:49
|
Hi, Bob fixed the most obvious, here are the outstanding warnings for dead code : Description Resource Path Location Type Dead code JmolApp.java /Jmol/src/org/openscience/jmol/app line 372 Java Problem Dead code Jvxl.java /Jmol/src/org/openscience/jvxl line 283 Java Problem Dead code Jvxl.java /Jmol/src/org/openscience/jvxl line 313 Java Problem Dead code Mesh.java /Jmol/src/org/jmol/shape line 241 Java Problem Dead code ScriptMathProcessor.java /Jmol/src/org/jmol/script line 196 Java Problem Dead code ScriptMathProcessor.java /Jmol/src/org/jmol/script line 205 Java Problem Dead code SimplePopup.java /Jmol/src/org/jmol/popup line 400 Java Problem Nico On Tue, Aug 17, 2010 at 11:44 PM, Jonathan Gutow <gu...@uw...> wrote: > Nico, > Can you point to a specific piece of offending code? If the statements > really are the syntax you are suggesting they make little sense. > > Jonathan > On Aug 17, 2010, at 12:12 PM, Nicolas Vervelle wrote: > > Hi, > > Could we get rid of the 'dead code' warnings ? > Most of them are due to code like : if (true || xxx) ... > which makes xxx a dead code. > > If it's intended, I see 2 ways of removing the warning : > > - Removing the dead code (if the true is definitive, it will clear it > definitely) > - Replacing the 'true' by a constant (final static boolean) set to true > : it will be a lot more comprehensible and the compiler should stop to > complain :) > > Nico > > > ------------------------------------------------------------------------------ > This SF.net email is sponsored by > > Make an app they can't live without > Enter the BlackBerry Developer Challenge > http://p.sf.net/sfu/RIM-dev2dev > _______________________________________________ > Jmol-developers mailing list > Jmo...@li... > https://lists.sourceforge.net/lists/listinfo/jmol-developers > > > Dr. Jonathan H. Gutow > Chemistry Department gu...@uw... > UW-Oshkosh Office: 920-424-1326 > 800 Algoma Boulevard FAX:920-424-2042 > Oshkosh, WI 54901 > http://www.uwosh.edu/facstaff/gutow > > > > ------------------------------------------------------------------------------ > This SF.net email is sponsored by > > Make an app they can't live without > Enter the BlackBerry Developer Challenge > http://p.sf.net/sfu/RIM-dev2dev > _______________________________________________ > Jmol-developers mailing list > Jmo...@li... > https://lists.sourceforge.net/lists/listinfo/jmol-developers > > |
From: Tzontonel <and...@ya...> - 2010-08-18 20:09:00
|
If I coming in Ghent and I live an a Hostel for 3-4 days, it's possible to find? Or I have the same chances (internet). -- MSc. Apopei Andrei Ionut > and...@ge... Al. I. Cuza University, Department of Geology Carol I st. 11, 700506, Iasi, ROMANIA Romanian Database of Raman Spectroscopy ________________________________ From: Nicolas Vervelle <nve...@gm...> To: jmo...@li... Sent: Wed, August 18, 2010 8:11:22 PM Subject: Re: [Jmol-developers] Getting rid of 'dead code' warnings ? Hi, Bob fixed the most obvious, here are the outstanding warnings for dead code : Description Resource Path Location Type Dead code JmolApp.java /Jmol/src/org/openscience/jmol/app line 372 Java Problem Dead code Jvxl.java /Jmol/src/org/openscience/jvxl line 283 Java Problem Dead code Jvxl.java /Jmol/src/org/openscience/jvxl line 313 Java Problem Dead code Mesh.java /Jmol/src/org/jmol/shape line 241 Java Problem Dead code ScriptMathProcessor.java /Jmol/src/org/jmol/script line 196 Java Problem Dead code ScriptMathProcessor.java /Jmol/src/org/jmol/script line 205 Java Problem Dead code SimplePopup.java /Jmol/src/org/jmol/popup line 400 Java Problem Nico On Tue, Aug 17, 2010 at 11:44 PM, Jonathan Gutow <gu...@uw...> wrote: Nico, >Can you point to a specific piece of offending code? If the statements really >are the syntax you are suggesting they make little sense. > > >Jonathan > >On Aug 17, 2010, at 12:12 PM, Nicolas Vervelle wrote: > >Hi, >> >>Could we get rid of the 'dead code' warnings ? >>Most of them are due to code like : if (true || xxx) ... >>which makes xxx a dead code. >> >>If it's intended, I see 2 ways of removing the warning : >> >> * Removing the dead code (if the true is definitive, it will clear it >>definitely) >> * Replacing the 'true' by a constant (final static boolean) set to true : it >>will be a lot more comprehensible and the compiler should stop to complain >>:)Nico >> >> ------------------------------------------------------------------------------ >>This SF.net email is sponsored by >> >>Make an app they can't live without >>Enter the BlackBerry Developer Challenge >>http://p.sf.net/sfu/RIM-dev2dev >>_______________________________________________ >>Jmol-developers mailing list >>Jmo...@li... >>https://lists.sourceforge.net/lists/listinfo/jmol-developers >> > > Dr. Jonathan H. Gutow >Chemistry Department gu...@uw... >UW-Oshkosh Office: 920-424-1326 >800 Algoma Boulevard FAX:920-424-2042 >Oshkosh, WI 54901 > http://www.uwosh.edu/facstaff/gutow > >------------------------------------------------------------------------------ >This SF.net email is sponsored by > >Make an app they can't live without >Enter the BlackBerry Developer Challenge >http://p.sf.net/sfu/RIM-dev2dev >_______________________________________________ >Jmol-developers mailing list >Jmo...@li... >https://lists.sourceforge.net/lists/listinfo/jmol-developers > > |
From: Tzontonel <and...@ya...> - 2010-08-18 20:09:34
|
ohhh sorry, a wrong reply :( -- MSc. Apopei Andrei Ionut > and...@ge... Al. I. Cuza University, Department of Geology Carol I st. 11, 700506, Iasi, ROMANIA Romanian Database of Raman Spectroscopy ________________________________ From: Nicolas Vervelle <nve...@gm...> To: jmo...@li... Sent: Wed, August 18, 2010 8:11:22 PM Subject: Re: [Jmol-developers] Getting rid of 'dead code' warnings ? Hi, Bob fixed the most obvious, here are the outstanding warnings for dead code : Description Resource Path Location Type Dead code JmolApp.java /Jmol/src/org/openscience/jmol/app line 372 Java Problem Dead code Jvxl.java /Jmol/src/org/openscience/jvxl line 283 Java Problem Dead code Jvxl.java /Jmol/src/org/openscience/jvxl line 313 Java Problem Dead code Mesh.java /Jmol/src/org/jmol/shape line 241 Java Problem Dead code ScriptMathProcessor.java /Jmol/src/org/jmol/script line 196 Java Problem Dead code ScriptMathProcessor.java /Jmol/src/org/jmol/script line 205 Java Problem Dead code SimplePopup.java /Jmol/src/org/jmol/popup line 400 Java Problem Nico On Tue, Aug 17, 2010 at 11:44 PM, Jonathan Gutow <gu...@uw...> wrote: Nico, >Can you point to a specific piece of offending code? If the statements really >are the syntax you are suggesting they make little sense. > > >Jonathan > >On Aug 17, 2010, at 12:12 PM, Nicolas Vervelle wrote: > >Hi, >> >>Could we get rid of the 'dead code' warnings ? >>Most of them are due to code like : if (true || xxx) ... >>which makes xxx a dead code. >> >>If it's intended, I see 2 ways of removing the warning : >> >> * Removing the dead code (if the true is definitive, it will clear it >>definitely) >> * Replacing the 'true' by a constant (final static boolean) set to true : it >>will be a lot more comprehensible and the compiler should stop to complain >>:)Nico >> >> ------------------------------------------------------------------------------ >>This SF.net email is sponsored by >> >>Make an app they can't live without >>Enter the BlackBerry Developer Challenge >>http://p.sf.net/sfu/RIM-dev2dev >>_______________________________________________ >>Jmol-developers mailing list >>Jmo...@li... >>https://lists.sourceforge.net/lists/listinfo/jmol-developers >> > > Dr. Jonathan H. Gutow >Chemistry Department gu...@uw... >UW-Oshkosh Office: 920-424-1326 >800 Algoma Boulevard FAX:920-424-2042 >Oshkosh, WI 54901 > http://www.uwosh.edu/facstaff/gutow > >------------------------------------------------------------------------------ >This SF.net email is sponsored by > >Make an app they can't live without >Enter the BlackBerry Developer Challenge >http://p.sf.net/sfu/RIM-dev2dev >_______________________________________________ >Jmol-developers mailing list >Jmo...@li... >https://lists.sourceforge.net/lists/listinfo/jmol-developers > > |