From: Erik B. <eri...@gm...> - 2014-02-25 10:44:22
Attachments:
higherLimitsForJavadocErrorCount.diff
|
Hi, according to a post on Planet JDK [1], the default behaviour of the javadoc tool in JDK8 builds was changed to tolerate fewer errors. I've tried it out in a JDK8 Early Access Build (b128): producing the JavaDoc for Jikes RVM on hg tip produces 2851 errors and 4301 warnings (after increasing the maximum number of warnings and errors; see attached patch). Our "Making a release" [2] page on the wiki currently says that we'll fix all JavaDoc errors before the release is published. Should we relax this requirement or fix up the JavaDoc before the next release? Kind regards, Erik Brangs [1] http://blog.joda.org/2014/02/turning-off-doclint-in-jdk-8-javadoc.html [2] http://www.jikesrvm.org/Making+a+Release |
From: David P G. <gr...@us...> - 2014-02-26 21:46:59
|
Erik Brangs <eri...@gm...> wrote on 02/25/2014 05:44:08 AM: > > according to a post on Planet JDK [1], the default behaviour of the > javadoc tool in JDK8 builds was changed to tolerate fewer errors. > I've tried it out in a JDK8 Early Access Build (b128): producing the > JavaDoc for Jikes RVM on hg tip produces 2851 errors and 4301 > warnings (after increasing the maximum number of warnings and > errors; see attached patch). > > Our "Making a release" [2] page on the wiki currently says that > we'll fix all JavaDoc errors before the release is published. Should > we relax this requirement or fix up the JavaDoc before the next release? > Thanks for looking ahead and identifying the problem... Any chance some non-trivial fraction of them are from generated files (opt compiler IR, IA32 assembler, etc)? Those would be very easy to fix. We'll probably do something pragmatic and try to fix them, but maybe not get them all at once. In the interim the release page should probably say something like we'll fix all errors when running with --Xdoclint:none. --dave |
From: Erik B. <eri...@gm...> - 2014-02-27 09:24:12
|
Hi, On 26.02.2014 22:42, David P Grove wrote: > Any chance some non-trivial fraction of them are from generated files (opt compiler IR, IA32 assembler, etc)? Those would be very easy to fix. There a lot of JavaDoc errors (and warnings) in the generated IA32 assembler. I will correct those soon. The other warnings and errors seem to be distributed over written code (with the exception of a few warnings from the *Options and some generated operators). Kind regards, Erik Brangs |
From: Erik B. <eri...@gm...> - 2014-03-02 18:15:45
|
Hi, On 26.02.2014 22:42, David P Grove wrote: > We'll probably do something pragmatic and try to fix them, but maybe not get them all at once. I've fixed all the JavaDoc errors that I could find but I didn't fix any of the warnings. I suppose we'll have to fix the warnings gradually. I suggest that we keep this in mind in case we switch to Jenkins. IIRC Jenkins can be configured via plugins to fail builds if the number of problems increases. There may be some JavaDoc errors left over in PPC-specific code. I can't check for those because I can't install a JDK8 on any of the PPC machines that I can access. Kind regards, Erik Brangs |