Menu

#993 Preference page 'Offer expiry date': format check drops user changes

1.0
closed-works-for-me
JFireBase (268)
2
2010-09-12
2009-10-15
jfirechief
No

DO NOT EDIT OR ANSWER THIS ISSUE. SEE THE ORIGINAL ISSUE INSTEAD:
https://www.jfire.org/modules/bugs/view.php?id=1325
ORIGINAL REPORTER: alex

When the user changes the settings, enters a wrong format and tries to save, an error message appears telling the user that the format is wrong, then all changes are dropped and the old version is saved -> changes are lost.

Discussion

  • jfirechief

    jfirechief - 2009-10-15
    • labels: --> JFireBase
    • milestone: --> 1.0
    • summary: Preference page 'Offer expiry date': format check drops user changes --> Preference page 'Offer expiry date': format check drops user changes
    • priority: 5 --> 2
     
  • jfirechief

    jfirechief - 2009-10-19
    • assigned_to: nobody --> fleque
    • summary: Preference page 'Offer expiry date': format check drops user changes --> Preference page 'Offer expiry date': format check drops user changes
     
  • jfirechief

    jfirechief - 2009-10-19

    ORIGINAL COMMENT BY Nuwanda, VIEW IT HERE:
    https://www.jfire.org/modules/bugs/view.php?id=1325

    I cannot reproduce your findings. I tried to change it in 2 places:
    1) In the Eclipse preferences -> error pops up and no change is lost
    2) In the WorkstationEditor:
    - changed the modes of delivery without saving
    - entered wrong duration
    - saved & error msg pops up -> no changes lost.

    Please, be more precise in how the error can be reproduced.

     
  • jfirechief

    jfirechief - 2009-10-29
    • assigned_to: fleque --> onlynuwanda
    • summary: Preference page 'Offer expiry date': format check drops user changes --> Preference page 'Offer expiry date': format check drops user changes
     
  • jfirechief

    jfirechief - 2009-10-29

    ORIGINAL COMMENT BY Nuwanda, VIEW IT HERE:
    https://www.jfire.org/modules/bugs/view.php?id=1325

    I cannot reproduce your findings. I tried to change it in 2 places:
    1) In the Eclipse preferences -> error pops up and no change is lost
    2) In the WorkstationEditor:
    - changed the modes of delivery without saving
    - entered wrong duration
    - saved & error msg pops up -> no changes lost.

    Please, be more precise in how the error can be reproduced.

     
  • jfirechief

    jfirechief - 2009-10-29

    ORIGINAL COMMENT BY alex, VIEW IT HERE:
    https://www.jfire.org/modules/bugs/view.php?id=1325

    In the preference dialog open the pae:

    Default entry for expiry duration is:
    1d 0h 0m 0s 0msec

    change it to invalid (suppose the user misstyped the msec):
    2d 1h 30m 0s xmsec

    save

    Message pops up and change is lost, entry is again
    1d 0h 0m 0s 0msec

    Not sure how this can be achieved but the behaviour should be
    that the user is notified before the save that the format
    is wrong and he should be able to correct his error instead
    of being forced to enter all again.

    However, low priority.

     
  • jfirechief

    jfirechief - 2009-11-16

    ORIGINAL COMMENT BY Nuwanda, VIEW IT HERE:
    https://www.jfire.org/modules/bugs/view.php?id=1325

    I cannot reproduce your findings. I tried to change it in 2 places:
    1) In the Eclipse preferences -> error pops up and no change is lost
    2) In the WorkstationEditor:
    - changed the modes of delivery without saving
    - entered wrong duration
    - saved & error msg pops up -> no changes lost.

    Please, be more precise in how the error can be reproduced.

     
  • jfirechief

    jfirechief - 2009-11-16
    • summary: Preference page 'Offer expiry date': format check drops user changes --> Preference page 'Offer expiry date': format check drops user changes
    • status: open --> open-works-for-me
     
  • jfirechief

    jfirechief - 2009-11-16

    ORIGINAL COMMENT BY alex, VIEW IT HERE:
    https://www.jfire.org/modules/bugs/view.php?id=1325

    In the preference dialog open the pae:

    Default entry for expiry duration is:
    1d 0h 0m 0s 0msec

    change it to invalid (suppose the user misstyped the msec):
    2d 1h 30m 0s xmsec

    save

    Message pops up and change is lost, entry is again
    1d 0h 0m 0s 0msec

    Not sure how this can be achieved but the behaviour should be
    that the user is notified before the save that the format
    is wrong and he should be able to correct his error instead
    of being forced to enter all again.

    However, low priority.

     
  • jfirechief

    jfirechief - 2009-11-16

    ORIGINAL COMMENT BY Nuwanda, VIEW IT HERE:
    https://www.jfire.org/modules/bugs/view.php?id=1325

    I tried to reproduce your description of the bug, but neither in the 1.0 branch nor in the 1.1 trunk I was able to get the text field to be reset.
    If I change it to say "2d 1h 30m 0s xmsec" and press apply, then the error message box pops up (twice, but that's another problem) and the text field stays unchanged.

    I asked Kai to tray it, too and again he wasn't able to reproduce this behaviour. Setting it to unable to reproduce.

     
  • jfirechief

    jfirechief - 2010-09-12
    • summary: Preference page 'Offer expiry date': format check drops user changes --> Preference page 'Offer expiry date': format check drops user changes
    • status: open-works-for-me --> closed-works-for-me
     
  • jfirechief

    jfirechief - 2010-09-12

    ORIGINAL COMMENT BY Nuwanda, VIEW IT HERE:
    https://www.jfire.org/modules/bugs/view.php?id=1325

    I cannot reproduce your findings. I tried to change it in 2 places:
    1) In the Eclipse preferences -> error pops up and no change is lost
    2) In the WorkstationEditor:
    - changed the modes of delivery without saving
    - entered wrong duration
    - saved & error msg pops up -> no changes lost.

    Please, be more precise in how the error can be reproduced.

     
  • jfirechief

    jfirechief - 2010-09-12

    ORIGINAL COMMENT BY Nuwanda, VIEW IT HERE:
    https://www.jfire.org/modules/bugs/view.php?id=1325

    I tried to reproduce your description of the bug, but neither in the 1.0 branch nor in the 1.1 trunk I was able to get the text field to be reset.
    If I change it to say "2d 1h 30m 0s xmsec" and press apply, then the error message box pops up (twice, but that's another problem) and the text field stays unchanged.

    I asked Kai to tray it, too and again he wasn't able to reproduce this behaviour. Setting it to unable to reproduce.

     
  • jfirechief

    jfirechief - 2010-09-12

    ORIGINAL COMMENT BY alex, VIEW IT HERE:
    https://www.jfire.org/modules/bugs/view.php?id=1325

    In the preference dialog open the pae:

    Default entry for expiry duration is:
    1d 0h 0m 0s 0msec

    change it to invalid (suppose the user misstyped the msec):
    2d 1h 30m 0s xmsec

    save

    Message pops up and change is lost, entry is again
    1d 0h 0m 0s 0msec

    Not sure how this can be achieved but the behaviour should be
    that the user is notified before the save that the format
    is wrong and he should be able to correct his error instead
    of being forced to enter all again.

    However, low priority.

     

Log in to post a comment.